Not quite correct patch for toggling various windows from mainmenu->window submenu
Well, I'm fairly sure void MWindow::hide_vwindow() kinda wrong (because copypasta!) but it seems to work for single viewer window I wanted to hide via this menu.
Andrew, This patch has been tested on my laptop and I did not encounter a problem. Is there still a problem with this "Not quite correct patch"? so that it should not be checked into GIT? Well, I'm fairly sure
void MWindow::hide_vwindow() kinda wrong (because copypasta!)
but it seems to work for single viewer window I wanted to hide via this menu.
В сообщении от Wednesday 02 December 2020 06:24:15 Phyllis Smith via Cin написал(а):
Andrew, This patch has been tested on my laptop and I did not encounter a problem. Is there still a problem with this "Not quite correct patch"? so that it should not be checked into GIT?
I dunno. I most afraid of hidden memleak/reference counting problem ..try few cinGG instances at once?
Well, I'm fairly sure
void MWindow::hide_vwindow() kinda wrong (because copypasta!)
but it seems to work for single viewer window I wanted to hide via this menu.
participants (2)
-
Andrew Randrianasulu -
Phyllis Smith