On 220914-20:36+0300, Andrew Randrianasulu wrote:
attached two git diff files
first is fixing your compile error, second requires manually adding libtiff-4.4.0.tar.xz source tarball from libtiff's homepage into thirdparty/src
it compiles here on termux/aarch64 but might error out on different (especially older) systems ....
Yeah, I saw: [Cin] libtiff 4.4.0 https://lists.cinelerra-gg.org/pipermail/cin/2022-September/005466.html which you also posted.
ср, 14 сент. 2022 г., 20:21 Miroslav Rovis <[email protected]>:
On 220914-17:49+0300, Andrew Randrianasulu wrote:
ср, 14 сент. 2022 г., 17:41 Miroslav Rovis <[email protected] :
On 220914-17:19+0300, Andrew Randrianasulu wrote:
ср, 14 сент. 2022 г., 16:12 Miroslav Rovis < [email protected] :
On 220914-14:51+0200, Miroslav Rovis wrote: > On 220914-15:08+0300, Andrew Randrianasulu wrote: [...] make[2]: *** [Makefile:536: /the-path/cinelerra/cinelerra-5.1/cinelerra/../bin/cin] Error 1 make[2]: Leaving directory '/the-path/cinelerra/cinelerra-5.1/cinelerra' make[1]: *** [Makefile:585: all-recursive] Error 1 make[1]: Leaving directory '/the-path/cinelerra/cinelerra-5.1' make: *** [Makefile:532: all] Error 2
Meaning, IMHO, the --disable-tiff is not honored. That appears to me like another bug, but I'm not an expert.
And am a litte disoriented with all the errors the Cinelerra is now throwing at us :-) .
[...]
i guess libtiff had some new dependency ..I tried to disable it in thirdparty/Makefile like this:
git diff thirdparty/Makefile diff --git a/cinelerra-5.1/thirdparty/Makefile b/cinelerra-5.1/thirdparty/Makefile index 4e952989..845c84f1 100644 --- a/cinelerra-5.1/thirdparty/Makefile +++ b/cinelerra-5.1/thirdparty/Makefile @@ -257,7 +257,7 @@ openexr.mak_vars?=true; \# opus.cfg_params?= --disable-extra-programs speech_tools.mak_params?=-j1 tiff.cfg_vars+=LIBS+=" -lpthread"; autoreconf -ifv -I m4 && automake -caf; -tiff.cfg_params+= --disable-libdeflate --enable-shared=no --disable-zstd $(call if_pkg,libwebp,\ +tiff.cfg_params+= --disable-libdeflate --disable-lerc --enable-shared=no --disable-zstd $(call if_pkg,libwebp,\ --with-webp-include-dir=$(call pkg_incl,libwebp)\ --with-webp-lib-dir=$(call pkg_libs,libwebp))\ $(call if_npkg,libwebp,--disable-webp)
basically add '--disable-lerc" into tiff.cfg_params line
let us know if this resolves compilation error ... and then if resulting Cingg still can create various tiff files ...
Apology for long wait.
Yes, that works. I have installed Cinelerra that I built and set it to do some work right away. It appears to work normally.
How do I test it to create tiff files? Umhh... I rendered what I had opened to work on, chose a small selection and, yes, it did render in <that-work>.tiff.
Thanks for this tiny diff that fixed it for me!
I'll be back if there are more issues.
Regards!
-- Miroslav Rovis Zagreb, Croatia https://www.CroatiaFidelis.hr my PGP-key: https://www.croatiafidelis.hr/FCF13245ED247DCE443855B7EA9884884FBAF0AE.asc
From b6ff492a4a5a3f92e019770ca81b5ed0fb4b873a Mon Sep 17 00:00:00 2001 From: Andrew Randrianasulu <[email protected]> Date: Wed, 14 Sep 2022 19:49:51 +0300 Subject: [PATCH 2/2] upgrade libtiff to 4.4.0
--- cinelerra-5.1/configure.ac | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/cinelerra-5.1/configure.ac b/cinelerra-5.1/configure.ac index 06c0531d..5f0ffe39 100644 --- a/cinelerra-5.1/configure.ac +++ b/cinelerra-5.1/configure.ac @@ -405,7 +405,7 @@ PKG_3RD([ilmBase],[auto], [ilmBase], [] []) # []) # PKG_3RD([tiff],[auto], - [tiff-4.3.0], + [tiff-4.4.0], [ libtiff/.libs/libtiff.a \ libtiff/.libs/libtiffxx.a \ port/.libs/libport.a ],[ -- 2.37.3
From ff3d9de1e22b22833baa9bf36aff72ebbfb9c041 Mon Sep 17 00:00:00 2001 From: Andrew Randrianasulu <[email protected]> Date: Wed, 14 Sep 2022 19:38:39 +0300 Subject: [PATCH 1/2] Potentially fix libtiff compilation
--- cinelerra-5.1/thirdparty/Makefile | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/cinelerra-5.1/thirdparty/Makefile b/cinelerra-5.1/thirdparty/Makefile index 4e952989..845c84f1 100644 --- a/cinelerra-5.1/thirdparty/Makefile +++ b/cinelerra-5.1/thirdparty/Makefile @@ -257,7 +257,7 @@ openexr.mak_vars?=true; \# opus.cfg_params?= --disable-extra-programs speech_tools.mak_params?=-j1 tiff.cfg_vars+=LIBS+=" -lpthread"; autoreconf -ifv -I m4 && automake -caf; -tiff.cfg_params+= --disable-libdeflate --enable-shared=no --disable-zstd $(call if_pkg,libwebp,\ +tiff.cfg_params+= --disable-libdeflate --disable-lerc --enable-shared=no --disable-zstd $(call if_pkg,libwebp,\ --with-webp-include-dir=$(call pkg_incl,libwebp)\ --with-webp-lib-dir=$(call pkg_libs,libwebp))\ $(call if_npkg,libwebp,--disable-webp) -- 2.37.3
-- Miroslav Rovis Zagreb, Croatia https://www.CroatiaFidelis.hr my PGP-key: https://www.croatiafidelis.hr/FCF13245ED247DCE443855B7EA9884884FBAF0AE.asc