чт, 17 окт. 2024 г., 05:29 Phyllis Smith <phylsmith2017@gmail.com>:
Yes! patching thirdparty/Makefile as shown immediately below, now builds.  But I have no concept as to how you figured this out and why it works?

I have libjpeg-turbo 3.0.4 on termux, and for me build was ok, so I guessed something from system was interfering with build. I start to mess with thirdparty/Makefile and noticed I accidently changed this line. I was rebuilding just tiff by removing thirdparty/tiff dir and thirdparty/build/tiff.*, so I watched exact command line as it was executing and noticed now CFLAGS was not empty.

On my desktop Slackware I have libjpeg-turbo 2.1.2 so I will make another test there ... but not at 6 am ;) probably


On Wed, Oct 16, 2024 at 6:43 PM Andrew Randrianasulu <randrianasulu@gmail.com> wrote:


чт, 17 окт. 2024 г., 03:32 Phyllis Smith <phylsmith2017@gmail.com>:
Tested 3.0.4 - attached log with same error.

thanks ..


can you check if patching thirdparty/Makefile like this

diff --git a/cinelerra-5.1/thirdparty/Makefile b/cinelerra-5.1/thirdparty/Makefile                 
index bb987b0a..04f7c2f4 100644                                                                    
--- a/cinelerra-5.1/thirdparty/Makefile                                                            
+++ b/cinelerra-5.1/thirdparty/Makefile                                                            
@@ -265,9 +265,12 @@ openexr.mak_vars?=true; \#                                                     
opus.cfg_params?= --disable-extra-programs                  speech_tools.mak_params?=-j1                                                                       
tiff.ldflags?="$(call ld_path,libjpeg,build)"                                                     
-tiff.cflags?="$(call lnc_path,libjpeg)"                                                           
+tiff.cflags?="$(call inc_path,libjpeg)"                                                            
tiff.cfg_vars+=LIBS+=" -lpthread"; autoreconf -ifv -I m4 && automake -caf;

i.e. change Inc_path (capital I) to inc_path (small i)

improves buildability ?



On Wed, Oct 16, 2024 at 6:18 PM Andrew Randrianasulu <randrianasulu@gmail.com> wrote:


чт, 17 окт. 2024 г., 02:30 Andrew Randrianasulu <randrianasulu@gmail.com>:


чт, 17 окт. 2024 г., 02:18 Phyllis Smith <phylsmith2017@gmail.com>:
Attached is the log from the build with libjpeg-turbo version 3.0.3 BUT 3.0.1 had the same error.  I have not tried 3.0.4 but will do so later today yet (hopefully).

there also new libtiff 4.7.0, at


but may be we just build against different libjpeg-turbo includes ? Need to check ....

hm, may be it does not pick includes from correct place...

can you also post config.log from thirdparty/tiff directory after build fails?




On Wed, Oct 16, 2024 at 4:47 PM Andrew Randrianasulu <randrianasulu@gmail.com> wrote:


ср, 16 окт. 2024 г., 22:47 Phyllis Smith via Cin <cin@lists.cinelerra-gg.org>:
Library updates checked into GIT:
  libvpx from 1.13.1 to 1.14.1
  libwebp from 1.3.2 to 1.4.0

That completes the library updates for a while except for libjpeg-turbo which is currently at 2.1.5.1 and could be updated to 3.0.3 but does not build.  Maybe when Andrew has time he can look at this -- I think the error is due to WITH_12BIT, but I do not know for sure or how to fix that. 

I tried with 3.0.4 and it builds for me on Termux (now with clang 19.1.2) BUT I see failure in mjpegtools/y4mdenoise, I do not think we need program itself so I disabled it (see attached patch).

Can you post exact error text?




It seems like the below url thinks it is in CMakeLists.txt.  I did compare it to the current version but there are a lot of  differences.  URL is:  https://github.com/libjpeg-turbo/libjpeg-turbo/issues/466

--
Cin mailing list
Cin@lists.cinelerra-gg.org
https://lists.cinelerra-gg.org/mailman/listinfo/cin