ср, 25 янв. 2023 г., 11:56 Stefan de Konink <[email protected]>:
On Wednesday, January 25, 2023 9:51:46 AM CET, Andrew Randrianasulu wrote:
It does not fix any bug I know of, so probably safest way to leave code as it was before me (because threads!) and probably revisit if some tool show issue or user report it.
Developing software is not equal to copy-pasting. I would like to see an explanation why someone would not want to unlock, while that happens in any other case.
Just for making things more clear: *I* added this unlock, not because I knew what I was doing but simply because yeah, it looked like this place might need it. In theory oicks protects shared resources, so one thread may leave object/variable around without worry another thread scheduled by kernel will overwrite it. But I do not know enough of details for carelessly altering locking like I did. So, Phyllis removed this line on my request, because, I reiterate, I put it there literally on a whim.
-- Stefan