On Tuesday, May 3, 2022, Andrew Randrianasulu <randrianasulu@gmail.com> wrote:


On Tuesday, May 3, 2022, Phyllis Smith <phylsmith2017@gmail.com> wrote:
A little more testing shows 1 small issue -- it is now just 1 big chapter so you can fast forward but can not skip to the next chapter since there are none.

there is 

--auto-chapters Insert a chapter every <n> minutes. Used only in BD/AVCHD

option for tsmuxer. 

you can try to set it by hand in bd.meta file and remux, and if it works as intended we can put it into default tsmuxer options... 


something like this (ignore first strcpy delete - git rebase pulled same string twice..) 

$ git diff bdcreate.C
diff --git a/cinelerra-5.1/cinelerra/bdcreate.C b/cinelerra-5.1/cinelerra/bdcreate.C
index 7930114f..16c655a5 100644
--- a/cinelerra-5.1/cinelerra/bdcreate.C
+++ b/cinelerra-5.1/cinelerra/bdcreate.C
@@ -230,8 +230,6 @@ CreateBD_Thread::CreateBD_Thread(MWindow *mwindow)

        strcpy(use_profile,"bluray.m2ts");

- strcpy(use_profile,"bluray.m2ts");
-
        this->bd_size = BD_SIZE;
        this->bd_width = BD_WIDTH;
        this->bd_height = BD_HEIGHT;
@@ -349,12 +347,14 @@ int CreateBD_Thread::create_bd_jobs(ArrayList<BatchRenderJob*> *jobs, const char
        }


- fprintf(fp,"MUXOPT --blu-ray --hdmv-descriptors\n");
+ fprintf(fp,"MUXOPT --blu-ray --hdmv-descriptors --auto-chapters=5\n");
        fprintf(fp,"V_MPEG4/ISO/AVC, bd.m2ts, track=4113\n");
        if(!strcmp(use_profile, "bluray.m2ts"))
        fprintf(fp,"A_AC3, bd.m2ts, track=4352\n");
        if(!strcmp(use_profile, "bluray_lpcm.m2ts"))
        fprintf(fp,"A_LPCM, bd.m2ts, track=4352\n");
+ if(!strcmp(use_profile, "bluray_truehd.m2ts"))
+ fprintf(fp,"A_MLP, bd.m2ts, track=4352\n");
        fprintf(fp,"\n");
        fclose(fp);

$




 
 
Not sure if having chapters is even possible, but better than giving errors.  Thanks.

On Mon, May 2, 2022 at 12:08 PM Andrew Randrianasulu <randrianasulu@gmail.com> wrote:
attempt at fixing our version of patch to behave the same as new upstream

Phyllis, I am terribly sorry - can you retest BBB - > lpcm bluray again with this patch and tsmuxer? 

ps: I think cmake can generate plain Makefiles, not ninja ones... you can try and tweak linux build script by removing '-G ninja' ... 

On Monday, May 2, 2022, Andrew Randrianasulu <randrianasulu@gmail.com> wrote:
https://git.ffmpeg.org/gitweb/ffmpeg.git/blobdiff/b67572c7c707d508b15ce0543519208cf5d1fcfb..a84b95dc08da1174b4477e6250077bf22bb543b0:/libavcodec/pcm-blurayenc.c

need to adapt..... 

Paul, *BIG* thanks for speedy responce!