Checked patch into GIT after testing before and after as recommended. It must be Slackware specific because it did not crash before on Fedora 64-bit - or maybe 32-bit but anyway it is an improvement. I still will be doing more testing tomorrow with additional un-do's to stress it a bit more. On Mon, Dec 26, 2022 at 12:59 PM Andrew Randrianasulu < [email protected]> wrote:
пн, 26 дек. 2022 г., 22:54 Phyllis Smith <[email protected]>:
I will test that but I am not very good at testing and was hoping from feedback from someone who is better at it. Will start testing that in about 30 minutes.
I tested ot like this.
load some jpg image, it will expand itself as default 3 sec long timeline.
"Save as" with xml extension.
Load this xml as nested.
hit 'undo' right away.
for me cingg crashes :(
On Mon, Dec 26, 2022 at 12:17 PM Andrew Randrianasulu < [email protected]> wrote:
вс, 20 нояб. 2022 г., 01:23 Phyllis Smith <[email protected]>:
*IgorBeghetto:* I created an AppImage that contains the BT #558 bug fix (0x00 vs. 0xff) AND with these 2 Experimental patches in to fix "nested edl undo crash" so you could test if you find the time. The fix for 558 is the most important though and you already built that. It is at: https://cinelerra-gg.org/download/testing/test_ubuntu16.AppImage
Locking and unlocking are extremely sensitive and can cause all kinds of weird crashes so I guess that is why the patch is called EXPERIMENTAL. But could definitely be the missing part and fix the problem.
I recompiled cingg on my Slackware without those two patches and sadly crash on nested edl load/undo still around :(
Phyllis, can you just add part with checking existence of edl, and may be leave locking changes out for now? ( I thought we should unlock in same function if we exit from it but may be I am wrong ...)
On Sun, Nov 13, 2022 at 6:50 PM Andrew Randrianasulu < [email protected]> wrote:
---------- Forwarded message --------- От: Андрей Рандрианасулу <[email protected]> Date: пн, 14 нояб. 2022 г., 04:37 Subject: oh, my fix for nested edl undo crash regressed video! To: randrianasulu <[email protected]>
better (?) fix (tested with video this time)
-- Андрей Рандрианасулу