Den 26.10.2024 01:37, skrev Andrew Randrianasulu:


On Sat, Oct 26, 2024 at 2:14 AM Andrew Randrianasulu <randrianasulu@gmail.com> wrote:


On Sat, Oct 26, 2024 at 1:29 AM Andrew Randrianasulu <randrianasulu@gmail.com> wrote:


сб, 26 окт. 2024 г., 00:58 Terje J. Hanssen <terjejhanssen@gmail.com>:



Den 25.10.2024 21:48, skrev Andrew Randrianasulu:
We branching!

I looked at gpu-screen-recorder


it sets

AVHWFramesContext *hw_frame_context = (AVHWFramesContext*)frame_context->data;
    hw_frame_context->width = video_codec_context->width;
    hw_frame_context->height = video_codec_context->height;
    hw_frame_context->sw_format = self->params.color_depth == GSR_COLOR_DEPTH_10_BITS ? AV_PIX_FMT_P010LE : AV_PIX_FMT_NV12;
    hw_frame_context->format = video_codec_context->pix_fmt;
    hw_frame_context->device_ctx = (AVHWDeviceContext*)self->device_ctx->data;


so may be we need to set AV_PIX_FMT_P010LE and not just P010?

Sorry, It didn't render more than 8bit yuv420p

I continue from the last point above with a similar setup for VAAPI that I just did for Quicksync Video - QSV encoding with system ffmpeg 7.1:
https://lists.cinelerra-gg.org/pipermail/cin/2024-October/008950.html

FFmpeg supported VAAPI pixel formats and profiles:

ffmpeg -hide_banner -encoders | grep vaapi
 V....D av1_vaapi            AV1 (VAAPI) (codec av1)
 V....D h264_vaapi           H.264/AVC (VAAPI) (codec h264)
 V....D hevc_vaapi           H.265/HEVC (VAAPI) (codec hevc)
 V....D mjpeg_vaapi          MJPEG (VAAPI) (codec mjpeg)
 V....D mpeg2_vaapi          MPEG-2 (VAAPI) (codec mpeg2video)
 V....D vp8_vaapi            VP8 (VAAPI) (codec vp8)
 V....D vp9_vaapi            VP9 (VAAPI) (codec vp9)


ffmpeg -hide_banner -h encoder=av1_vaapi | egrep 'Supported|profile|main|high|professional'
    Supported hardware devices: vaapi
    Supported pixel formats: vaapi
  -profile           <int>        E..V....... Set profile (seq_profile) (from -99 to 255) (default -99)
     main            0            E..V.......
     high            1            E..V.......
     professional    2            E..V.......
  -tier              <int>        E..V....... Set tier (seq_tier) (from 0 to 1) (default main)
     main            0            E..V.......
     high            1            E..V.......


ffmpeg -hide_banner -h encoder=hevc_vaapi | egrep 'Supported|profile|main|high|professional'
    Supported hardware devices: vaapi
    Supported pixel formats: vaapi
  -profile           <int>        E..V....... Set profile (general_profile_idc) (from -99 to 255) (default -99)
     main            1            E..V.......
     main10          2            E..V.......
  -tier              <int>        E..V....... Set tier (general_tier_flag) (from 0 to 1) (default main)
     main            0            E..V.......
     high            1            E..V.......


ffmpeg -hide_banner -h encoder=h264_vaapi | egrep 'Supported|profile|main|high|professional'
    Supported hardware devices: vaapi
    Supported pixel formats: vaapi
  -quality           <int>        E..V....... Set encode quality (trades off against speed, higher is faster) (from -1 to INT_MAX) (default -1)
  -profile           <int>        E..V....... Set profile (profile_idc and constraint_set*_flag) (from -99 to 65535) (default -99)
     main            77           E..V.......
     high            100          E..V.......
     high10          110          E..V.......


Supported pixel formats tell just "vaapi" and not more info about them as corresponding QSV do.

The libva implementation and tools give more detailed info about the available pixel formats for encoding:

 vainfo | grep VAEntrypointEncSlice
libva info: VA-API version 1.22.0
libva info: Trying to open /usr/lib64/dri/iHD_drv_video.so
libva info: Found init function __vaDriverInit_1_22
libva info: va_openDriver() returns 0
      VAProfileH264Main               :    VAEntrypointEncSliceLP
      VAProfileH264High               :    VAEntrypointEncSliceLP
      VAProfileH264ConstrainedBaseline:    VAEntrypointEncSliceLP
      VAProfileHEVCMain               :    VAEntrypointEncSliceLP
      VAProfileHEVCMain10             :    VAEntrypointEncSliceLP
      VAProfileVP9Profile0            :    VAEntrypointEncSliceLP
      VAProfileVP9Profile1            :    VAEntrypointEncSliceLP
      VAProfileVP9Profile2            :    VAEntrypointEncSliceLP
      VAProfileVP9Profile3            :    VAEntrypointEncSliceLP
      VAProfileHEVCMain422_10         :    VAEntrypointEncSliceLP
      VAProfileHEVCMain444            :    VAEntrypointEncSliceLP
      VAProfileHEVCMain444_10         :    VAEntrypointEncSliceLP
      VAProfileHEVCSccMain            :    VAEntrypointEncSliceLP
      VAProfileHEVCSccMain10          :    VAEntrypointEncSliceLP
      VAProfileHEVCSccMain444         :    VAEntrypointEncSliceLP
      VAProfileAV1Profile0            :    VAEntrypointEncSliceLP
      VAProfileHEVCSccMain444_10      :    VAEntrypointEncSliceLP



Format p010le results in "just" 10bit yuv420p.

The clue for hevc_vaapi to encode true 10bit 422p video, is found to use (trying this for av1_vaapi auto-switch to 8bit p010):

         -vf 'format=y210,hwupload'

After troubleshooting a useable profile, rendering went on by simply leaving profile out:


Example ffmpeg 7.1 simple code line for hevc_vaapi encoding (without audio):

ffmpeg -hide_banner -vaapi_device /dev/dri/renderD128 -i cfhd01.mkv -vf 'format=y210,hwupload' -c:v hevc_vaapi cfhd01_hevc_vaapi_format_y210.mp4


yuv422p10le input file:
-----------------------
ffprobe -hide_banner cfhd01.mkv
Input #0, matroska,webm, from 'cfhd01.mkv':
  Metadata:
    ENCODER         : Lavf61.1.100
  Duration: 00:01:11.24, start: 0.000000, bitrate: 393480 kb/s
  Stream #0:0(eng): Video: cfhd (CFHD / 0x44484643), yuv422p10le(tv, bt709, top coded first (swapped)), 1920x1080, SAR 1:1 DAR 16:9, 25 fps, 25 tbr, 1k tbn (default)
      Metadata:
        HANDLER_NAME    : Apple Video Media Handler
        VENDOR_ID       : appl
        ENCODER         : Lavc61.3.100 cfhd
        DURATION        : 00:01:11.240000000


yuv422p10le ourput file:

ffprobe -hide_banner cfhd01_hevc_vaapi_format_y210.mp4
Input #0, mov,mp4,m4a,3gp,3g2,mj2, from 'cfhd01_hevc_vaapi_format_y210.mp4':
  Metadata:
    major_brand     : isom
    minor_version   : 512
    compatible_brands: isomiso2mp41
    encoder         : Lavf61.7.100
  Duration: 00:01:11.24, start: 0.000000, bitrate: 12129 kb/s
  Stream #0:0[0x1](eng): Video: hevc (Rext) (hev1 / 0x31766568), yuv422p10le(tv, bt709, progressive), 1920x1080 [SAR 1:1 DAR 16:9], 12127 kb/s, 25 fps, 25 tbr, 12800 tbn (default)
      Metadata:
        handler_name    : Apple Video Media Handler
        vendor_id       : [0][0][0][0]
        encoder         : Lavc61.19.100 hevc_vaapi



yeahh ... probably need more  debugging (seeing what pixel format goes into ffmpeg vaapi interface at least).

I only have decoding on nouveau, and quite flaky at that - only 2 files so far worked w,/o crashing, from around 2011/12.


I tried to change two instances of NV12 to P010LE and it  shows no visible effect, so I assume it was supposed to  work with encoding ...?

it does not work even with qsv set to p010 AND patch ?

if so, I am afraid I only can put this item on shelf ... for now. Look at mantis bug database, if there is no entry about 10bit vaapi deciding/encoding - add it please ....

you can also test (at some point in time ) this gpu_screen_recorder, it builds but does not work for me due to "nouveau" driver.



at least with another patch (attached) I can get this:

bash-5.1$ bin/cin  ~/6029.mp4
Cinelerra Infinity - built: Oct 17 2024 16:18:31
git://git.cinelerra-gg.org/goodguy/cinelerra.git
(c) 2006-2019 Heroine Virtual Ltd. by Adam Williams
2007-2020 mods for Cinelerra-GG by W.P.Morrow aka goodguy
2003-2017 mods for Cinelerra-CV by CinelerraCV team
2015-2024 mods for Cinelerra-GG by Cinelerra-GG team

Libav version: Lavc61.3.100

Cinelerra is free software, covered by the GNU General Public License,
and you are welcome to change it and/or distribute copies of it under
certain conditions. There is absolutely no warranty for Cinelerra.

RenderFarmClient::main_loop: client started
[AVHWDeviceContext @ 0xf925c00] Trying to use DRM render node for device 0.
[AVHWDeviceContext @ 0xf925c00] libva: VA-API version 1.19.0
[AVHWDeviceContext @ 0xf925c00] libva: Trying to open /usr/lib/dri/nouveau_drv_video.so
[AVHWDeviceContext @ 0xf925c00] libva: Found init function __vaDriverInit_1_19
[AVHWDeviceContext @ 0xf925c00] libva: va_openDriver() returns 0
[AVHWDeviceContext @ 0xf925c00] Initialised VAAPI connection: version 1.19
[AVHWDeviceContext @ 0xf925c00] Format 0x3231564e -> nv12.
[AVHWDeviceContext @ 0xf925c00] Format 0x30313050 -> p010le.
[AVHWDeviceContext @ 0xf925c00] Format 0x36313050 -> unknown.
[AVHWDeviceContext @ 0xf925c00] Format 0x30323449 -> yuv420p.
[AVHWDeviceContext @ 0xf925c00] Format 0x32315659 -> yuv420p.
[AVHWDeviceContext @ 0xf925c00] Format 0x56595559 -> unknown.
[AVHWDeviceContext @ 0xf925c00] Format 0x32595559 -> yuyv422.
[AVHWDeviceContext @ 0xf925c00] Format 0x59565955 -> uyvy422.
[AVHWDeviceContext @ 0xf925c00] Format 0x41524742 -> bgra.
[AVHWDeviceContext @ 0xf925c00] Format 0x41424752 -> rgba.
[AVHWDeviceContext @ 0xf925c00] Format 0x58524742 -> bgr0.
[AVHWDeviceContext @ 0xf925c00] Format 0x58424752 -> rgb0.
[AVHWDeviceContext @ 0xf925c00] VAAPI driver: Mesa Gallium driver 22.1.7 for NV106.
[AVHWDeviceContext @ 0xf925c00] Driver not found in known nonstandard list, using standard behaviour.
[AVHWFramesContext @ 0xea43980] Created surface 0x1.
[AVHWFramesContext @ 0xea43980] Direct mapping possible.
[av1_vaapi @ 0xf978680] Input surface format is p010le.
[av1_vaapi @ 0xf978680] Compatible profile VAProfileAV1Profile0 (32) is not supported by driver.
[av1_vaapi @ 0xf978680] No usable encoding profile found.
FFMPEG::open_encoder  err: Function not implemented
int FFMPEG::open_encoder(const char*, const char*):
open failed av1_vaapi:/dev/shm/yuv-test-reenc-rgba8-mpeg-range.webm
Render::render_single: Session finished.
Total excess of backups: -50
[AVIOContext @ 0xeaf1aa40] Statistics: 4570842 bytes read, 5 seeks
[AVIOContext @ 0xeaf348c0] Statistics: 2997978 bytes read, 2 seeks
[AVIOContext @ 0xd7aa8900] Statistics: 4272574 bytes read, 2 seeks
[AVIOContext @ 0xd7954080] Statistics: 2997978 bytes read, 2 seeks
[AVIOContext @ 0xf40c2840] Statistics: 9351290 bytes read, 18 seeks
[AVIOContext @ 0xf4008a00] Statistics: 2997978 bytes read, 2 seeks
Session time: 0:00:48
Cpu time: user: 0:00:09.659 sys: 0:00:03.077

so i guess it sets surface format now correctly, just no encoder entrypoint (obviously on my hw)?
 
Terje, Andrea - can you test this hack ?


one more time, this time with env variable

 CIN_10BIT_ENC=1  bin/cin  ~/6029.mp4    

should enable P010LE input surface format ...but you probably need to set profile etc manually?