Working on adding GPL license attribution for all program files
As Andrew pointed out: "GPL license states each file should have attribution ...." so I checked into GIT the addition of missing GPL information for the *guicast subdirectory *and am working on the cinelerra subdirectory and eventually plugins subdirectory. Some notes: 1) When header missing, first checked to see if file exists in Cinelerra HV-8 or CV. If files existed there but no header, used header in like files. For example, bccmodels.inc in HV-8 had no header but bccmodels.C did, so used the same one. 2) Files, like bootstrap.c, that exist in HV and have no header, I left unchanged because I have no idea where this file came from and it has an extension of lower case "c" instead of upper case "C". 3) Any file in Cinelerra-HV that did not have the Copyright/Name/Year, I did not change in CinGG, so that it would match. If Andrew has time to verify and thinks something should have been done differently, please let me know.
ср, 4 янв. 2023 г., 22:30 Phyllis Smith <[email protected]>:
As Andrew pointed out: "GPL license states each file should have attribution ...." so I checked into GIT the addition of missing GPL information for the *guicast subdirectory *and am working on the cinelerra subdirectory and eventually plugins subdirectory. Some notes:
1) When header missing, first checked to see if file exists in Cinelerra HV-8 or CV. If files existed there but no header, used header in like files. For example, bccmodels.inc in HV-8 had no header but bccmodels.C did, so used the same one. 2) Files, like bootstrap.c, that exist in HV and have no header, I left unchanged because I have no idea where this file came from and it has an extension of lower case "c" instead of upper case "C". 3) Any file in Cinelerra-HV that did not have the Copyright/Name/Year, I did not change in CinGG, so that it would match.
If Andrew has time to verify and thinks something should have been done differently, please let me know.
Well, in HV I see guicast files under GPL-2 OR later, not lgpl. There is some difference and I am not sure what is best. Can i fwd this message to Adam, may be he will add some licensing to HV git too? Also, because whole guicast was written by Adam I think adding him as line alongside Bill actually honest. https://github.com/heroineworshiper/hvirtual/blob/master/guicast/bcbar.C I yet to confirm (likely) source of initial ffmpeg.C - commit message says CV but I guess it was specific branch, not CV main. Also, as IgorV noticed because CinGG merged code from CV too it will be honest if we add line like "Cinelerra CV contributors, 2003-2016" ( I think this is range when CV project was most active - but I need to doublecheck.) to our startup message and increment cingg year to 2022 at least because we still alive ! https://github.com/Akir4d/cinelerra-ak/commit/d6b64e543e8fcc185fc260a352e0a4... says fileffmpeg loader based on HV - 4.1 but heavily modified. Also, did you linked google code repo to our webpage already?
Well, in HV I see guicast files under GPL-2 OR later, not lgpl. There is some difference and I am not sure what is best.
Not sure what you mean? The GPL message I added says "either version 2 ... or ... later" -- does not GPL-2 mean version 2? Can i fwd this message to Adam, may be he will add some licensing to HV git
too?
Also, because whole guicast was written by Adam I think adding him as line
alongside Bill actually honest.
OK, no problem. I was wondering about that, but saw that Monty did not do that for Blue Banana and there were other examples too. For example, Monty has: /* * Cinelerra :: Blue Banana - color modification plugin for Cinelerra-CV * Copyright (C) 2012-2013 Monty <[email protected]> * * This program is free software;
https://github.com/heroineworshiper/hvirtual/blob/master/guicast/bcbar.C
I yet to confirm (likely) source of initial ffmpeg.C - commit message says CV but I guess it was specific branch, not CV main.
I think that ffmpeg.C was added by Bill but it was probably derived from somewhere in FFmpeg code.
Also, as IgorV noticed because CinGG merged code from CV too it will be honest if we add line like "Cinelerra CV contributors, 2003-2016" ( I think this is range when CV project was most active - but I need to doublecheck.) to our startup message and increment cingg year to 2022 at least because we still alive !
OK, no problem, but I think that Adam will object to that.
https://github.com/Akir4d/cinelerra-ak/commit/d6b64e543e8fcc185fc260a352e0a4...
says fileffmpeg loader based on HV - 4.1 but heavily modified.
Also, did you linked google code repo to our webpage already?
No, I thought google code repo was no longer supported? -- at least that is a message I thought Google put out? What is the URL? I do not want to confuse CinGG with all of the rest of the other Cinelerra type repos out there -- there are 10's of them and maybe even hundreds. IMPORTANT -- I am NOT changing any currently existing GPL messages because there are literally thousands of them. I am only adding messages when I see they are missing altogether. For example in Guicast, I only added messages to the 19 files that had none -- there are 219 files in that directory and that is the smallest one needed to be done. I have done more than just these 19 but if the message is wrong then I have to do all of them over again. Please provide the message you think I should add instead. Or correct the one below that I have added both Adam and CV to for when I have to add a missing attribution even though neither have that program file in existence in their directories. For anything that I have to add a message to that is in HV-8, I just have added whatever Adam had. /* * CINELERRA ** Copyright (C) 2023 Adam Williams <broadcast at earthling dot net>* ** Copyright (C) 2003-2016 Cinelerra CV contributors* * Copyright (C) 2020 William Morrow * * This program is free software; you can redistribute it and/or modify it * under the terms of the GNU Lesser General Public License as published * by the Free Software Foundation; either version 2 of the License, or * (at your option) any later version. * * This program is distributed in the hope that it will be useful, but * WITHOUT ANY WARRANTY; without even the implied warranty of * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the GNU * Lesser General Public License for more details. * * You should have received a copy of the GNU Lesser General Public * License along with this library; if not, write to the Free Software * Foundation, Inc., 59 Temple Place, Suite 330, Boston, MA 02111-1307 * USA */
чт, 5 янв. 2023 г., 05:24 Phyllis Smith <[email protected]>:
Well, in HV I see guicast files under GPL-2 OR later, not lgpl. There is
some difference and I am not sure what is best.
Not sure what you mean? The GPL message I added says "either version 2 ... or ... later" -- does not GPL-2 mean version 2?
I mean LGPL is Library GPL a bit differently type of license from just GPL . https://www.gnu.org/licenses/why-not-lgpl.en.html "The GNU Project has two principal licenses to use for libraries. One is the GNU Lesser GPL; the other is the ordinary GNU GPL. The choice of license makes a big difference: using the Lesser GPL permits use of the library in proprietary programs; using the ordinary GPL for a library makes it available only for free programs." I think Adam hopes for wider use of guicast as GUI library, so files there (as of now) LGPL. Usually exact license text derived from moment code was imported. So look into cin hv 4.x tree, I guess?
Can i fwd this message to Adam, may be he will add some licensing to HV
git too?
Also, because whole guicast was written by Adam I think adding him as line
alongside Bill actually honest.
OK, no problem. I was wondering about that, but saw that Monty did not do that for Blue Banana and there were other examples too. For example, Monty has: /* * Cinelerra :: Blue Banana - color modification plugin for Cinelerra-CV * Copyright (C) 2012-2013 Monty <[email protected]> * * This program is free software;
I guess because this specific file was written by him alone, not based on HV code?
https://github.com/heroineworshiper/hvirtual/blob/master/guicast/bcbar.C
I yet to confirm (likely) source of initial ffmpeg.C - commit message says CV but I guess it was specific branch, not CV main.
I think that ffmpeg.C was added by Bill but it was probably derived from somewhere in FFmpeg code.
Also, as IgorV noticed because CinGG merged code from CV too it will be honest if we add line like "Cinelerra CV contributors, 2003-2016" ( I think this is range when CV project was most active - but I need to doublecheck.) to our startup message and increment cingg year to 2022 at least because we still alive !
OK, no problem, but I think that Adam will object to that.
well, merges from CV into GG (But not HV) documented in git history .... so I see no reason to complain - cingg says its own startup message, cin HV uses their own code and show their own message....
https://github.com/Akir4d/cinelerra-ak/commit/d6b64e543e8fcc185fc260a352e0a4...
says fileffmpeg loader based on HV - 4.1 but heavily modified.
Also, did you linked google code repo to our webpage already?
No, I thought google code repo was no longer supported? -- at least that is a message I thought Google put out? What is the URL?
see my next email about fileffmpeg.C investigation. Archive is not supported, but you still can download ~600 mb of git history from there unavailable anywhere else (in this sense google code archive is neutral third party) I do not want to confuse CinGG with all of the rest of the other Cinelerra
type repos out there -- there are 10's of them and maybe even hundreds.
IMPORTANT -- I am NOT changing any currently existing GPL messages because there are literally thousands of them. I am only adding messages when I see they are missing altogether. For example in Guicast, I only added messages to the 19 files that had none -- there are 219 files in that directory and that is the smallest one needed to be done.
I have done more than just these 19 but if the message is wrong then I have to do all of them over again. Please provide the message you think I should add instead.
Well, I think in general template message is correct, just we need pay attention when more than one author worked on it. You can look into ffmpeg's sources for some examples. Dates for (c) usually not exact, but at least year or range of years provided. Or correct the one below that I have added both Adam and CV to for when I
have to add a missing attribution even though neither have that program file in existence in their directories. For anything that I have to add a message to that is in HV-8, I just have added whatever Adam had. /* * CINELERRA ** Copyright (C) 2023 Adam Williams <broadcast at earthling dot net>* ** Copyright (C) 2003-2016 Cinelerra CV contributors* * Copyright (C) 2020 William Morrow * * This program is free software; you can redistribute it and/or modify it * under the terms of the GNU Lesser General Public License as published * by the Free Software Foundation; either version 2 of the License, or * (at your option) any later version. * * This program is distributed in the hope that it will be useful, but * WITHOUT ANY WARRANTY; without even the implied warranty of * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the GNU * Lesser General Public License for more details. * * You should have received a copy of the GNU Lesser General Public * License along with this library; if not, write to the Free Software * Foundation, Inc., 59 Temple Place, Suite 330, Boston, MA 02111-1307 * USA */
I don't know anything about License and GPL but I think that in Cinelerra-GG there is the About window where you can write all the Developers/Authors you want, without including them in every Cinelerra's file (.h, .C, .inc,...). IgorBeg
чт, 5 янв. 2023 г., 11:51 Igor BEGHETTO via Cin <[email protected]
:
I don't know anything about License and GPL but I think that in Cinelerra-GG there is the About window where you can write all the Developers/Authors you want, without including them in every Cinelerra's file (.h, .C, .inc,...).
for seeing this window you must have successful compile, and if compile was not successful you look into source files ( I think this might be part of rationale about putting them there ). Each source file usually worked on by some developers, so knowing who works (worked) on specific part is also important (when you have 1000+ files). Putting ALL program authors in EACH file obviously wrong, but making sure relevant names appear in files you get right after unpacking source considered good tone....
IgorBeg -- Cin mailing list [email protected] https://lists.cinelerra-gg.org/mailman/listinfo/cin
I don't know anything about License and GPL but I think that in
Cinelerra-GG there is the About window where you can write all the Developers/Authors you want, without including them in every Cinelerra's file (.h, .C, .inc,...).
for seeing this window you must have successful compile, and if compile was not successful you look into source files ( I think this might be part of rationale about putting them there ). Each source file usually worked on by some developers, so knowing who works (worked) on specific part is also important (when you have 1000+ files). Putting ALL program authors in EACH file obviously wrong, but making sure relevant names appear in files you get right after unpacking source considered good tone....
*Zero* occurrences of GPL statements in Cinelerra-CV of the type "Copyright...2016 Contributors-CV" -- no one took the time to bother about updating to include the CV Contributors. I think the Archived Mailing List was good enough and very thorough and still is. *Five* occurrences of individuals specifically including GPLs in code they wrote WITHOUT including Adam as author of directory as shown below: /* (cinelerra/yuvstream.C) * CINELERRA * Copyright (C) 2004 Nathan Kurz * * This program is free software; you can redistribute it and/or modify /* * Cinelerra :: Blue Banana - color modification plugin for Cinelerra-CV * Copyright (C) 2012-2013 Monty <[email protected]> * * This program is free software; you can redistribute it and/or modify /* * C41 plugin for Cinelerra * Copyright (C) 2011 Florent Delannoy <florent at plui dot es> * * This program is free software; you can redistribute it and/or modify /* * GreyCStoration plugin for Cinelerra * Copyright (C) 2013 Slock Ruddy * Copyright (C) 2014-2015 Nicola Ferralis <feranick at hotmail dot com> * * This program is free software; you can redistribute it and/or modify /* * CINELERRA * Copyright (C) 2007 Hermann Vosseler * * This program is free software; you can redistribute it and/or modify
чт, 5 янв. 2023 г., 23:19 Phyllis Smith <[email protected]>:
I don't know anything about License and GPL but I think that in
Cinelerra-GG there is the About window where you can write all the Developers/Authors you want, without including them in every Cinelerra's file (.h, .C, .inc,...).
for seeing this window you must have successful compile, and if compile was not successful you look into source files ( I think this might be part of rationale about putting them there ). Each source file usually worked on by some developers, so knowing who works (worked) on specific part is also important (when you have 1000+ files). Putting ALL program authors in EACH file obviously wrong, but making sure relevant names appear in files you get right after unpacking source considered good tone....
*Zero* occurrences of GPL statements in Cinelerra-CV of the type "Copyright...2016 Contributors-CV" -- no one took the time to bother about updating to include the CV Contributors. I think the Archived Mailing List was good enough and very thorough and still is. *Five* occurrences of individuals specifically including GPLs in code they wrote WITHOUT including Adam as author of directory as shown below:
you do authorship per-file, not per-directory.... this one was written in cin-cv tree .... /* (cinelerra/yuvstream.C)
* CINELERRA * Copyright (C) 2004 Nathan Kurz * * This program is free software; you can redistribute it and/or modify
/* * Cinelerra :: Blue Banana - color modification plugin for Cinelerra-CV * Copyright (C) 2012-2013 Monty <[email protected]> * * This program is free software; you can redistribute it and/or modify
/* * C41 plugin for Cinelerra * Copyright (C) 2011 Florent Delannoy <florent at plui dot es> * * This program is free software; you can redistribute it and/or modify
/* * GreyCStoration plugin for Cinelerra * Copyright (C) 2013 Slock Ruddy * Copyright (C) 2014-2015 Nicola Ferralis <feranick at hotmail dot com> * * This program is free software; you can redistribute it and/or modify
/* * CINELERRA * Copyright (C) 2007 Hermann Vosseler * * This program is free software; you can redistribute it and/or modify
Other Open Source programs use to put the name of the developers/authors in an AUTHORS file. I think it is more convenient than writing them to each individual file, NOW. If a developer will write a new Plugin He will write His name inside, I think. For example, take a look at Scribus https://github.com/scribusproject/scribus For the GPL license we have COPYING file https://git.cinelerra-gg.org/git/?p=goodguy/cinelerra.git;a=blob;f=cinelerra... IgorBeg Il 06/01/2023 01:07, Andrew Randrianasulu via Cin ha scritto:
чт, 5 янв. 2023 г., 23:19 Phyllis Smith <[email protected] <mailto:[email protected]>>:
I don't know anything about License and GPL but I think that in Cinelerra-GG there is the About window where you can write all the Developers/Authors you want, without including them in every Cinelerra's file (.h, .C, .inc,...).
for seeing this window you must have successful compile, and if compile was not successful you look into source files ( I think this might be part of rationale about putting them there ). Each source file usually worked on by some developers, so knowing who works (worked) on specific part is also important (when you have 1000+ files). Putting ALL program authors in EACH file obviously wrong, but making sure relevant names appear in files you get right after unpacking source considered good tone....
I feel similarly to IgorBeg. Without going into too much detail about Open licensing, so as not to drive Phyllis crazy making she to pursue rare data lost in the menadirs of time, I would just leave a general Authors window for all the code, without having to put them in every file header. For example, I would say that CinGG uses code from multiple versions of Cin and also from external programs. For code derived from CinHV I would put a link to the CinHV page; I would do the same for CinCV (maybe it is better to ask Igor Vladimirsky, on which page to link) and CinCVE (Einar). Instead, the original contributors to CinGG can be made explicit clearly in this same authors window. In any case, the most competent person to ask is definitely Igor Vladimirsky, especially for Cin HV; CV and CVE. Finally I would hear suggestions from the various contributors to CinGG, for the best method by which to be cited; whether in each headers of their code or in general without going into detail.
пт, 6 янв. 2023 г., 17:37 Andrea paz via Cin <[email protected]>:
I feel similarly to IgorBeg. Without going into too much detail about Open licensing, so as not to drive Phyllis crazy making she to pursue rare data lost in the menadirs of time, I would just leave a general Authors window for all the code, without having to put them in every file header.
thing is, file WITHOUT such header probably can cause misunderstanding (at best) down the line .... (not to mention distant possibility of court action by some wanna-be Microsoft/Apple) so I think best course of action still fix most glaring omissions when possible, and then add details as we found them.
For example, I would say that CinGG uses code from multiple versions of Cin and also from external programs. For code derived from CinHV I would put a link to the CinHV page; I would do the same for CinCV (maybe it is better to ask Igor Vladimirsky, on which page to link) and CinCVE (Einar). Instead, the original contributors to CinGG can be made explicit clearly in this same authors window.
In any case, the most competent person to ask is definitely Igor Vladimirsky, especially for Cin HV; CV and CVE.
Finally I would hear suggestions from the various contributors to CinGG, for the best method by which to be cited; whether in each headers of their code or in general without going into detail. -- Cin mailing list [email protected] https://lists.cinelerra-gg.org/mailman/listinfo/cin
I feel similarly to IgorBeg. Without going into too much detail about
Open licensing, so as not to drive Phyllis crazy making she to pursue rare data lost in the menadirs of time, I would just leave a general Authors window for all the code, without having to put them in every file header.
thing is, file WITHOUT such header probably can cause misunderstanding (at best) down the line .... (not to mention distant possibility of court action by some wanna-be Microsoft/Apple)
so I think best course of action still fix most glaring omissions when possible, and then add details as we found them.
It is really good to get various opinions and is most helpful. I will make an effort to gradually add headers where missing based on what information Andrew/I can find. How about AUTHORS in the manual and then link to look there (so easy to do with HTML reference? Then we can say "mea culpa" for missing people, incorrect information like email addresses, and include credit for Testers, Manual Writing, YouTube videos contributions, and so on -- this could be more thorough, and hopefully would not make anyone feel bad.
I mean LGPL is Library GPL a bit differently type of license from just GPL .
Andrew: Fixed and checked into GIT the corrections. I had just grabbed one GPL header and did not read it. So now "library" replaced by "program" and "Lesser" now gone. (I should be more careful).
Well, I think in general template message is correct, just we need pay attention when more than one author worked on it. You can look into ffmpeg's sources for some examples. Dates for (c) usually not exact, but at least year or range of years provided.
Also, corrected the dates as best as I could. Next I want to add the "Contributors CV" line but I have not yet found the "merge" tar of around March 21, 2016 where CV, HV, and 5.0 were merged that was made for Beta testing of 5.1 and submitted (AND REJECTED) to Cinelerra-CV. But I have not looked very hard yet other than in the email here. I need this in order to determine the exact files that were used from CV. Question? did you come up with a good date for CV contributors? Or should I use 2007-2016?
сб, 7 янв. 2023 г., 03:02 Phyllis Smith <[email protected]>:
I mean LGPL is Library GPL a bit differently type of license from just GPL
.
Andrew: Fixed and checked into GIT the corrections. I had just grabbed one GPL header and did not read it. So now "library" replaced by "program" and "Lesser" now gone. (I should be more careful).
Well, I think in general template message is correct, just we need pay attention when more than one author worked on it. You can look into ffmpeg's sources for some examples. Dates for (c) usually not exact, but at least year or range of years provided.
Also, corrected the dates as best as I could. Next I want to add the "Contributors CV" line but I have not yet found the "merge" tar of around March 21, 2016 where CV, HV, and 5.0 were merged that was made for Beta testing of 5.1 and submitted (AND REJECTED) to Cinelerra-CV. But I have not looked very hard yet other than in the email here. I need this in order to determine the exact files that were used from CV. Question? did you come up with a good date for CV contributors? Or should I use 2007-2016?
Cinelerra CV was active as project since early 2003 (cinelerra 1.1.* days!) first in cvs, then in svn, then in git. Try to download full history via git clone https://github.com/cinelerra-cv-team/cinelerra-cv git log in it, and then press "end" on keyboard. you will see lines like r2, r9, r11 - those are ancient CVS revisions. Now, one can wonder how much of this work survived into 2016? Files were merged with HV (and sometimes back) but for example autoconf-based build system was developed there and quite distinct from script HV uses. So, _as a team_ I think their contributions still alive even if it be quite hard to find exact lines from that time in current code. Yet, translations were merged there, manual in 2007 too. I wonder if manual a bit distinct and in our case heavy for referring from source code tree? I mean, files like AUTHORS put in root of source tree exactly because they more likely to read this way. Originally (if you check r2 by copying its git hash as argument to 'git checkout -b r2 hash') you will see AUTHORS was empty and was filled up lately commit 19c569148c0c2742a9dabb42ee281bf498eee291 Author: Johannes Sixt <[email protected]> Date: Tue Jan 23 21:34:33 2007 +0000 r985: Fill in the AUTHORS file with useful information. This file is used by a svn to git converter; hence, it must have this particular syntax, which maps svn committer logins to names and emails. On the other hand, since this file lists only the svn logins, it is by no means a complete list of authors. Many people have contributed, but are not mentioned here. If you think you deserve attribution in this list, it will be no problem to add your name, too (with some fake login name). ===== I think we do not plan to downgrade to SVN so our file might be simpler in organization. Just authors, contact. (contact is email or website) please also try to git log in unpacked google code archive, it provides some info on merges before attempted beta release ( I'll look up email archive at date you found)
On Sat, Jan 7, 2023 at 5:48 AM Andrew Randrianasulu <[email protected]> wrote:
сб, 7 янв. 2023 г., 03:02 Phyllis Smith <[email protected]>:
I mean LGPL is Library GPL a bit differently type of license from just GPL .
Andrew: Fixed and checked into GIT the corrections. I had just grabbed one GPL header and did not read it. So now "library" replaced by "program" and "Lesser" now gone. (I should be more careful).
Well, I think in general template message is correct, just we need pay attention when more than one author worked on it. You can look into ffmpeg's sources for some examples. Dates for (c) usually not exact, but at least year or range of years provided.
Also, corrected the dates as best as I could. Next I want to add the "Contributors CV" line but I have not yet found the "merge" tar of around March 21, 2016 where CV, HV, and 5.0 were merged that was made for Beta testing of 5.1 and submitted (AND REJECTED) to Cinelerra-CV. But I have not looked very hard yet other than in the email here. I need this in order to determine the exact files that were used from CV. Question? did you come up with a good date for CV contributors? Or should I use 2007-2016?
Cinelerra CV was active as project since early 2003 (cinelerra 1.1.* days!) first in cvs, then in svn, then in git.
Try to download full history via git clone
https://github.com/cinelerra-cv-team/cinelerra-cv
git log in it, and then press "end" on keyboard. you will see lines like r2, r9, r11 - those are ancient CVS revisions.
Now, one can wonder how much of this work survived into 2016? Files were merged with HV (and sometimes back) but for example autoconf-based build system was developed there and quite distinct from script HV uses. So, _as a team_ I think their contributions still alive even if it be quite hard to find exact lines from that time in current code. Yet, translations were merged there, manual in 2007 too.
I wonder if manual a bit distinct and in our case heavy for referring from source code tree? I mean, files like AUTHORS put in root of source tree exactly because they more likely to read this way.
Originally (if you check r2 by copying its git hash as argument to 'git checkout -b r2 hash') you will see AUTHORS was empty and was filled up lately
commit 19c569148c0c2742a9dabb42ee281bf498eee291 Author: Johannes Sixt <[email protected]> Date: Tue Jan 23 21:34:33 2007 +0000
r985: Fill in the AUTHORS file with useful information.
This file is used by a svn to git converter; hence, it must have this particular syntax, which maps svn committer logins to names and emails.
On the other hand, since this file lists only the svn logins, it is by no means a complete list of authors. Many people have contributed, but are not mentioned here. If you think you deserve attribution in this list, it will be no problem to add your name, too (with some fake login name).
===== I think we do not plan to downgrade to SVN so our file might be simpler in organization. Just authors, contact. (contact is email or website)
please also try to git log in unpacked google code archive, it provides some info on merges before attempted beta release ( I'll look up email archive at date you found)
There is link to email archived posting https://lists.cinelerra-cv.org/pipermail/cinelerra/2016q1/004236.html ====== original message ==== Cinelerra 5.0 now is BETA “Cinelerra 5.1” with these changes: Merged in Operators and Methods from Adam's HV version AND Merged in User Interface Characteristics from CV WHERE POSSIBLE. Tarballs are in directory Danny set up -including a ubuntu 32-bit version: (at this time, not sure if it is beneficial to clear out .bcast5 first) https://cinelerra-cv.org/five Attempted to make the behavior of 5.1 as close to what is expected in the stable CV version, but sometimes there were conflicts and a decision had to be made to go the way CV code went or the way the HV code went. It can be changed if an incorrect decision was made. Partial listing of which CV/HV characteristics are now in and operational: Apply Masks before plugins Last Play position memory (new feature) Free movement of fragments Now there is 4 Selectable Keyframes on curve types (superset CV&HV) Label Anchor support Lock labels from moving Free Drag of Plugins (new feature) Zoom Bar enhancements Label Folder support Asset Interlace support code (not sure how to test though) Label Info Edit support XML tag closer present A toggle full selection Off as well as On (new feature) Manual GoTo support Reel Number / Timecode Support Auto interpolation methods are now superset of CV and HV Export EDL support Fade-to-black via the fade histogram (render follows the compositor) Images can be extended by dragging each edge of clip (with default duration) Length of a transition is now displayed visually on the track. Curve zoom can be set independently for different automation ranges Allow for manually setting the min/max levels via typing for curve zoom Shortcut to move tracks down and up via shift+down or shift+up Dragging an effect “onto” a clip now shows the clip existing on the track for the length of that clip (was for length of entire track previously) Ability to choose to render the whole project, selected area or in/out points (was render from the current cursor point) Also, many bug fixes and code improvements that have gone into the Stable CV version over many years, from many great developers are now in. And found some new problems that got fixed. Tested what I knew how to but NEEDS MORE TESTING because it sure helps to have multiple people and real users who know how to take advantage of all of the modifications that the Stable CV version has in it. === end of quotation === it seems archive.org never archived this directory (https://cinelerra-cv.org/five) but there is pdf attachment I can open directly in Firefox 102 ESR ======= 5.0/5.1 – A Brief History of Time(line) / GoodGuy perspective Explanation of how the name/version ended up as Cin 5.0 and now being referred to as Cinelerra 5.1: Good Guy first found the Cinelerra program several years ago when he needed software to make a copy of a DVD that was purchased for his own viewing that was going bad. He then discovered that it could be used to record TV for later viewing. He enhanced Cinelerra for both of these purposes being very careful to preserve the original Adam Williams' integrity so that a mod could be stitched back into Adam's version if desired. Originally it was referred to as Cinelerra 4.6- mod since 4.6 was the current version on the Heroine Virtual website. He continued fixing bugs as they were discovered and making mods for his own usage for a few years. During this time he added more features to TV watching and recording with great emphasis on deleting commercials so he wouldn't have to watch them or even press the mute button. Obnoxious, proliferate medical drug ads were being played over and over again so he added his “novel architecture” shared memory database, a Traveling Data Base (TDB). With TDB you have direct access to the shared database presence (instead of having to go to the server). The TDB was used to contain the commercials so that the next time watching TV when a matching ad came up, it would automatically be visually and audibly muted. However, after awhile it became apparent that it would take multiple people putting entries into the database to keep it up to date as the commercials, although monotonously being rerun, would vary a little so it no longer matched one already in the database. (If you want to become “insanely rich”, people would pay you to either remove the commercial while watching live or would pay you to not remove the commercials$$) Sometime in 2015 while looking around the web, he was surprised to see what looked like the removal of Adam Williams' name from the list of names of developers. Thus, he assumed Adam was no longer going to be working on Cinelerra. For the second time, he contacted Adam in hopes of getting the 4.6-mod set into Adam's base, but was informed via email that he considered these mods to be “just another branch” as quoted from an email: From: Adam williams [email protected] ... “There have been hundreds of refactorings; thousands of patches submitted over the last 20 years. Most of them don't get in my branch because they're never finished, don't work, or I don't have any use for them personally. It's a good idea to maintain your own branch. “ Also, at about this time the CV website seemed to be in a little bit of a lull. That is why Good Guy started freely working on the cinelerra.org site (rather than the CV site) with no longer being concerned about retaining the look and feel of the original code since his mods would never be stitched into the actual Cinelerra codebase. 4.6-mod was later re-versioned to 5.0 because so much had changed with inclusion of the latest ffmpeg software which allowed for full frame 4K editing and replacement of the badly performing quicktime code. Also, the icons had been changed, blu-ray added, lots of bug fixes, and very many improvements such as vicons,TV recording/editing, and TDB. Again, this version number was picked assuming that Adam was no longer doing development or making any major changes that would warrant a renumbering. After about a year, it was becoming increasingly difficult to work with the cinelerra.org site so had to look for another option. Upon joining the Community Version CV cinelerra-cv.org site, it was Good Guy's intention to merge in all of the great CV versions' features and eventually get to a more stable version. That is what I have now had time to complete. There is still hope that eventually everyone can get together for a common goal ======= I think last line still relevant and we better not to allow past drama distract us from reaching such goal.
Checked into GIT the first set of 50 files with additional GPL copyright message for CV-Contributors 2003-2016. It is taking longer than I expected but I want to get it as correct as possible - probably another 150 to go.
Now, one can wonder how much of this work survived into 2016? Files were merged with HV (and sometimes back) but for example autoconf-based build system was developed there and quite distinct from script HV uses. So, _as a team_ *I think their contributions still alive even if it be quite hard to find exact lines from that time in current code. *
Yes, their contributions are still alive and if I had to guess, at least 95%+ are but I did find a few that were not. and probably missed a very few. By comparing "before" and "after" of the last Cinelerra 5.0 to the first beta “Cinelerra 5.1” I was able to somewhat detect when CV changes were added (as opposed to HV changes which already have a GPL attribution) and these files are the ones that had the CV-Contributors attribute added. I am being as thorough as I can be so as not to miss any but will never be 100% sure. Many of the 1 or 2 line changes are "interlace" related or an "include" file while some of the other one line changes are bug fixes -- these are the hardest to find and the most important to have. And, of course, the other most important changes are the new features added by the CV contributors.
...
please also try to git log in unpacked google code archive, it provides some info on merges before attempted beta release ( I'll look up email archive at date you found)
There is link to email archived posting
https://lists.cinelerra-cv.org/pipermail/cinelerra/2016q1/004236.html
====== original message ====
Cinelerra 5.0 now is BETA “Cinelerra 5.1” with these changes:
Merged in Operators and Methods from Adam's HV version AND Merged in User Interface Characteristics from CV WHERE POSSIBLE. ... Attempted to make the behavior of 5.1 as close to what is expected in the stable CV version, but sometimes there were conflicts and a decision had to be made to go the way CV code went or the way the HV code went. It can be changed if an incorrect decision was made.
*Partial listing of which CV/HV characteristics are now in and operational:*
Apply Masks before plugins Last Play position memory (new feature) Free movement of fragments Now there is 4 Selectable Keyframes on curve types (superset CV&HV) Label Anchor support Lock labels from moving Free Drag of Plugins (new feature) Zoom Bar enhancements Label Folder support Asset Interlace support code (not sure how to test though) Label Info Edit support XML tag closer present A toggle full selection Off as well as On (new feature) Manual GoTo support Reel Number / Timecode Support Auto interpolation methods are now superset of CV and HV Export EDL support Fade-to-black via the fade histogram (render follows the compositor) Images can be extended by dragging each edge of clip (with default duration) Length of a transition is now displayed visually on the track. Curve zoom can be set independently for different automation ranges Allow for manually setting the min/max levels via typing for curve zoom Shortcut to move tracks down and up via shift+down or shift+up Dragging an effect “onto” a clip now shows the clip existing on the track for the length of that clip (was for length of entire track previously) Ability to choose to render the whole project, selected area or in/out points (was render from the current cursor point)
*Also, many bug fixes and code improvements that have gone into the Stable CV version over many years, from many great developers are now in. And found some new problems that got fixed.*
A great work, Phyllis! For me, (all of) you are crazy to insert ALL the developers/contributors/authors, searching them time ago. I am sorry if I think so. IgorBeg Il 22/01/2023 00:40, Phyllis Smith via Cin ha scritto:
Checked into GIT the first set of 50 files with additional GPL copyright message for CV-Contributors 2003-2016. It is taking longer than I expected but I want to get it as correct as possible - probably another 150 to go.
Despite differing opinions, I have added GPL headers to any program.C, header.h, and include,inc files where missing to the best of my ability with attribution when clear to do so. It should be at least 90% correct in the guicast, cinelerra, and individual plugins/themes directories. Not sure it is of much value, seeing as how there aren't many comments and so many of the programmers are no longer around, but the intent is good. With the addition of the "Authors and Contributors" to the manual at the end of last month, hopefully little history will be lost. As always, we can correct any mistakes. for seeing this window you must have successful compile, and if compile was
not successful you look into source files ( I think this might be part of rationale about putting them there ). Each source file usually worked on by some developers, so knowing who works (worked) on specific part is also important (when you have 1000+ files). Putting ALL program authors in EACH file obviously wrong, but making sure relevant names appear in files you get right after unpacking source considered good tone....
Caveats: 1) Some files just had generic "Cinelerra/Adam" attributes added/modified since he is the real author and did not know who else to add, or other person did not care to have their name added too. This was the case for many files that William Morrow worked on in the optimistic hope that the original author would pick up the changes in the future. 2) Confusion on the Cuda plugins and LV2 program's authorship is kind of messy so I just tried to match between the .C, .h, and .inc files where some attribution currently existed. 3) Even if the only CV change added to GG version was "ifdef HAVE_FIREWIRE" and a matching "endif", I still added the "Copyright (C) 2003-2016 Cinelerra CV contributors" line after Adam's copyright line because it took some work to discover the need for the addition. TASK COMPLETE unless notified otherwise. ...Phyllis
Monumental! ср, 15 февр. 2023 г., 05:30 Phyllis Smith <[email protected]>:
Despite differing opinions, I have added GPL headers to any program.C, header.h, and include,inc files where missing to the best of my ability with attribution when clear to do so. It should be at least 90% correct in the guicast, cinelerra, and individual plugins/themes directories. Not sure it is of much value, seeing as how there aren't many comments and so many of the programmers are no longer around, but the intent is good. With the addition of the "Authors and Contributors" to the manual at the end of last month, hopefully little history will be lost. As always, we can correct any mistakes.
for seeing this window you must have successful compile, and if compile
was not successful you look into source files ( I think this might be part of rationale about putting them there ). Each source file usually worked on by some developers, so knowing who works (worked) on specific part is also important (when you have 1000+ files). Putting ALL program authors in EACH file obviously wrong, but making sure relevant names appear in files you get right after unpacking source considered good tone....
Caveats: 1) Some files just had generic "Cinelerra/Adam" attributes added/modified since he is the real author and did not know who else to add, or other person did not care to have their name added too. This was the case for many files that William Morrow worked on in the optimistic hope that the original author would pick up the changes in the future.
Note, you absolutely can few copyright lines in one file if many authors worked on it, so having Adam and William co-exist as authors should be totally ok. see for example head of thirdparty/ffmpeg-5.1/libavcodec/hevcdec.c 2) Confusion on the Cuda plugins and LV2 program's authorship is kind of
messy so I just tried to match between the .C, .h, and .inc files where some attribution currently existed. 3) Even if the only CV change added to GG version was "ifdef HAVE_FIREWIRE" and a matching "endif", I still added the "Copyright (C) 2003-2016 Cinelerra CV contributors" line after Adam's copyright line because it took some work to discover the need for the addition.
TASK COMPLETE unless notified otherwise. ...Phyllis
participants (4)
-
Andrea paz -
Andrew Randrianasulu -
Igor BEGHETTO -
Phyllis Smith