ср, 27 июл. 2022 г., 11:20 Andrea paz <[email protected]>:

I tried compiling the latest git (Tue, 26 jul 2022), manually adding Andrew's latest patches (only the ones in this post, not the previous ones) in .../thirdparty/src/. I have no compilation errors. During ./autogen.sh I got these messages:

libtoolize: Consider adding 'AC_CONFIG_MACRO_DIRS([m4])' to configure.ac, libtoolize: and rerunning libtoolize and aclocal.

I did the addition and ran the two commands without getting any errors. Then I continued the compilation. CinGG is working, but I don't think it is using ffmpeg5. For example, the new filters in ffmpeg5/5.1 did not appear. Did I do something wrong? How can you see if ffmpeg5 is being used?

Try to make profile for new QOI image format for example and see if it works? You not forgot to add ffmpeg 5.1 tarball in thirdparty src? Also, I disabled many new filters in plugin.opts because they were not working for me. But may be they just need initial parameters set ....

ср, 27 июл. 2022 г., 21:06 Andrea paz <[email protected]>:

I had not put the tarball in. I repeated everything but now I have a crash. I attach the cin5.log. Maybe the tarball of ffmpeg4.4 and related patches should be removed?

Yeah,it seems so (because it tries to reuse ffmpeg-4.4 patches. patch -d ffmpeg* -p1 < src/ffmpeg-4.4.patch0 Be sure to check configure.ac for correct ffmpeg version!

ср, 27 июл. 2022 г., 23:41 Andrea paz <[email protected]>:

In configure.ac there is the line:

PKG_3RD([ffmpeg],[yes], [ffmpeg-4.4],

I retried the compilation by removing ffmpeg4.4 and all its patches; editing configure.ac by adding the line:

AC_CONFIG_MACRO_DIRS([m4])

And changing the one entry with ffmpeg-4.4 to ffmpeg-5.1. Still crashing.

But at least how it simply can't find directory/files to patch .... You re-run ./autogen.sh after editing configure.ac and it finished ok? Is there unpacked ffmpeg-5.1 source now in thirdparty?

Oh, sorry! It seems you put binary ffmpeg snapshot! Try to search for ffmpeg-5.1.tar.xz and check it actually source tarball.... чт, 28 июл. 2022 г., 00:11 Andrea paz <[email protected]>:

...

You re-run ./autogen.sh after editing configure.ac and it finished ok? Yes, I had already done that Is there unpacked ffmpeg-5.1 source now in thirdparty? Yes, tarball unpacked

As usual the mistake was mine that I had the wrong ffmpeg tarball; with the one you indicated the compilation happens without errors and CinGG uses ffmpeg-5.1. I remember the steps I took: - configure.ac i) added the line "AC_CONFIG_MACRO_DIRS([m4])" otherwise ./autogen.sh gives a warning suggesting correction. ii) changed the one entry containing [ffmpeg-4.4] to [ffmpeg-5.1]. - From /src delete all the patches of ffmpeg-4.4 and its tarball and put the patches of ffmpeg-5.1 and its tarball. In this way the build is done without errors and CinGG works well. @ Phyllis I attach the files "plugin.opts" and "plugins.txt" with the updates of the new plugins. As usual thank you Andrew and sorry again for my continuous errors.

Thank you, problem-free build and smooth editing.

сб, 20 авг. 2022 г., 21:24 Phyllis Smith <[email protected]>:

Good News ! FFmpeg 5.1 now checked into GIT and the end of the month release will include it. *The patches were provided by Andrew and plugin modifications provided by Andrea. * Without the patches provided by Andrew, this upgrade would have been impossible. Verification of the build/compile was done on Fedora, Ubuntu 16 and Debian 9.1 32-bit. I had to revert to using the Bluray original Patch2 with line number updates and a couple of additions in order to actually create Bluray media to play on the Samsung UHD and LG bluray players connected to the TV.

Oh, thanks for doing hard part. I guess we still need to carry this specific patch forward ..... Can you explain a bit more on failures you saw with other patch version?

There may be some undiscovered issues with FFmpeg 5.1 and the patches because I do not know what bug they actually are meant to fix and how to effectively test them.

Attached is a short Patch summary which would only be of interest to programmers.

On Tue, Jul 26, 2022 at 1:45 PM Andrew Randrianasulu < [email protected]> wrote:

...

I think I located new source file with libavformat seek functions, so now we have more complete set of patches, while I can't be sure if those seeking changes still necessary....

For some reason sending patches as attachments failed, so this time I send them as archive

Andrea, thanks for the updated Manual ffmpeg 5.1 plugin description. I added them to GIT yesterday. Did any of them need to be added to expanders.txt in the main cinelerra-5.1 directory? I was going to add F_colormatrix and F_colorspectrum to color correction but they are not really for color correction? Here is the new list: New Audio plugins included are: F_adecorrelate, F_adynamicequalizer, F_adynamicsmooth, F_afwtdn, F_alatency, F_apsyclip, F_aspectralstats, F_atilt, F_tiltshelf, F_virtualbass New Video plugins include are: F_blockdetect, F_blurdetect, F_chromakey_cuda, F_colorchart, F_colorspectrum, F_grayworld, F_hsvhold, F_hsvkey, F_latency, F_pixelize, F_scharr, F_sitiNew Audio plugins included are: F_adecorrelate, F_adynamicequalizer, F_adynamicsmooth, F_afwtdn, F_alatency, F_apsyclip, F_aspectralstats, F_atilt, F_tiltshelf, F_virtualbass New Video plugins include are: F_blockdetect, F_blurdetect, F_chromakey_cuda, F_colorchart, F_colorspectrum, F_grayworld, F_hsvhold, F_hsvkey, F_latency, F_pixelize, F_scharr, F_siti On Sun, Aug 21, 2022 at 1:59 AM Andrea paz <[email protected]> wrote:

@Phyllis Smith I append the new plugins.tex

пн, 22 авг. 2022 г., 03:24 Phyllis Smith <[email protected]>:

Andrew:

...

.... Can you explain a bit more on failures you saw with other patch version?

About the "newer" patch2 version that I could not get working, here is what I saw.

1. Applied the new patch2 version as you provided and inside of Cinelerra I get the Error Message box which reads: "Error rendering data" right when I use the File pulldown, choose BD render option, and then hit the "start" button in the bluray menu that comes up. In the window where I started Cinelerra, I see the following: [MPEGTS muxer @ 0x7ff864050100] Value -1.000000 for parameter 'sdt_period' out of range [0 - 9.22337e+12] [MPEGTS muxer @ 0x7ff864050100] Error setting option *sdt_period *to value -1. FFMPEG::encode_activate: write header failed /tmp/bd_20220821-115350/bd.m2ts err: Numerical result out of range

2. As you had suggested, I then tried to apply the part of the current ffmpeg-4.4.patch2 that related to *sdt_period *but did not know enough about C++ to intelligently apply this part only and that failed. I tried a few different variations to no avail so basically gave up but will see if there is anything else I can try. (Kind of like I tried all kinds of weird things for several weeks just to get OpenExr upgrade by Manuel to work with --without-openexr to no avail).

I actually suggested to modify bluray profile (even just before rendering) so it no longer contain "sdt_period= -1" .... $ grep sdt bin/ffmpeg/format/* bin/ffmpeg/format/bluray:sdt_period=-1 from locally-installed cingg source/bin tree ...

BTW, verified that "lpcm" option in Bluray media creation seemed to work. Did not test tsmuxer or chapters yet. Was "truehd" applied to ffmpeg 5.1 too and should I try that again as I never could get that patch provided at 4.4 to work?

I think ffmpeg's truehd encoder still limited to mono or stereo, no 5.1 or up ...and muxing probably still require one more step with ac3 fallback track interleaved with truehd track with thdmerge (separate program) help before muxing externally with tsmuxer ..so, plenty of manual steps to get just experimental stereo disk if we are lucky ...you still can try of course just out of curiosity