[PATCH] UnsafeGUI toggle, tooltips, file overwrite warning for batchrender.c
This time I tried to add user confirmation on project (EDL) file overwrite, _in addition_ to gui toggle hiding this button. Rafa Mar, I saw your letter, just tracking _where exactly_ this function writes file() turned out to be harder than just adding warning. For now.
Changes to Batch Render menu have been checked into GIT. Lots of review/testing/decision making going on. So basically this is the compromise solution (which can be changed if necessary, but I really think it is probably the best option). 1) new users or new .bcast5 will automatically never see the "warn on mismatch" and "save edl" 2) existing users, if they are seeing these 2 warnings, will have to go into Settings->Preferences, Appearance tab and uncheck DANGEROUS batch render gui, in order to stop seeing these 2 warnings. Just one time and also be sure to use Settings pulldown to "save settings now". 3) anyone who wants to have these features available for use, has to get into Settings and check/enable Dangerous flag to see the 2 boxes. Tooltips added for several additional boxes helps to explain usage a little better in Batch Render menu and some Preferences flags. Code checked in mostly by Andrew with slight modifications for compromise and wording changes. On Sat, Jan 16, 2021 at 12:19 AM Andrew Randrianasulu via Cin < [email protected]> wrote:
This time I tried to add user confirmation on project (EDL) file overwrite, _in addition_ to gui toggle hiding this button.
Rafa Mar, I saw your letter, just tracking _where exactly_ this function writes file() turned out to be harder than just adding warning. For now. -- Cin mailing list [email protected] https://lists.cinelerra-gg.org/mailman/listinfo/cin
I'm going to download, compile and test to see how these changes work. I really like the option of multiple backup copies that Reuss András has made and his response of trying to make an option that creates some backup copies together with the EDL El lun, 18 ene 2021 a las 7:15, Phyllis Smith via Cin (< [email protected]>) escribió:
Changes to Batch Render menu have been checked into GIT. Lots of review/testing/decision making going on. So basically this is the compromise solution (which can be changed if necessary, but I really think it is probably the best option).
1) new users or new .bcast5 will automatically never see the "warn on mismatch" and "save edl" 2) existing users, if they are seeing these 2 warnings, will have to go into Settings->Preferences, Appearance tab and uncheck DANGEROUS batch render gui, in order to stop seeing these 2 warnings. Just one time and also be sure to use Settings pulldown to "save settings now". 3) anyone who wants to have these features available for use, has to get into Settings and check/enable Dangerous flag to see the 2 boxes.
Tooltips added for several additional boxes helps to explain usage a little better in Batch Render menu and some Preferences flags.
Code checked in mostly by Andrew with slight modifications for compromise and wording changes.
On Sat, Jan 16, 2021 at 12:19 AM Andrew Randrianasulu via Cin < [email protected]> wrote:
This time I tried to add user confirmation on project (EDL) file overwrite, _in addition_ to gui toggle hiding this button.
Rafa Mar, I saw your letter, just tracking _where exactly_ this function writes file() turned out to be harder than just adding warning. For now. -- Cin mailing list [email protected] https://lists.cinelerra-gg.org/mailman/listinfo/cin
-- Cin mailing list [email protected] https://lists.cinelerra-gg.org/mailman/listinfo/cin
[image: imagen.png] This will be what new users will find, the error that some have already reported as a bug. I have completely deleted Cinelerra, I have done an installation from the last git, I have deleted the .bcast5 folder, I have started Cinelerra and tried to do a batch render. Precisely for this reason my friend stressed that it was important that this option was disabled by default, it was only to change a 1 to a 0. If I remember correctly ... What happens that now I do not remember where this change was and I am afraid to continue abusing my friendship with him because he is a very busy person with work and family. My honest opinion. I still think we're giving new users a bad impression of Cinelerra by keeping a few options in a batch rendering window that only very few users currently use. Some options that do not make any sense in a window of this type, something that has always been done with a save as, which is an option that does not require any Dangerous flag. Another option would be to leave the window as it was before all this matter, make the option "warn if it does not match ..." is disabled by default and the dangerous button what it does is a copy of the current file loaded in the EDL path adding a number to this new copy of the xml, and automatically reflect this change in the EDL path. In this way everything remains the same as before, the Dangerous flag is not necessary and the wizard stops being dangerous and automatically makes the "save as" and stops being a dangerous option for new users and this mode is satisfied. work for former users who made use of this feature. And most importantly, no one is going to lose their job due to a wrong click. I don't want to think about how the faces of these lovers of danger with their strange and dangerous way of working, if they press this option without having remembered to manually change the name in the EDL route. El lun, 18 ene 2021 a las 11:28, Rafa Mar Multimedia en Gnu\Linux (< [email protected]>) escribió:
I'm going to download, compile and test to see how these changes work. I really like the option of multiple backup copies that Reuss András has made and his response of trying to make an option that creates some backup copies together with the EDL
El lun, 18 ene 2021 a las 7:15, Phyllis Smith via Cin (< [email protected]>) escribió:
Changes to Batch Render menu have been checked into GIT. Lots of review/testing/decision making going on. So basically this is the compromise solution (which can be changed if necessary, but I really think it is probably the best option).
1) new users or new .bcast5 will automatically never see the "warn on mismatch" and "save edl" 2) existing users, if they are seeing these 2 warnings, will have to go into Settings->Preferences, Appearance tab and uncheck DANGEROUS batch render gui, in order to stop seeing these 2 warnings. Just one time and also be sure to use Settings pulldown to "save settings now". 3) anyone who wants to have these features available for use, has to get into Settings and check/enable Dangerous flag to see the 2 boxes.
Tooltips added for several additional boxes helps to explain usage a little better in Batch Render menu and some Preferences flags.
Code checked in mostly by Andrew with slight modifications for compromise and wording changes.
On Sat, Jan 16, 2021 at 12:19 AM Andrew Randrianasulu via Cin < [email protected]> wrote:
This time I tried to add user confirmation on project (EDL) file overwrite, _in addition_ to gui toggle hiding this button.
Rafa Mar, I saw your letter, just tracking _where exactly_ this function writes file() turned out to be harder than just adding warning. For now. -- Cin mailing list [email protected] https://lists.cinelerra-gg.org/mailman/listinfo/cin
-- Cin mailing list [email protected] https://lists.cinelerra-gg.org/mailman/listinfo/cin
I sent the new batchrender.C file to my friend to tell me where to change this number and he answered this, saying that you would understand. diff PATH/cinelerra/batchrender.C @@ 200 - warn = 1; + warn = 0; I have gone to line 200 of the file and I have changed it, recompiled and now it no longer gives the aforementioned error. With this small change, the assistant is working perfectly from its first use. El lun, 18 ene 2021 a las 13:03, Rafa Mar Multimedia en Gnu\Linux (< [email protected]>) escribió:
[image: imagen.png] This will be what new users will find, the error that some have already reported as a bug.
I have completely deleted Cinelerra, I have done an installation from the last git, I have deleted the .bcast5 folder, I have started Cinelerra and tried to do a batch render.
Precisely for this reason my friend stressed that it was important that this option was disabled by default, it was only to change a 1 to a 0. If I remember correctly ...
What happens that now I do not remember where this change was and I am afraid to continue abusing my friendship with him because he is a very busy person with work and family.
My honest opinion. I still think we're giving new users a bad impression of Cinelerra by keeping a few options in a batch rendering window that only very few users currently use. Some options that do not make any sense in a window of this type, something that has always been done with a save as, which is an option that does not require any Dangerous flag.
Another option would be to leave the window as it was before all this matter, make the option "warn if it does not match ..." is disabled by default and the dangerous button what it does is a copy of the current file loaded in the EDL path adding a number to this new copy of the xml, and automatically reflect this change in the EDL path. In this way everything remains the same as before, the Dangerous flag is not necessary and the wizard stops being dangerous and automatically makes the "save as" and stops being a dangerous option for new users and this mode is satisfied. work for former users who made use of this feature. And most importantly, no one is going to lose their job due to a wrong click. I don't want to think about how the faces of these lovers of danger with their strange and dangerous way of working, if they press this option without having remembered to manually change the name in the EDL route.
El lun, 18 ene 2021 a las 11:28, Rafa Mar Multimedia en Gnu\Linux (< [email protected]>) escribió:
I'm going to download, compile and test to see how these changes work. I really like the option of multiple backup copies that Reuss András has made and his response of trying to make an option that creates some backup copies together with the EDL
El lun, 18 ene 2021 a las 7:15, Phyllis Smith via Cin (< [email protected]>) escribió:
Changes to Batch Render menu have been checked into GIT. Lots of review/testing/decision making going on. So basically this is the compromise solution (which can be changed if necessary, but I really think it is probably the best option).
1) new users or new .bcast5 will automatically never see the "warn on mismatch" and "save edl" 2) existing users, if they are seeing these 2 warnings, will have to go into Settings->Preferences, Appearance tab and uncheck DANGEROUS batch render gui, in order to stop seeing these 2 warnings. Just one time and also be sure to use Settings pulldown to "save settings now". 3) anyone who wants to have these features available for use, has to get into Settings and check/enable Dangerous flag to see the 2 boxes.
Tooltips added for several additional boxes helps to explain usage a little better in Batch Render menu and some Preferences flags.
Code checked in mostly by Andrew with slight modifications for compromise and wording changes.
On Sat, Jan 16, 2021 at 12:19 AM Andrew Randrianasulu via Cin < [email protected]> wrote:
This time I tried to add user confirmation on project (EDL) file overwrite, _in addition_ to gui toggle hiding this button.
Rafa Mar, I saw your letter, just tracking _where exactly_ this function writes file() turned out to be harder than just adding warning. For now. -- Cin mailing list [email protected] https://lists.cinelerra-gg.org/mailman/listinfo/cin
-- Cin mailing list [email protected] https://lists.cinelerra-gg.org/mailman/listinfo/cin
В сообщении от Monday 18 January 2021 15:28:44 Rafa Mar Multimedia en Gnu\Linux via Cin написал(а):
I sent the new batchrender.C file to my friend to tell me where to change this number and he answered this, saying that you would understand.
diff PATH/cinelerra/batchrender.C @@ 200 - warn = 1; + warn = 0;
I have gone to line 200 of the file and I have changed it, recompiled and now it no longer gives the aforementioned error.
With this small change, the assistant is working perfectly from its first use.
\0/ Cool! My programmer friend talked with me today on phone, and I tried to explain some .... unique aspects of Cinelerra(s). We come to conclusion I better to research code base more accurately - there MIGHT be function for storing user data in those listboxes and menu items ..... But so far I haven't looked hard enough!
El lun, 18 ene 2021 a las 13:03, Rafa Mar Multimedia en Gnu\Linux (< [email protected]>) escribió:
[image: imagen.png] This will be what new users will find, the error that some have already reported as a bug.
I have completely deleted Cinelerra, I have done an installation from the last git, I have deleted the .bcast5 folder, I have started Cinelerra and tried to do a batch render.
Precisely for this reason my friend stressed that it was important that this option was disabled by default, it was only to change a 1 to a 0. If I remember correctly ...
What happens that now I do not remember where this change was and I am afraid to continue abusing my friendship with him because he is a very busy person with work and family.
My honest opinion. I still think we're giving new users a bad impression of Cinelerra by keeping a few options in a batch rendering window that only very few users currently use. Some options that do not make any sense in a window of this type, something that has always been done with a save as, which is an option that does not require any Dangerous flag.
Another option would be to leave the window as it was before all this matter, make the option "warn if it does not match ..." is disabled by default and the dangerous button what it does is a copy of the current file loaded in the EDL path adding a number to this new copy of the xml, and automatically reflect this change in the EDL path. In this way everything remains the same as before, the Dangerous flag is not necessary and the wizard stops being dangerous and automatically makes the "save as" and stops being a dangerous option for new users and this mode is satisfied. work for former users who made use of this feature. And most importantly, no one is going to lose their job due to a wrong click. I don't want to think about how the faces of these lovers of danger with their strange and dangerous way of working, if they press this option without having remembered to manually change the name in the EDL route.
El lun, 18 ene 2021 a las 11:28, Rafa Mar Multimedia en Gnu\Linux (< [email protected]>) escribió:
I'm going to download, compile and test to see how these changes work. I really like the option of multiple backup copies that Reuss András has made and his response of trying to make an option that creates some backup copies together with the EDL
El lun, 18 ene 2021 a las 7:15, Phyllis Smith via Cin (< [email protected]>) escribió:
Changes to Batch Render menu have been checked into GIT. Lots of review/testing/decision making going on. So basically this is the compromise solution (which can be changed if necessary, but I really think it is probably the best option).
1) new users or new .bcast5 will automatically never see the "warn on mismatch" and "save edl" 2) existing users, if they are seeing these 2 warnings, will have to go into Settings->Preferences, Appearance tab and uncheck DANGEROUS batch render gui, in order to stop seeing these 2 warnings. Just one time and also be sure to use Settings pulldown to "save settings now". 3) anyone who wants to have these features available for use, has to get into Settings and check/enable Dangerous flag to see the 2 boxes.
Tooltips added for several additional boxes helps to explain usage a little better in Batch Render menu and some Preferences flags.
Code checked in mostly by Andrew with slight modifications for compromise and wording changes.
On Sat, Jan 16, 2021 at 12:19 AM Andrew Randrianasulu via Cin < [email protected]> wrote:
This time I tried to add user confirmation on project (EDL) file overwrite, _in addition_ to gui toggle hiding this button.
Rafa Mar, I saw your letter, just tracking _where exactly_ this function writes file() turned out to be harder than just adding warning. For now. -- Cin mailing list [email protected] https://lists.cinelerra-gg.org/mailman/listinfo/cin
-- Cin mailing list [email protected] https://lists.cinelerra-gg.org/mailman/listinfo/cin
Sorry, my friend has rechecked the file and recommends these two changes to avoid the well-known error. diff PATH / cinelerra / batchrender.C @@ 200 - warn = 1; + warn = 0; @@ 272 - warn = file.tag.get_property ("WARN", 1); + warn = file.tag.get_property ("WARN", 0); In this way, the wizard will always start for a new user with this option deactivated. If you activate the option from the preferences, when you open the wizard this option will remain deactivated, but if you activate it, Cinelerra will remember this at the next start. I have tried it and it works perfect. El lun, 18 ene 2021 a las 13:28, Rafa Mar Multimedia en Gnu\Linux (< [email protected]>) escribió:
I sent the new batchrender.C file to my friend to tell me where to change this number and he answered this, saying that you would understand.
diff PATH/cinelerra/batchrender.C @@ 200 - warn = 1; + warn = 0;
I have gone to line 200 of the file and I have changed it, recompiled and now it no longer gives the aforementioned error.
With this small change, the assistant is working perfectly from its first use.
El lun, 18 ene 2021 a las 13:03, Rafa Mar Multimedia en Gnu\Linux (< [email protected]>) escribió:
[image: imagen.png] This will be what new users will find, the error that some have already reported as a bug.
I have completely deleted Cinelerra, I have done an installation from the last git, I have deleted the .bcast5 folder, I have started Cinelerra and tried to do a batch render.
Precisely for this reason my friend stressed that it was important that this option was disabled by default, it was only to change a 1 to a 0. If I remember correctly ...
What happens that now I do not remember where this change was and I am afraid to continue abusing my friendship with him because he is a very busy person with work and family.
My honest opinion. I still think we're giving new users a bad impression of Cinelerra by keeping a few options in a batch rendering window that only very few users currently use. Some options that do not make any sense in a window of this type, something that has always been done with a save as, which is an option that does not require any Dangerous flag.
Another option would be to leave the window as it was before all this matter, make the option "warn if it does not match ..." is disabled by default and the dangerous button what it does is a copy of the current file loaded in the EDL path adding a number to this new copy of the xml, and automatically reflect this change in the EDL path. In this way everything remains the same as before, the Dangerous flag is not necessary and the wizard stops being dangerous and automatically makes the "save as" and stops being a dangerous option for new users and this mode is satisfied. work for former users who made use of this feature. And most importantly, no one is going to lose their job due to a wrong click. I don't want to think about how the faces of these lovers of danger with their strange and dangerous way of working, if they press this option without having remembered to manually change the name in the EDL route.
El lun, 18 ene 2021 a las 11:28, Rafa Mar Multimedia en Gnu\Linux (< [email protected]>) escribió:
I'm going to download, compile and test to see how these changes work. I really like the option of multiple backup copies that Reuss András has made and his response of trying to make an option that creates some backup copies together with the EDL
El lun, 18 ene 2021 a las 7:15, Phyllis Smith via Cin (< [email protected]>) escribió:
Changes to Batch Render menu have been checked into GIT. Lots of review/testing/decision making going on. So basically this is the compromise solution (which can be changed if necessary, but I really think it is probably the best option).
1) new users or new .bcast5 will automatically never see the "warn on mismatch" and "save edl" 2) existing users, if they are seeing these 2 warnings, will have to go into Settings->Preferences, Appearance tab and uncheck DANGEROUS batch render gui, in order to stop seeing these 2 warnings. Just one time and also be sure to use Settings pulldown to "save settings now". 3) anyone who wants to have these features available for use, has to get into Settings and check/enable Dangerous flag to see the 2 boxes.
Tooltips added for several additional boxes helps to explain usage a little better in Batch Render menu and some Preferences flags.
Code checked in mostly by Andrew with slight modifications for compromise and wording changes.
On Sat, Jan 16, 2021 at 12:19 AM Andrew Randrianasulu via Cin < [email protected]> wrote:
This time I tried to add user confirmation on project (EDL) file overwrite, _in addition_ to gui toggle hiding this button.
Rafa Mar, I saw your letter, just tracking _where exactly_ this function writes file() turned out to be harder than just adding warning. For now. -- Cin mailing list [email protected] https://lists.cinelerra-gg.org/mailman/listinfo/cin
-- Cin mailing list [email protected] https://lists.cinelerra-gg.org/mailman/listinfo/cin
Sorry Andrew, I did not test the warning, but I have tried these simple changes indicated above, I have completely uninstalled Cinelerra again, compiled with these changes, and now it works perfectly from the first time. It is as simple as setting these 1s to 0 and the problem is solved and we can end this matter. I really liked the warning window not to overwrite and the tooltip with the warning. Congratulations Andrew, great job. When the Cinelerra update is carried out, I will do a tutorial on batchrender and I will quote you in the thanks because your good work deserves it. We now have an ideal window for new users and much more secure for veterans. El lun, 18 ene 2021 a las 15:06, Rafa Mar Multimedia en Gnu\Linux (< [email protected]>) escribió:
Sorry, my friend has rechecked the file and recommends these two changes to avoid the well-known error. diff PATH / cinelerra / batchrender.C @@ 200 - warn = 1; + warn = 0; @@ 272 - warn = file.tag.get_property ("WARN", 1); + warn = file.tag.get_property ("WARN", 0);
In this way, the wizard will always start for a new user with this option deactivated. If you activate the option from the preferences, when you open the wizard this option will remain deactivated, but if you activate it, Cinelerra will remember this at the next start.
I have tried it and it works perfect.
El lun, 18 ene 2021 a las 13:28, Rafa Mar Multimedia en Gnu\Linux (< [email protected]>) escribió:
I sent the new batchrender.C file to my friend to tell me where to change this number and he answered this, saying that you would understand.
diff PATH/cinelerra/batchrender.C @@ 200 - warn = 1; + warn = 0;
I have gone to line 200 of the file and I have changed it, recompiled and now it no longer gives the aforementioned error.
With this small change, the assistant is working perfectly from its first use.
El lun, 18 ene 2021 a las 13:03, Rafa Mar Multimedia en Gnu\Linux (< [email protected]>) escribió:
[image: imagen.png] This will be what new users will find, the error that some have already reported as a bug.
I have completely deleted Cinelerra, I have done an installation from the last git, I have deleted the .bcast5 folder, I have started Cinelerra and tried to do a batch render.
Precisely for this reason my friend stressed that it was important that this option was disabled by default, it was only to change a 1 to a 0. If I remember correctly ...
What happens that now I do not remember where this change was and I am afraid to continue abusing my friendship with him because he is a very busy person with work and family.
My honest opinion. I still think we're giving new users a bad impression of Cinelerra by keeping a few options in a batch rendering window that only very few users currently use. Some options that do not make any sense in a window of this type, something that has always been done with a save as, which is an option that does not require any Dangerous flag.
Another option would be to leave the window as it was before all this matter, make the option "warn if it does not match ..." is disabled by default and the dangerous button what it does is a copy of the current file loaded in the EDL path adding a number to this new copy of the xml, and automatically reflect this change in the EDL path. In this way everything remains the same as before, the Dangerous flag is not necessary and the wizard stops being dangerous and automatically makes the "save as" and stops being a dangerous option for new users and this mode is satisfied. work for former users who made use of this feature. And most importantly, no one is going to lose their job due to a wrong click. I don't want to think about how the faces of these lovers of danger with their strange and dangerous way of working, if they press this option without having remembered to manually change the name in the EDL route.
El lun, 18 ene 2021 a las 11:28, Rafa Mar Multimedia en Gnu\Linux (< [email protected]>) escribió:
I'm going to download, compile and test to see how these changes work. I really like the option of multiple backup copies that Reuss András has made and his response of trying to make an option that creates some backup copies together with the EDL
El lun, 18 ene 2021 a las 7:15, Phyllis Smith via Cin (< [email protected]>) escribió:
Changes to Batch Render menu have been checked into GIT. Lots of review/testing/decision making going on. So basically this is the compromise solution (which can be changed if necessary, but I really think it is probably the best option).
1) new users or new .bcast5 will automatically never see the "warn on mismatch" and "save edl" 2) existing users, if they are seeing these 2 warnings, will have to go into Settings->Preferences, Appearance tab and uncheck DANGEROUS batch render gui, in order to stop seeing these 2 warnings. Just one time and also be sure to use Settings pulldown to "save settings now". 3) anyone who wants to have these features available for use, has to get into Settings and check/enable Dangerous flag to see the 2 boxes.
Tooltips added for several additional boxes helps to explain usage a little better in Batch Render menu and some Preferences flags.
Code checked in mostly by Andrew with slight modifications for compromise and wording changes.
On Sat, Jan 16, 2021 at 12:19 AM Andrew Randrianasulu via Cin < [email protected]> wrote:
This time I tried to add user confirmation on project (EDL) file overwrite, _in addition_ to gui toggle hiding this button.
Rafa Mar, I saw your letter, just tracking _where exactly_ this function writes file() turned out to be harder than just adding warning. For now. -- Cin mailing list [email protected] https://lists.cinelerra-gg.org/mailman/listinfo/cin
-- Cin mailing list [email protected] https://lists.cinelerra-gg.org/mailman/listinfo/cin
Sorry to report that the batch render wizard is not working as expected. Today I have made several videos of various conferences with Cinelerra GG and I have tried to export the result from the BatchRender window. The result has been: 1. The render does not work from the terminal --------------------- ** segv at 0x55da7ccd646f in pid 27025, tid 27025 writing debug data to /tmp/cinelerra_batch27025.dmp lock_items: 0 lock_frees: 1 Segment violation (`core' generated) ---------------------------- I do not attach the generated file because it is empty. 2. With Cinlerra open it seems to work but it does not export the video from beginning to end. After analyzing what happens, it turns out that the render is made from where the playback cursor was left the last time it was saved. I should never have tried this assistant ... I throw in the towel, I think the best thing is to leave it as it was before all this dizziness, all because of me, I assume it, and that everyone abides by the consequences if they lose a job or not . I prefer not to use this tool again because it is poorly conceived from the beginning. Never has batch processing given me such a headache. El lun, 18 ene 2021 a las 15:20, Rafa Mar Multimedia en Gnu\Linux (< [email protected]>) escribió:
Sorry Andrew, I did not test the warning, but I have tried these simple changes indicated above, I have completely uninstalled Cinelerra again, compiled with these changes, and now it works perfectly from the first time. It is as simple as setting these 1s to 0 and the problem is solved and we can end this matter.
I really liked the warning window not to overwrite and the tooltip with the warning.
Congratulations Andrew, great job. When the Cinelerra update is carried out, I will do a tutorial on batchrender and I will quote you in the thanks because your good work deserves it. We now have an ideal window for new users and much more secure for veterans.
El lun, 18 ene 2021 a las 15:06, Rafa Mar Multimedia en Gnu\Linux (< [email protected]>) escribió:
Sorry, my friend has rechecked the file and recommends these two changes to avoid the well-known error. diff PATH / cinelerra / batchrender.C @@ 200 - warn = 1; + warn = 0; @@ 272 - warn = file.tag.get_property ("WARN", 1); + warn = file.tag.get_property ("WARN", 0);
In this way, the wizard will always start for a new user with this option deactivated. If you activate the option from the preferences, when you open the wizard this option will remain deactivated, but if you activate it, Cinelerra will remember this at the next start.
I have tried it and it works perfect.
El lun, 18 ene 2021 a las 13:28, Rafa Mar Multimedia en Gnu\Linux (< [email protected]>) escribió:
I sent the new batchrender.C file to my friend to tell me where to change this number and he answered this, saying that you would understand.
diff PATH/cinelerra/batchrender.C @@ 200 - warn = 1; + warn = 0;
I have gone to line 200 of the file and I have changed it, recompiled and now it no longer gives the aforementioned error.
With this small change, the assistant is working perfectly from its first use.
El lun, 18 ene 2021 a las 13:03, Rafa Mar Multimedia en Gnu\Linux (< [email protected]>) escribió:
[image: imagen.png] This will be what new users will find, the error that some have already reported as a bug.
I have completely deleted Cinelerra, I have done an installation from the last git, I have deleted the .bcast5 folder, I have started Cinelerra and tried to do a batch render.
Precisely for this reason my friend stressed that it was important that this option was disabled by default, it was only to change a 1 to a 0. If I remember correctly ...
What happens that now I do not remember where this change was and I am afraid to continue abusing my friendship with him because he is a very busy person with work and family.
My honest opinion. I still think we're giving new users a bad impression of Cinelerra by keeping a few options in a batch rendering window that only very few users currently use. Some options that do not make any sense in a window of this type, something that has always been done with a save as, which is an option that does not require any Dangerous flag.
Another option would be to leave the window as it was before all this matter, make the option "warn if it does not match ..." is disabled by default and the dangerous button what it does is a copy of the current file loaded in the EDL path adding a number to this new copy of the xml, and automatically reflect this change in the EDL path. In this way everything remains the same as before, the Dangerous flag is not necessary and the wizard stops being dangerous and automatically makes the "save as" and stops being a dangerous option for new users and this mode is satisfied. work for former users who made use of this feature. And most importantly, no one is going to lose their job due to a wrong click. I don't want to think about how the faces of these lovers of danger with their strange and dangerous way of working, if they press this option without having remembered to manually change the name in the EDL route.
El lun, 18 ene 2021 a las 11:28, Rafa Mar Multimedia en Gnu\Linux (< [email protected]>) escribió:
I'm going to download, compile and test to see how these changes work. I really like the option of multiple backup copies that Reuss András has made and his response of trying to make an option that creates some backup copies together with the EDL
El lun, 18 ene 2021 a las 7:15, Phyllis Smith via Cin (< [email protected]>) escribió:
Changes to Batch Render menu have been checked into GIT. Lots of review/testing/decision making going on. So basically this is the compromise solution (which can be changed if necessary, but I really think it is probably the best option).
1) new users or new .bcast5 will automatically never see the "warn on mismatch" and "save edl" 2) existing users, if they are seeing these 2 warnings, will have to go into Settings->Preferences, Appearance tab and uncheck DANGEROUS batch render gui, in order to stop seeing these 2 warnings. Just one time and also be sure to use Settings pulldown to "save settings now". 3) anyone who wants to have these features available for use, has to get into Settings and check/enable Dangerous flag to see the 2 boxes.
Tooltips added for several additional boxes helps to explain usage a little better in Batch Render menu and some Preferences flags.
Code checked in mostly by Andrew with slight modifications for compromise and wording changes.
On Sat, Jan 16, 2021 at 12:19 AM Andrew Randrianasulu via Cin < [email protected]> wrote:
> This time I tried to add user confirmation on project (EDL) file > overwrite, > _in addition_ to gui toggle hiding this button. > > Rafa Mar, I saw your letter, just tracking _where exactly_ this > function writes file() turned out > to be harder than just adding warning. For now. > -- > Cin mailing list > [email protected] > https://lists.cinelerra-gg.org/mailman/listinfo/cin > -- Cin mailing list [email protected] https://lists.cinelerra-gg.org/mailman/listinfo/cin
RafaMar: Batch Rendering was designed as an advanced feature to be flexible for users when *computers were slow* by today's standard. Original HV manual states:
Set up a project and define the region to be rendered either by highlighting it, setting in/out points around it, or positioning the insertion point before it. Then save the project as an EDL
Current manual states:
You do not have to render an entire project. We can limit ourselves to an active region that we can set through a selection in Cut and Paste mode, with labels or In/Out Points. Or the rendering will start from the Insert Point position until the end of the project.
*Remember: if we want to render the entire project (and notjust one active region) it is important to bring the Insertion Point to the beginningof the timeline. This is the only way we are sure to include the whole project.*
And now you know why "Save to EDL path" option is there !!! because when you saved your project, the insertion pointer was not at the beginning !! On Mon, Jan 18, 2021 at 12:31 PM Rafa Mar Multimedia en Gnu\Linux via Cin < [email protected]> wrote:
Sorry to report that the batch render wizard is not working as expected.
Today I have made several videos of various conferences with Cinelerra GG and I have tried to export the result from the BatchRender window. The result has been: 1. The render does not work from the terminal --------------------- ** segv at 0x55da7ccd646f in pid 27025, tid 27025 writing debug data to /tmp/cinelerra_batch27025.dmp lock_items: 0 lock_frees: 1 Segment violation (`core' generated) ---------------------------- I do not attach the generated file because it is empty.
2. With Cinlerra open it seems to work but it does not export the video from beginning to end. After analyzing what happens, it turns out that the render is made from where the playback cursor was left the last time it was saved.
I should never have tried this assistant ... I throw in the towel, I think the best thing is to leave it as it was before all this dizziness, all because of me, I assume it, and that everyone abides by the consequences if they lose a job or not . I prefer not to use this tool again because it is poorly conceived from the beginning. Never has batch processing given me such a headache.
El lun, 18 ene 2021 a las 15:20, Rafa Mar Multimedia en Gnu\Linux (< [email protected]>) escribió:
Sorry Andrew, I did not test the warning, but I have tried these simple changes indicated above, I have completely uninstalled Cinelerra again, compiled with these changes, and now it works perfectly from the first time. It is as simple as setting these 1s to 0 and the problem is solved and we can end this matter.
I really liked the warning window not to overwrite and the tooltip with the warning.
Congratulations Andrew, great job. When the Cinelerra update is carried out, I will do a tutorial on batchrender and I will quote you in the thanks because your good work deserves it. We now have an ideal window for new users and much more secure for veterans.
El lun, 18 ene 2021 a las 15:06, Rafa Mar Multimedia en Gnu\Linux (< [email protected]>) escribió:
Sorry, my friend has rechecked the file and recommends these two changes to avoid the well-known error. diff PATH / cinelerra / batchrender.C @@ 200 - warn = 1; + warn = 0; @@ 272 - warn = file.tag.get_property ("WARN", 1); + warn = file.tag.get_property ("WARN", 0);
In this way, the wizard will always start for a new user with this option deactivated. If you activate the option from the preferences, when you open the wizard this option will remain deactivated, but if you activate it, Cinelerra will remember this at the next start.
I have tried it and it works perfect.
El lun, 18 ene 2021 a las 13:28, Rafa Mar Multimedia en Gnu\Linux (< [email protected]>) escribió:
I sent the new batchrender.C file to my friend to tell me where to change this number and he answered this, saying that you would understand.
diff PATH/cinelerra/batchrender.C @@ 200 - warn = 1; + warn = 0;
I have gone to line 200 of the file and I have changed it, recompiled and now it no longer gives the aforementioned error.
With this small change, the assistant is working perfectly from its first use.
El lun, 18 ene 2021 a las 13:03, Rafa Mar Multimedia en Gnu\Linux (< [email protected]>) escribió:
[image: imagen.png] This will be what new users will find, the error that some have already reported as a bug.
I have completely deleted Cinelerra, I have done an installation from the last git, I have deleted the .bcast5 folder, I have started Cinelerra and tried to do a batch render.
Precisely for this reason my friend stressed that it was important that this option was disabled by default, it was only to change a 1 to a 0. If I remember correctly ...
What happens that now I do not remember where this change was and I am afraid to continue abusing my friendship with him because he is a very busy person with work and family.
My honest opinion. I still think we're giving new users a bad impression of Cinelerra by keeping a few options in a batch rendering window that only very few users currently use. Some options that do not make any sense in a window of this type, something that has always been done with a save as, which is an option that does not require any Dangerous flag.
Another option would be to leave the window as it was before all this matter, make the option "warn if it does not match ..." is disabled by default and the dangerous button what it does is a copy of the current file loaded in the EDL path adding a number to this new copy of the xml, and automatically reflect this change in the EDL path. In this way everything remains the same as before, the Dangerous flag is not necessary and the wizard stops being dangerous and automatically makes the "save as" and stops being a dangerous option for new users and this mode is satisfied. work for former users who made use of this feature. And most importantly, no one is going to lose their job due to a wrong click. I don't want to think about how the faces of these lovers of danger with their strange and dangerous way of working, if they press this option without having remembered to manually change the name in the EDL route.
El lun, 18 ene 2021 a las 11:28, Rafa Mar Multimedia en Gnu\Linux (< [email protected]>) escribió:
I'm going to download, compile and test to see how these changes work. I really like the option of multiple backup copies that Reuss András has made and his response of trying to make an option that creates some backup copies together with the EDL
El lun, 18 ene 2021 a las 7:15, Phyllis Smith via Cin (< [email protected]>) escribió:
> Changes to Batch Render menu have been checked into GIT. Lots of > review/testing/decision making going on. So basically this is the > compromise solution (which can be changed if necessary, but I really think > it is probably the best option). > > 1) new users or new .bcast5 will automatically never see the "warn > on mismatch" and "save edl" > 2) existing users, if they are seeing these 2 warnings, will have to > go into Settings->Preferences, Appearance tab and uncheck DANGEROUS batch > render gui, in order to stop seeing these 2 warnings. Just one time and > also be sure to use Settings pulldown to "save settings now". > 3) anyone who wants to have these features available for use, has to > get into Settings and check/enable Dangerous flag to see the 2 boxes. > > Tooltips added for several additional boxes helps to explain usage a > little better in Batch Render menu and some Preferences flags. > > Code checked in mostly by Andrew with slight modifications for > compromise and wording changes. > > > On Sat, Jan 16, 2021 at 12:19 AM Andrew Randrianasulu via Cin < > [email protected]> wrote: > >> This time I tried to add user confirmation on project (EDL) file >> overwrite, >> _in addition_ to gui toggle hiding this button. >> >> Rafa Mar, I saw your letter, just tracking _where exactly_ this >> function writes file() turned out >> to be harder than just adding warning. For now. >> -- >> Cin mailing list >> [email protected] >> https://lists.cinelerra-gg.org/mailman/listinfo/cin >> > -- > Cin mailing list > [email protected] > https://lists.cinelerra-gg.org/mailman/listinfo/cin > -- Cin mailing list [email protected] https://lists.cinelerra-gg.org/mailman/listinfo/cin
Also to me the rendering from the command line creates a dump (but the file is empty!). From inside CinGG everything is OK. CinGG batch rendering also offers the possibility to render only an active region of the project, so the position of the insertion point is important. Generally it should be placed at the start.
OK, I easily reproduced it and hope Andrew can help fix it. On Mon, Jan 18, 2021 at 1:09 PM Andrea paz via Cin < [email protected]> wrote:
Also to me the rendering from the command line creates a dump (but the file is empty!). From inside CinGG everything is OK.
CinGG batch rendering also offers the possibility to render only an active region of the project, so the position of the insertion point is important. Generally it should be placed at the start. -- Cin mailing list [email protected] https://lists.cinelerra-gg.org/mailman/listinfo/cin
В сообщении от Monday 18 January 2021 23:41:53 Phyllis Smith via Cin написал(а):
OK, I easily reproduced it and hope Andrew can help fix it.
On Mon, Jan 18, 2021 at 1:09 PM Andrea paz via Cin < [email protected]> wrote:
Also to me the rendering from the command line creates a dump (but the file is empty!). From inside CinGG everything is OK.
Probably I missed some 'is_gui' check .. :/ sorry, will try to debug 'soon' (may be in the morning)
CinGG batch rendering also offers the possibility to render only an active region of the project, so the position of the insertion point is important. Generally it should be placed at the start. -- Cin mailing list [email protected] https://lists.cinelerra-gg.org/mailman/listinfo/cin
В сообщении от Monday 18 January 2021 23:41:53 Phyllis Smith via Cin написал(а):
OK, I easily reproduced it and hope Andrew can help fix it.
On Mon, Jan 18, 2021 at 1:09 PM Andrea paz via Cin < [email protected]> wrote:
Also to me the rendering from the command line creates a dump (but the file is empty!). From inside CinGG everything is OK.
What about adding "mwindow &&" to those unsafe_gui checks (sorry I haven't updated my working git copy yet) in BatchRenderThread::load_jobs and void BatchRenderThread::save_jobs ?? with those checks added it works with pre-setup 1.xml and 2.xml: ../bin/cin -r Cinelerra Infinity - built: Jan 18 2021 18:09:51 git://git.cinelerra-gg.org/goodguy/cinelerra.git (c) 2006-2019 Heroine Virtual Ltd. by Adam Williams 2007-2020 mods for Cinelerra-GG by W.P.Morrow aka goodguy Cinelerra is free software, covered by the GNU General Public License, and you are welcome to change it and/or distribute copies of it under certain conditions. There is absolutely no warranty for Cinelerra. Render::run: /dev/shm/1.xml ff_aspect_ratio, 0.000000 ff_aspect_ratio, 0.000000 99% Расчётное время (ETA): 0:00:00 FFStream::encode_frame: encode failed. file: /dev/shm/2.mp4 err: Ресурс временно недоступен FFStream::flush failed :file:/dev/shm/2.mp4 err: Операция не позволена Render::render_single: Session finished. Render::run: done in 0:00:56 Render::run: /dev/shm/2.xml ff_aspect_ratio, 0.000000 ff_aspect_ratio, 0.000000 99% Расчётное время (ETA): 0:00:00 Render::render_single: Session finished. Render::run: done in 0:00:54 ** rendered 4036 frames in 111.637 secs, 36.153 fps Session time: 0:01:52 Cpu time: user: 0:06:20.207 sys: 0:00:02.454 --- iff --git a/cinelerra-5.1/cinelerra/batchrender.C b/cinelerra-5.1/cinelerra/batchrender.C index 6dcdbc62..996aa9da 100644 --- a/cinelerra-5.1/cinelerra/batchrender.C +++ b/cinelerra-5.1/cinelerra/batchrender.C @@ -60,6 +60,7 @@ #include "dvdcreate.h" #include "bdcreate.h" + int BatchRenderThread::column_widths[] = { 42, 42, 42, 222, 222, 150 }; const char *BatchRenderThread::column_titles[] = { N_("Enabled"), N_("Labeled"), N_("Farmed"), N_("Output"), N_("EDL"), N_("Elapsed") @@ -198,6 +199,7 @@ BatchRenderThread::BatchRenderThread(MWindow *mwindow) boot_defaults = 0; preferences = 0; warn = 1; + render = 0; batch_path[0] = 0; do_farmed = 0; @@ -268,7 +270,10 @@ void BatchRenderThread::load_jobs(char *path, Preferences *preferences) while( !result ) { if( !(result = file.read_tag()) ) { if( file.tag.title_is("JOBS") ) { + if (mwindow && mwindow->preferences->unsafe_gui) warn = file.tag.get_property("WARN", 1); + if (mwindow && !mwindow->preferences->unsafe_gui) + warn = 0; } else if( file.tag.title_is("JOB") ) { BatchRenderJob *job = new BatchRenderJob(preferences, 0,0); @@ -293,6 +298,7 @@ void BatchRenderThread::save_jobs(char *path) { FileXML file; file.tag.set_title("JOBS"); + if (mwindow && mwindow->preferences->unsafe_gui) file.tag.set_property("WARN", warn); file.append_tag(); file.append_newline(); @@ -382,11 +388,15 @@ void BatchRenderThread::use_current_edl() gui->edl_path_text->update(get_current_edl()); } + ====
CinGG batch rendering also offers the possibility to render only an active region of the project, so the position of the insertion point is important. Generally it should be placed at the start. -- Cin mailing list [email protected] https://lists.cinelerra-gg.org/mailman/listinfo/cin
Honestly, I still think that this window is badly conceived from the beginning, this has nothing to do with a batch Render, these are simple assistants that do not represent any danger to our work and that are totally reliable and easy to use, they are even capable of rename a video if the name we have given already exists, but the process does not stop or destroy anything. And of course, wherever the playhead is left, this does not affect the export of projects in the least. I am so sorry that I used this assistant and promoted all this waste of time. For me, Cinelerra does not currently have a Batch Render, because a batch render is something else. Sorry, I can help with other things, but I don't want to know anything about this wizard, if one day someone dares to make an assistant properly, without all these conditions of having to leave the cursor at the beginning, a button that can destroy the work ... etc ... then if I consider that Cinelerra has a Batch Render assistant. El lun, 18 ene 2021 a las 21:09, Andrea paz via Cin (< [email protected]>) escribió:
Also to me the rendering from the command line creates a dump (but the file is empty!). From inside CinGG everything is OK.
CinGG batch rendering also offers the possibility to render only an active region of the project, so the position of the insertion point is important. Generally it should be placed at the start. -- Cin mailing list [email protected] https://lists.cinelerra-gg.org/mailman/listinfo/cin
В сообщении от Monday 18 January 2021 23:53:47 Rafa Mar Multimedia en Gnu\Linux via Cin написал(а):
Honestly, I still think that this window is badly conceived from the beginning, this has nothing to do with a batch Render, these are simple assistants that do not represent any danger to our work and that are totally reliable and easy to use, they are even capable of rename a video if the name we have given already exists, but the process does not stop or destroy anything. And of course, wherever the playhead is left, this does not affect the export of projects in the least.
please do not be so quick in your rage ... I'm sorry for not testing '-r' from command line, this was my fault. Try patch batchrender.C file as I recommended (add 'mwindow &&' to those unsafe_gui conditionals - so it will not access non-existent stuff ...)
I am so sorry that I used this assistant and promoted all this waste of time. For me, Cinelerra does not currently have a Batch Render, because a batch render is something else.
Sorry, I can help with other things, but I don't want to know anything about this wizard, if one day someone dares to make an assistant properly, without all these conditions of having to leave the cursor at the beginning, a button that can destroy the work ... etc ... then if I consider that Cinelerra has a Batch Render assistant.
El lun, 18 ene 2021 a las 21:09, Andrea paz via Cin (< [email protected]>) escribió:
Also to me the rendering from the command line creates a dump (but the file is empty!). From inside CinGG everything is OK.
CinGG batch rendering also offers the possibility to render only an active region of the project, so the position of the insertion point is important. Generally it should be placed at the start. -- Cin mailing list [email protected] https://lists.cinelerra-gg.org/mailman/listinfo/cin
It is not anger, it is that I regret, days ago, having said what I thought of this assistant and having led to all this waste of time. It's not your fault, here the only culprit is me. Honestly, if I knew how to program I would apply a maxim from the audiovisual world, when something is wrong it is better to start from scratch than to waste time fixing it. And that's what I would do, start from 0 and make a batch render wizard much simpler, more intuitive and that works. As references I would look like Adobe does, or sonyVegas. Especially the latter. I really feel all this waste of time. El lun, 18 ene 2021 a las 22:21, Andrew Randrianasulu via Cin (< [email protected]>) escribió:
В сообщении от Monday 18 January 2021 23:53:47 Rafa Mar Multimedia en Gnu\Linux via Cin написал(а):
Honestly, I still think that this window is badly conceived from the beginning, this has nothing to do with a batch Render, these are simple assistants that do not represent any danger to our work and that are totally reliable and easy to use, they are even capable of rename a video if the name we have given already exists, but the process does not stop or destroy anything. And of course, wherever the playhead is left, this does not affect the export of projects in the least.
please do not be so quick in your rage ...
I'm sorry for not testing '-r' from command line, this was my fault. Try patch batchrender.C file as I recommended (add 'mwindow &&' to those unsafe_gui conditionals - so it will not access non-existent stuff ...)
I am so sorry that I used this assistant and promoted all this waste of time. For me, Cinelerra does not currently have a Batch Render, because a batch render is something else.
Sorry, I can help with other things, but I don't want to know anything about this wizard, if one day someone dares to make an assistant
properly,
without all these conditions of having to leave the cursor at the beginning, a button that can destroy the work ... etc ... then if I consider that Cinelerra has a Batch Render assistant.
El lun, 18 ene 2021 a las 21:09, Andrea paz via Cin (< [email protected]>) escribió:
Also to me the rendering from the command line creates a dump (but the file is empty!). From inside CinGG everything is OK.
CinGG batch rendering also offers the possibility to render only an active region of the project, so the position of the insertion point is important. Generally it should be placed at the start. -- Cin mailing list [email protected] https://lists.cinelerra-gg.org/mailman/listinfo/cin
-- Cin mailing list [email protected] https://lists.cinelerra-gg.org/mailman/listinfo/cin
** segv at 0x55da7ccd646f in pid 27025, tid 27025 writing debug data to /tmp/cinelerra_batch27025.dmp lock_items: 0 lock_frees: 1 Segment violation (`core' generated)
The above has to be analyzed though if it can be reproduced reliably. Were there changes in other than what came from GIT? Like transitions or additional backups?
В сообщении от Monday 18 January 2021 15:03:06 Rafa Mar Multimedia en Gnu\Linux via Cin написал(а):
[image: imagen.png] This will be what new users will find, the error that some have already reported as a bug.
I have completely deleted Cinelerra, I have done an installation from the last git, I have deleted the .bcast5 folder, I have started Cinelerra and tried to do a batch render.
But if you check 'do not show this warning again' - will CinGG obey you?
Precisely for this reason my friend stressed that it was important that this option was disabled by default, it was only to change a 1 to a 0. If I remember correctly ...
What happens that now I do not remember where this change was and I am afraid to continue abusing my friendship with him because he is a very busy person with work and family.
My honest opinion. I still think we're giving new users a bad impression of Cinelerra by keeping a few options in a batch rendering window that only very few users currently use. Some options that do not make any sense in a window of this type, something that has always been done with a save as, which is an option that does not require any Dangerous flag.
Another option would be to leave the window as it was before all this matter, make the option "warn if it does not match ..." is disabled by default and the dangerous button what it does is a copy of the current file loaded in the EDL path adding a number to this new copy of the xml, and automatically reflect this change in the EDL path. In this way everything remains the same as before, the Dangerous flag is not necessary and the wizard stops being dangerous and automatically makes the "save as" and stops being a dangerous option for new users and this mode is satisfied. work for former users who made use of this feature. And most importantly, no one is going to lose their job due to a wrong click.
Please check (with test project!) warning that should surface if you try to overwrite project file with unsafe option enabled ...? I see it in code and it was working for me, but independent confirmation is always good....
I don't want to think about how the faces of these lovers of danger with their strange and dangerous way of working, if they press this option without having remembered to manually change the name in the EDL route.
El lun, 18 ene 2021 a las 11:28, Rafa Mar Multimedia en Gnu\Linux (< [email protected]>) escribió:
I'm going to download, compile and test to see how these changes work. I really like the option of multiple backup copies that Reuss András has made and his response of trying to make an option that creates some backup copies together with the EDL
El lun, 18 ene 2021 a las 7:15, Phyllis Smith via Cin (< [email protected]>) escribió:
Changes to Batch Render menu have been checked into GIT. Lots of review/testing/decision making going on. So basically this is the compromise solution (which can be changed if necessary, but I really think it is probably the best option).
1) new users or new .bcast5 will automatically never see the "warn on mismatch" and "save edl" 2) existing users, if they are seeing these 2 warnings, will have to go into Settings->Preferences, Appearance tab and uncheck DANGEROUS batch render gui, in order to stop seeing these 2 warnings. Just one time and also be sure to use Settings pulldown to "save settings now". 3) anyone who wants to have these features available for use, has to get into Settings and check/enable Dangerous flag to see the 2 boxes.
Tooltips added for several additional boxes helps to explain usage a little better in Batch Render menu and some Preferences flags.
Code checked in mostly by Andrew with slight modifications for compromise and wording changes.
On Sat, Jan 16, 2021 at 12:19 AM Andrew Randrianasulu via Cin < [email protected]> wrote:
This time I tried to add user confirmation on project (EDL) file overwrite, _in addition_ to gui toggle hiding this button.
Rafa Mar, I saw your letter, just tracking _where exactly_ this function writes file() turned out to be harder than just adding warning. For now. -- Cin mailing list [email protected] https://lists.cinelerra-gg.org/mailman/listinfo/cin
-- Cin mailing list [email protected] https://lists.cinelerra-gg.org/mailman/listinfo/cin
participants (4)
-
Andrea paz -
Andrew Randrianasulu -
Phyllis Smith -
Rafa Mar Multimedia en Gnu\Linux