Mainly for GG (... but also for the others) I added a file compressed and an animated GIF (photomontage with the buttons) to show the layout or an idea of layout. In the compressed file You find: 1) the "6" buttons for Mask Linear and Smooth, for each theme. They are always the first version I have done with the blue line in smooth buttons (due at my time). Sorry Olaf, I did not find your SVG files in Cakewalk theme to derivate the new buttons from your original buttons, but the buttons I have done have the right colour. For the SUV theme You find the "3" buttons for the Scale features. Why are there six PNGs instead of five? And, as first version and testing, You find the Presets (7 btns) and Positions (2 btns) buttons for only SUV theme. I hope that these buttons work like Mask Linear/Smooth buttons: every button use 4 icons, with three common icons ("mask_button_dn.png", "mask_button_hi.png", "mask_button_up.png"). If You (GG) think different, let me know, please. Sorry Sam, I have changed again a few of them. After some test with SUV theme we (all) can decide, I think. @GG and @Olaf More, I noticed two things about Neophyte and Cakewalk themes: A) Neophyte theme >> neophyte.C - code line 361 ("reset_dn.png") inverted with line 362 ("reset_hi.png") It should be: /* ****************** */ new_button("reset.png", "reset_up.png", "reset_hi.png", "reset_dn.png", "reset_button"); /* ****************** */ The PNGs files in theme_neophyte/data/PNGs are right but they are an old version. You can find the new PNGs files for reset button, in the compressed file, with the others mask buttons. (If/When Olaf wants he can update with one of his version) B) Cakewalk theme >> cakewalk.C - code line 272 ("reset_dn.png") inverted with line 273 ("reset_hi.png") I think, the codes should be (for consistency with the others codes/themes) like in point A, and in theme_cakewalk/data/ the two PNGs files have to be renamed: you have to swap the two names "reset_dn.png" with "reset_hi.png". Thank you so much! I go to drink something. (too many buttons) ;-) IgorBeg (Cin version: "cinelerra-5.1-ub16-x86_64-static_20190711-testing")
Great job Igor! I like it! Thank you. Sam On 13.07.19 14:37, Igor BEGHETTO wrote:
Mainly for GG (… but also for the others)
I added a file compressed and an animated GIF (photomontage with the buttons) to show the layout or an idea of layout.
In the compressed file You find: 1) the “6” buttons for Mask Linear and Smooth, for each theme. They are always the first version I have done with the blue line in smooth buttons (due at my time). Sorry Olaf, I did not find your SVG files in Cakewalk theme to derivate the new buttons from your original buttons, but the buttons I have done have the right colour.
For the SUV theme You find the “3” buttons for the Scale features. Why are there six PNGs instead of five?
And, as first version and testing, You find the Presets (7 btns) and Positions (2 btns) buttons for only SUV theme. I hope that these buttons work like Mask Linear/Smooth buttons: every button use 4 icons, with three common icons (“mask_button_dn.png”, “mask_button_hi.png”, “mask_button_up.png”). If You (GG) think different, let me know, please. Sorry Sam, I have changed again a few of them. After some test with SUV theme we (all) can decide, I think.
@GG and @Olaf More, I noticed two things about Neophyte and Cakewalk themes: A) Neophyte theme >> neophyte.C - code line 361 (“reset_dn.png”) inverted with line 362 ("reset_hi.png") It should be: /* ****************** */ new_button("reset.png", "reset_up.png", "reset_hi.png", "reset_dn.png", "reset_button"); /* ****************** */ The PNGs files in theme_neophyte/data/PNGs are right but they are an old version. You can find the new PNGs files for reset button, in the compressed file, with the others mask buttons. (If/When Olaf wants he can update with one of his version)
B) Cakewalk theme >> cakewalk.C - code line 272 (“reset_dn.png”) inverted with line 273 ("reset_hi.png") I think, the codes should be (for consistency with the others codes/themes) like in point A, and in theme_cakewalk/data/ the two PNGs files have to be renamed: you have to swap the two names “reset_dn.png” with “reset_hi.png”.
Thank you so much! I go to drink something. (too many buttons) ;-)
IgorBeg (Cin version: “cinelerra-5.1-ub16-x86_64-static_20190711-testing”)
Thank you GG for the ub16 build you have done for me. Unfortunately the Scale mode buttons do not work anymore as designed. I have tested by myself, after 2 hours of Cin compiling on my poor computer, and it works right. I understand you have changed the background to use them in all the themes but it doesn't work. For me they have to work like checkbox button otherwise I have not the checkedHighlight function. Of course, if/when you restore the Scale buttons like I designed, then I will create the other Scale buttons for all the themes. Also, could you look at the the code in "neophyte.C" about reset button, please? Now the reset button doesn't work right. The right sequences should be: new_button("reset.png", "reset_up.png", "reset_hi.png", "reset_dn.png", "reset_button"); Thank you so much! PS: Thank you Sam!
Hi GG! About Scale buttons (x, y , xy), now I understand (after another two hours of Cin compiling on my "powerful" Notebook, sigh-sigh). You want to save me from some PNGs. Okay, good idea! And thank you. Then, 10 PNGs for each theme instead of 18 PNGs, and 3 common PNGs for all the themes. Very good, I think. I just finished the new Scale PNGs only for SUV theme. I added the compressed file. When/if you have time to try. Thanks! (And now ...pause) =) IgorBeg
@GG Thanks for the new Cin build (20190715). I saw you have done a lot of work, thanks. Sorry if yesterday I did not thank you about all the works you are doing but, among photomontages (PNGs, animated GIF) and new Cin build, I don't understand what is true (software) or false (photomontage). In Cin-20190715 build I see you changed the code for the reset button (Clear) in Neophyte and Cakewalk themes but in "plugins/theme_cakewalk/data/" is needed to swap the names of the two PNGs files: “reset_dn.png” and “reset_hi.png”. Finally, you are too fast, I need more time to create the buttons of all the themes: every theme has its own colours. @Olaf Sorry Olaf, I think you will have update your master files. I hope it is good for you too. @Sam About radio buttons and checkbox buttons in "Select", "Enable", "Presets shapes", "Position&Scale" I preferred the compacted version (the buttons closest one to each other), but with right alignment. Thank you so much! IgorBeg
@IgorBeg
@Sam About radio buttons and checkbox buttons in "Select", "Enable", "Presets shapes", "Position&Scale" I preferred the compacted version (the buttons closest one to each other), but with right alignment.
Hi Igor, the photomontage was a suggestion. I was hoping to hear from you. I didn't expect him to implement my suggestion so quickly. He's just so incredibly fast at programming, which is good for the project. In the future I would recommend to make several suggestions, if there is no consensus we can start a user survey. It's certainly good, if several users decide with us. We could use Google forms or other survey tools. I'm afraid GG might get on his nerves if we change the layout again. I assume that he would like to close the mask topic. If an overwhelming majority wants a slightly different design then I think he would certainly not be averse to modifying it slightly. I myself am open to it. Sam
Okay, all the new buttons for all the themes for Mask tool are in compressed file added. Unfortunately the buttons for Blond-cv and Blue-dot themes are really ugly, sorry; at the beginning I was reworking these buttons but then I wondered myself “how many user use these themes?”, “Does it make sense to waste time making buttons that nobody uses?”. If You think different I will rework those buttons for Blond-cv and Blue-dot themes.
MaskTool_point-prst-pstn-scale_btns.tar.gz
I noticed that for the Enable (Show/Hide) button is used the Reset button. I think it should be another type of icon to distinguish features. I have done a few of demo buttons and I show you in the animated GIF. (Sorry GG another button, sigh-sigh. Sometimes I prefer the Generic button with the text inside because it is more flexible also from coder’s point of view, I think).
MaskTool_ShowHidebtn_demo_201900716.gif
My doubt/consideration about Presets Shapes: Now, with the 4 icons for each shape, when you press the its button, the mask is drawn immediately and it overwrite, if any, the previous mask. At the beginning, with the three Generic button Load-Save-Del, before overwriting the previous mask, you had to open its menu, to choose the shape in the list and then click on it. More clicks but you had time to cancel. What do you think about, please? @Sam Sorry Sam, when I saw your last photomontage I tried to login in MantisBT but at that time it didn’t work, and then I have done a full immersion in buttons, that I dream even when I sleep. ;-p Thank you! IgorBeg (the buttons have been tested in Cin version: “cinelerra-5.1-ub16-x86_64-static_20190711-testing”)
Hi GG/Phyllis, Thanks for the last build Jul 18 2019. I saw that in Cin-20190718 there are not the buttons I have done for all the themes. You find them in "MaskTool_point-prst-pstn-scale_btns.tar.gz" and you must overwrite all the old PNGs (it wrote in the previous mail). Is there any problem? Let me know, please. Igor
IgorB: We are VERY HAPPY with the new icons and GG will add them in soon. BUT I have to catch up on all of the masking issue #2 responses to see if anything else has to be done so I can make a list for GG. And now you can go back to using MantisBT for ongoing communication. Thanks, gg/Phyllis On Fri, Jul 19, 2019 at 12:33 AM Igor BEGHETTO <[email protected]> wrote:
Hi GG/Phyllis, Thanks for the last build Jul 18 2019. I saw that in Cin-20190718 there are not the buttons I have done for all the themes. You find them in "MaskTool_point-prst-pstn-scale_btns.tar.gz" and you must overwrite all the old PNGs (it wrote in the previous mail). Is there any problem? Let me know, please.
Igor -- Cin mailing list [email protected] https://lists.cinelerra-gg.org/mailman/listinfo/cin
participants (3)
-
Igor BEGHETTO -
Phyllis Smith -
Sam