bitstream filtering - does not crash but also not completely work?
I tried to fix our internal bitstream filtering on muxing using this code https://github.com/FFmpeg/FFmpeg/blob/master/libavformat/tee.c it works in sense it stopped crashing and adding simple filter like dump_extra makes file a bit bigger. But complex stuff like cropping or rotation still does not work :-( not sure, may be we need to add those options via av_dict_set too ?
Seems reasonable patch at least to prevent a crash. I built it, ran CinGG, and it does not appear to cause any problems so next time I boot the desktop, I will check it into GIT. On Mon, Nov 21, 2022 at 3:26 AM Andrew Randrianasulu < [email protected]> wrote:
I tried to fix our internal bitstream filtering on muxing using this code
https://github.com/FFmpeg/FFmpeg/blob/master/libavformat/tee.c
it works in sense it stopped crashing and adding simple filter like dump_extra makes file a bit bigger.
But complex stuff like cropping or rotation still does not work :-(
not sure, may be we need to add those options via av_dict_set too ?
Maybe I misunderstood -- was it crashing BEFORE this patch was added? or did you mean working on this patch made it crash until you got it working? On Mon, Nov 21, 2022 at 3:26 AM Andrew Randrianasulu < [email protected]> wrote:
I tried to fix our internal bitstream filtering on muxing using this code
https://github.com/FFmpeg/FFmpeg/blob/master/libavformat/tee.c
it works in sense it stopped crashing and adding simple filter like dump_extra makes file a bit bigger.
But complex stuff like cropping or rotation still does not work :-(
not sure, may be we need to add those options via av_dict_set too ?
пн, 21 нояб. 2022 г., 22:20 Phyllis Smith <[email protected]>:
Maybe I misunderstood -- was it crashing BEFORE this patch was added? or did you mean working on this patch made it crash until you got it working?
it was crashing before IF you try output encoder profile with bitsream filtering enabled - with | just after muxer/encoder pair in first line
On Mon, Nov 21, 2022 at 3:26 AM Andrew Randrianasulu < [email protected]> wrote:
I tried to fix our internal bitstream filtering on muxing using this code
https://github.com/FFmpeg/FFmpeg/blob/master/libavformat/tee.c
it works in sense it stopped crashing and adding simple filter like dump_extra makes file a bit bigger.
But complex stuff like cropping or rotation still does not work :-(
not sure, may be we need to add those options via av_dict_set too ?
participants (2)
-
Andrew Randrianasulu -
Phyllis Smith