In an exchange of mails Igor Vladimirsky pointed out to me that the old bug reported by Camille: https://lists.cinelerra-gg.org/pipermail/cin/2021-March/003149.html and: https://www.cinelerra-gg.org/bugtracker/view.php?id=559 Has been fixed by Adam in CinHV. The patch with the fix is at: https://github.com/heroineworshiper/hvirtual/commit/9080ca3fc952edce68fcabb6... Andrew, do you think it is possible to implement the patch in CinGG?
вс, 7 апр. 2024 г., 00:19 Andrea paz via Cin <[email protected]>:
In an exchange of mails Igor Vladimirsky pointed out to me that the old bug reported by Camille:
https://lists.cinelerra-gg.org/pipermail/cin/2021-March/003149.html and: https://www.cinelerra-gg.org/bugtracker/view.php?id=559
Has been fixed by Adam in CinHV. The patch with the fix is at:
https://github.com/heroineworshiper/hvirtual/commit/9080ca3fc952edce68fcabb6...
Andrew, do you think it is possible to implement the patch in CinGG?
may be? I hope it just self-contained in plugins/dissolve ... will try to copy/pasta changes from this commit tomorrow when I power up desktop --
Cin mailing list [email protected] https://lists.cinelerra-gg.org/mailman/listinfo/cin
Our ChromaKey is broken as demoed in previous emails with GG-BLUR.tar.bz2. I was trying to incorporate some changes in the version 8 (in GitHub) of HV but failed to just get it to work. But hopefully Andrew will figure it out. P.S. We lost power here due to high winds, so have not completed ffmpeg 7.0 compile yet and then will be testing the TV record and bluray writes. On Sat, Apr 6, 2024 at 3:53 PM Andrew Randrianasulu via Cin < [email protected]> wrote:
Andrew, do you think it is possible to implement the patch in CinGG?
may be? I hope it just self-contained in plugins/dissolve ... will try to copy/pasta changes from this commit tomorrow when I power up desktop <https://lists.cinelerra-gg.org/mailman/listinfo/cin>
сб, 6 апр. 2024 г. в 21:59, Phyllis Smith via Cin < [email protected]>:
Our ChromaKey is broken as demoed in previous emails with GG-BLUR.tar.bz2. I was trying to incorporate some changes in the version 8 (in GitHub) of HV but failed to just get it to work. But hopefully Andrew will figure it out.
Hi all, I have written a new article about Chroma Key HSV https://linuxvideoediting.blogspot.com/2024/04/chroma-key-hsv-cinelerra.html The article consists of two parts. In the first part I describe what I already showed in the screencast https://www.youtube.com/watch?v=QATi9J6Q8uw I added a small excursion into the history of the plugin and a few screenshots. Read this msg from Jerome (2006) Quote: *"I saw this (Avid's new chroma keyer): and I told myself that it would be cool to have a similar plugin for Cinelerra.So I completely modified the chromakey plugin."* -------- As you see, Jerome was trying to replicate the Avid's new chroma keyer (SpectraMatte). https://resources.avid.com/SupportFiles/attach/Symphony_Effects_and_CC_Guide... (pages: 203 - 212, 691 - 703) but the problem seems to be harder than he thought. The current ChromaKeyHSV (in CV*/GG and [HV_before-02.2024] ) is doing whatever Jerome Cornet had. However, the original Avid algorithm is a lot more complex & might have been marketing. ChromaKey HSV in HV_before-02.2024 (before upgrading) is Jerome's version. The current implementation of ChromaKeyHSV in Cinelerra-HV_after-02.2024 is most of the SpectraMatte algorithm. I describe it in the second part of the article. It contains many original screenshots. If you delve into the operation of the 'Saturation Offset' parameter, the question arises: "What is the difference between it and 'Min Saturation'?" If you watched the screencast, you saw that 'Saturation Offset' only takes effect if 'Min Saturation' is > 0. Both set the minimum. saturation level, but S.O. cannot set a level lower than that specified using M.S. I.e. in conjunction with S.O., M.S. may act as a limiter. That's all? In theory, the purpose of the parameter is to shift the keying sector along the line of increasing saturation. However, it appears that either Jerome did not complete the parameter, or the parameter is broken. You can "squeeze" the following out of it: set 'In Slope' and 'Out Slope', then turn up 'Saturation Min' to maximum. And let's increase 'Sat.Offset' a little as in the screenshot https://blogger.googleusercontent.com/img/b/R29vZ2xl/AVvXsEiR-BA3Khw0mq2b8w8... I.e. its current capabilities allow it to do something similar to an offset. But all this looks unconvincing. I looked at how the parameter works in other forks (cin-cv/cve/gg) - the behavior was/is the same everywhere. In addition, I encountered the fact that 'Spill Threshold' did not work properly in Cin-HV__before-02.2024 and Cin-GG (it was throwing artifacts). I recorded a screencast and sent it to Adam. I attached to the letter the collected information on the plugin (who made it, when, goals) and links to the official SpectraMatte documentation. A few days later, Adam made a number of bugfixes and innovations and wrote an algorithm for the plugin similar to the SM algorithm. I quote Adam's comment in the code: "The current implementation is most of the SpectraMatte algorithm.". 'Saturation Offset' was first removed (with a verdict 'confused' and a transparent hint to ask Jerome himself what he wanted to tell the world with this parameter), and later was resurrected again, but in a new quality https://drive.google.com/file/d/1ECMFIDBsditblrmmV2pISAGCLM_xp5oi/view?usp=s... (I made this screencast during testing). Everything else in the article is a technical part and it seems that the google translator translates it into English quite well. About Cin-GG This screencast/screenshot shows the problem with 'Spill Threshold' (select 720-quality in player's settings) https://drive.google.com/file/d/13saceEUhBpNT9fkzRQhgUFrfr-f9o60l/view?usp=s... https://drive.google.com/file/d/1WPTFC6qF8kfF_dDva25o7cEM0j2lKo4x/view?usp=s... XML for testing. Created in CinGG-20240229-x86_64-older-distros.AppImage https://drive.google.com/file/d/1zRFIgx2yJ6lkbeNNrazYj93yv79JIZBk/view?usp=s... This screencast (Jerome's version in CV) shows how the parameter should work. https://drive.google.com/file/d/1HvdDyO0jqe2yY4H2VbkXqnylotnXmhnK/view?usp=s... =========== What do I recommend to understand what's going on with ChKHSV in Cin-HV (GG)? Go to the Source_code repo https://github.com/heroineworshiper/hvirtual/commits/master/?after=43fd35a61... This is the 1-st commit for CK-HSV-fixing (after my report) https://github.com/heroineworshiper/hvirtual/commit/739bb752739d177fbeb870f3... chromakey HSV fixes. Color swatch generator The 2-nd commit is https://github.com/heroineworshiper/hvirtual/commit/c297ff15f3a2a86d6905c9b2... It removes confusing parameter (Saturation Offset). Makes YUV fix (spill threshold creates artifacts in YUV) + This commit removes 'Saturation Offset' from GUI. ----- The next commits implement AVID's algorithm ------- To get the build (from Adam's binary repo !) that contains the changes for fixing Jerome's version in HV, use wget https://github.com/heroineworshiper/hvirtual_bin/archive/adfebed3e473adc416b... The binary repo was created by Adam after my request. The next buld in the binary repo contains AVID's algorithm. ---------------------------------- IgorV
вс, 7 апр. 2024 г. в 04:59, Igor Vladimirsky <[email protected]>:
сб, 6 апр. 2024 г. в 21:59, Phyllis Smith via Cin < [email protected]>:
Our ChromaKey is broken as demoed in previous emails with GG-BLUR.tar.bz2. I was trying to incorporate some changes in the version 8 (in GitHub) of HV but failed to just get it to work. But hopefully Andrew will figure it out.
Hi all, I have written a new article about Chroma Key HSV
https://linuxvideoediting.blogspot.com/2024/04/chroma-key-hsv-cinelerra.html
Look at this https://github.com/heroineworshiper/hvirtual/commit/2ffbc06c197e49000f1dfe23... Adam has updated 'Secrets of Cinelerra', including for the updated chromakey. I have not contacted him regarding documentation for the chroma key hsv effect We wrote it independently of each other. It will be very interesting to compare it with my blog-post and make additions if necessary. The online version of the HV-manual has not yet been updated. ---------------- To build doc, you have to make git clone https://github.com/heroineworshiper/hvirtual --depth 1 --branch master cin-hv_src then go to cin-hv_src/doc$ makeinfo --html --no-split ./cinelerra.texi # use this to create a single document. OR cin-hv_src/doc$ makeinfo --html ./cinelerra.texi # use this to create multiple HTML pages. Not searchable ==> SECRETS OF CINELERRA Version 9 by Adam Williams Copyright © 2011-2024 ------------------- P.S. I have compared. Looks like my article is better. )
Yes, thank you. I read the manual on the new ChromaKey hsv. As for the compilation, I am not very good at it. Some time ago I had tried CinCV just because it was present in Arch's AUR. CinHV I tried to install it unsuccessfully and have not tried again. CinCVE I have never tried.... PS: Your article is very clear and comprehensive. Adam is always in too much of a hurry and takes many things for granted.
Hi IgorV! I am glad you are here, in the CinGG Community! I read your article about Chroma Key HSV and saw the video. Well done! Thanks! I hope in the effort of a developer to implement the fix, if possible. In add, for the GUI, I would like to have the Text Box and the Clear button for each slider. It would be useful. So We can see the value, immediatly. But the plugin window would be much larger, I think. IgorBeg
I have done a photomontage for the Chromakey_HSV. I add here two PNGs: the original and my photomontage. I know that the plugin window is much bigger for the second one, but We could see the values of the sliders at the first glance, I think. IgorBeg Il 14/04/2024 11:23, Igor BEGHETTO via Cin ha scritto:
In add, for the GUI, I would like to have the Text Box and the Clear button for each slider. It would be useful. So We can see the value, immediatly. But the plugin window would be much larger, I think.
I also find ChrmaKeyHSV's window too narrow. I like IgorB's proposal very much.
IgorBeg, like Andrea said that is much better and if you want to share, that would be appreciated. On Thu, Apr 18, 2024 at 1:26 AM Igor BEGHETTO via Cin < [email protected]> wrote:
I have done a photomontage for the Chromakey_HSV. I add here two PNGs: the original and my photomontage. I know that the plugin window is much bigger for the second one, but We could see the values of the sliders at the first glance, I think.
Sorry, there is a misunderstanding. It is a photomontage made with Gimp. If you want I can share the gimp file (.xcf). I am sorry. Il 18/04/2024 19:24, Phyllis Smith ha scritto:
IgorBeg, like Andrea said that is much better and if you want to share, that would be appreciated.
On Thu, Apr 18, 2024 at 1:26 AM Igor BEGHETTO via Cin <[email protected] <mailto:[email protected]>> wrote:
I have done a photomontage for the Chromakey_HSV. I add here two PNGs: the original and my photomontage. I know that the plugin window is much bigger for the second one, but We could see the values of the sliders at the first glance, I think.
On Sun, Apr 7, 2024 at 12:52 AM Andrew Randrianasulu < [email protected]> wrote:
вс, 7 апр. 2024 г., 00:19 Andrea paz via Cin <[email protected]>:
In an exchange of mails Igor Vladimirsky pointed out to me that the old bug reported by Camille:
https://lists.cinelerra-gg.org/pipermail/cin/2021-March/003149.html and: https://www.cinelerra-gg.org/bugtracker/view.php?id=559
Has been fixed by Adam in CinHV. The patch with the fix is at:
https://github.com/heroineworshiper/hvirtual/commit/9080ca3fc952edce68fcabb6...
Andrew, do you think it is possible to implement the patch in CinGG?
may be? I hope it just self-contained in plugins/dissolve ... will try to copy/pasta changes from this commit tomorrow when I power up desktop
Can you try attached patch ?
--
Cin mailing list [email protected] https://lists.cinelerra-gg.org/mailman/listinfo/cin
Can you try attached patch ?
It seems to me that the patch works. I used Camille's original video where you can see the title fade from black to transparent and finally to white as it should be. I superimposed my own title on top of it ( on top) where instead the fade always remains white. The demonstration video is here: https://streamable.com/cqg3u2 I recommend advancing frame by frame. Thank you, Andrew
Maybe I am wrong, but it does not seem to be any different to me. I tested on Fedora and Ubuntu 16. Attached is a tar file containing unwanted_black_flash.xml that can be untarred to /tmp and then the xml file loaded into CinGG. But I have created an Ubuntu 16 AppImage with the dissolve mod and and the latest pluginfclient.C for the version 7 ffmpeg audio filters. I have to upload yet to the server. On Sat, Apr 20, 2024 at 12:26 PM Andrea paz via Cin < [email protected]> wrote:
Can you try attached patch ?
It seems to me that the patch works.
You are right. You can't see it by applying Title to the same track as the purple background, but by putting Title in an empty upper track the problem is still there.
On Sun, Apr 21, 2024 at 9:50 AM Andrea paz <[email protected]> wrote:
You are right. You can't see it by applying Title to the same track as the purple background, but by putting Title in an empty upper track the problem is still there.
Thing is, patch only alters dissolve plugin, and not titler (our titler and one in cinHV differentiate quite far) But then I tried to reconstruct test case with red and white2 png (rgb from cinHV tests folder) on same track with dissolve transition between them and even unpatched cingg was ok in all modes (yuva-8, rgb-8 ...) ?
As You all said,... nothing is changed for me. Tested on UbuntuStudio_16.04 with "cin-x86_64_older_20240421.AppImage" by Phyllis. Test file used is "unwanted_black_flash.xml" by Phyllis, and other tests by myself. This "cin-x86_64_older_20240421.AppImage" version works in the same way of my Cin Reference version. I am sorry. IgorBeg
Andrew_R wrote: Thing is, patch only alters dissolve plugin, and not titler (our titler and one in cinHV differentiate quite far). But then I tried to reconstruct test case with red and white2 png (rgb from cinHV tests folder) on same track with dissolve transition between them and even unpatched cingg was ok in all modes (yuva-8, rgb-8 ...) ?
Andrea_paz wrote: You are right. You can't see it by applying Title to the same track as the purple background, but by putting Title in an empty upper track the problem is still there.
Phyllis wrote: ...but it does not seem to be any different to me.
сб, 6 апр. 2024 г. в 21:19, Andrea paz via Cin <[email protected]>:
In an exchange of mails Igor Vladimirsky pointed out to me that the old bug reported by Camille: https://lists.cinelerra-gg.org/pipermail/cin/2021-March/003149.html and: https://www.cinelerra-gg.org/bugtracker/view.php?id=559 Has been fixed by Adam in CinHV. The patch with the fix is at:
https://github.com/heroineworshiper/hvirtual/commit/9080ca3fc952edce68fcabb6... Andrew, do you think it is possible to implement the patch in CinGG? --
Hi, it is not about chromakey. It is about Title/Fade/Dissolve. Seems, works Ok for me in hv from https://github.com/heroineworshiper/hvirtual_bin Needs, of course, more testing. imbw xml, images for hv https://drive.google.com/file/d/1spi6WLzOuzFwTa69_4l3rZI-F0aEUQBx/view?usp=s...
I tried taking the ChromaKeyHSV binary of CinHV and substituting it for that of CinGG. However, the program crashes at startup. I guess that's not the way to do it.... :)
participants (5)
-
Andrea paz -
Andrew Randrianasulu -
Igor BEGHETTO -
Igor Vladimirsky -
Phyllis Smith