Short list of what is currently being worked on here
Just a short update list of what i know to be currently active and in order of priority: 1) Continued testing/documentation of Georgy's *alt/h "Help"* implementation (has been checked into GIT). Andrea has been keeping the documentation up to date. 2) Testing of Andrew's fix of *Memory leak* that DeJay discovered and I had commented out to get past it temporarily (I am having trouble with my tests because I deleted the case that I was using that easily displayed the issue so that I could tell that it is now fixed). But this is important to get the correction in. 3) *FFmpeg 4.4 upgrade* with Andrea and me testing what we can and Andrew providing the "real work" with patches/how-to/etc. 4) A "freelancer" has been tasked with working on BT #559 - the *fade/flash bug* when using alpha in the Title Plugin and Dissolve Transition. It is not clear if this person is up to the challenge. 5) *Histogram plugin* changes from HV 7.3 to include the option *for seeing Luma onl*y besides Color (I am struggling with this because the differences between HV and GG are becoming so diverse, that I do not think I will be able to sort it out).
On Tuesday, May 11, 2021, Phyllis Smith via Cin <[email protected]> wrote:
Just a short update list of what i know to be currently active and in order of priority:
1) Continued testing/documentation of Georgy's *alt/h "Help"* implementation (has been checked into GIT). Andrea has been keeping the documentation up to date.
Yeah, very cool!! (sorry can't test personally - I send email to termux maillist showing my patches and describing my problems with thread library.. But no answer so far..)
2) Testing of Andrew's fix of *Memory leak* that DeJay discovered and I had commented out to get past it temporarily (I am having trouble with my tests because I deleted the case that I was using that easily displayed the issue so that I could tell that it is now fixed). But this is important to get the correction in. 3) *FFmpeg 4.4 upgrade* with Andrea and me testing what we can and Andrew providing the "real work" with patches/how-to/etc. 4) A "freelancer" has been tasked with working on BT #559 - the *fade/flash bug* when using alpha in the Title Plugin and Dissolve Transition. It is not clear if this person is up to the challenge.
I have some suspiction this 'flash' might be related to asynchronious operation, So one frame arrives too late, or being inserted after main operation just finished (due to some shared codepath invocked unconditionally). But this is just guess..... I remembrer transition code was reworked to support multithreading at some point - was this bug present before this rework? Does this bug present in HV 7.x? 5) *Histogram plugin* changes from HV 7.3 to include the option *for seeing
Luma onl*y besides Color (I am struggling with this because the differences between HV and GG are becoming so diverse, that I do not think I will be able to sort it out).
Is there any way to view hv 7.3 sources online? Thanks for all your work!
Andrew,
1) Continued testing/documentation of Georgy's *alt/h "Help"* implementation (has been checked into GIT). Andrea has been keeping the documentation up to date.
Yeah, very cool!! (sorry can't test personally - I send email to termux maillist showing my patches and describing my problems with thread library.. But no answer so far..)
Termux sounds like fun but I am not brave enough to put it on my Android phone ! It would probably work well on this old bigger tablet that never gets used.
4) A "freelancer" has been tasked with working on BT #559 - the *fade/flash
bug* when using alpha in the Title Plugin and Dissolve Transition. It is not clear if this person is up to the challenge.
I have some suspiction this 'flash' might be related to asynchronious operation, So one frame arrives too late, or being inserted after main operation just finished (due to some shared codepath invocked unconditionally). But this is just guess.....
I remembrer transition code was reworked to support multithreading at some point - was this bug present before this rework? Does this bug present in HV 7.x?
Thanks for the hint which I will pass along. This bug as presented in the Title plugin does not exist in HV 7.2; but the same bug that shows up in the Dissolve transition does not show up in 7.2 because the Dissolve does not even work there at all for the test case. The bug has been in CinGG since at least March 2016 -- that is as far as I have gone back.
5) *Histogram plugin* changes from HV 7.3 to include the option *for
seeing Luma onl*y besides Color (I am struggling with this because the differences between HV and GG are becoming so diverse, that I do not think I will be able to sort it out).
Is there any way to view hv 7.3 sources online?
Not as far as I know, but I will put the histogram files on our website later today so you can read them there. I had made mods to ours to get the luma in and it kind of works, but not always and I have no idea if it works correctly.
Andrew, 5) *Histogram plugin* changes from HV 7.3 to include the option *for seeing
Luma onl*y besides Color (I am struggling with this because the differences between HV and GG are becoming so diverse, that I do not think I will be able to sort it out).
Is there any way to view hv 7.3 sources online?
There is now ! https://cinelerra-gg.org/download/testing/histogram-7-3/ and https://cinelerra-gg.org/download/testing/histogram-7-2/ I put the 7-2 version out there temporarily because by comparing the 7.2 and 7.3, it is very easy to see the Luma changes. I had no problem getting the changes into the .h files (and into the window and config files), but obviously it is the histogram.C code itself that I do not comprehend.
On Tuesday, May 11, 2021, Phyllis Smith via Cin <[email protected]> wrote:
Andrew,
5) *Histogram plugin* changes from HV 7.3 to include the option *for
seeing Luma onl*y besides Color (I am struggling with this because the differences between HV and GG are becoming so diverse, that I do not think I will be able to sort it out).
Is there any way to view hv 7.3 sources online?
There is now ! https://cinelerra-gg.org/download/testing/histogram-7-3/ and https://cinelerra-gg.org/download/testing/histogram-7-2/
I put the 7-2 version out there temporarily because by comparing the 7.2 and 7.3, it is very easy to see the Luma changes. I had no problem getting the changes into the .h files (and into the window and config files), but obviously it is the histogram.C code itself that I do not comprehend.
I 'diff - u' two files and obvious commment popped out: +// calculate histograms for the RGB channels & +// the VALUE channel only if not automatic RGB So May be it works as intended?
Andrew, It probably does work as intended in HV 7.3 -- I just can't get the same capability incorporated into CinGG because the code has morphed a lot. The goal would be to add the same option to CinGG if it might be of value. Thanks for looking at it. On Tue, May 11, 2021 at 10:46 AM Andrew Randrianasulu via Cin < [email protected]> wrote:
On Tuesday, May 11, 2021, Phyllis Smith via Cin < [email protected]> wrote:
Andrew,
5) *Histogram plugin* changes from HV 7.3 to include the option *for
seeing Luma onl*y besides Color (I am struggling with this because the differences between HV and GG are becoming so diverse, that I do not think I will be able to sort it out).
Is there any way to view hv 7.3 sources online?
There is now ! https://cinelerra-gg.org/download/testing/histogram-7-3/ and https://cinelerra-gg.org/download/testing/histogram-7-2/
I put the 7-2 version out there temporarily because by comparing the 7.2 and 7.3, it is very easy to see the Luma changes. I had no problem getting the changes into the .h files (and into the window and config files), but obviously it is the histogram.C code itself that I do not comprehend.
I 'diff - u' two files and obvious commment popped out:
+// calculate histograms for the RGB channels & +// the VALUE channel only if not automatic RGB
So May be it works as intended? -- Cin mailing list [email protected] https://lists.cinelerra-gg.org/mailman/listinfo/cin
On Tuesday, May 11, 2021, Andrew Randrianasulu <[email protected]> wrote:
On Tuesday, May 11, 2021, Phyllis Smith via Cin < [email protected]> wrote:
Andrew,
5) *Histogram plugin* changes from HV 7.3 to include the option *for
seeing Luma onl*y besides Color (I am struggling with this because the differences between HV and GG are becoming so diverse, that I do not think I will be able to sort it out).
Is there any way to view hv 7.3 sources online?
There is now ! https://cinelerra-gg.org/download/testing/histogram-7-3/ and https://cinelerra-gg.org/download/testing/histogram-7-2/
I put the 7-2 version out there temporarily because by comparing the 7.2 and 7.3, it is very easy to see the Luma changes. I had no problem getting the changes into the .h files (and into the window and config files), but obviously it is the histogram.C code itself that I do not comprehend.
I 'diff - u' two files and obvious commment popped out:
+// calculate histograms for the RGB channels & +// the VALUE channel only if not automatic RGB
So May be it works as intended?
Yet diff between 7.3 and - gg is much larger, and I tend to agree changes between two not just cosmetic ( Obvious diff for example between // Do each channel - for(int i = 0; i < HISTOGRAM_MODES; i++) - { - if((!do_value && i < 3) || - (do_value && i == 3)) - { - int *accum = this->accum[i]; - int pixels = data->get_w() * data->get_h(); - float white_fraction = 1.0 - (1.0 - config.threshold) / 2; And + for( int i=0; i<3; ++i ) { + int64_t *accum = this->accum[i]; + int64_t sz = data->get_w() * data->get_h(); + int64_t pixels = sz * frames; + float white_fraction = 1.0 - (1.0 - config.threshold) / 2; But there also difference in shader code, calculating num. Of cpus, configuration and even algorithm (?)...
participants (2)
-
Andrew Randrianasulu -
Phyllis Smith