so I was using this patch as guidance https://github.com/HandBrake/HandBrake/pull/4451/commits/5e86b74d405f63ed020... apparently channels was replaced by ch_layout.nb_channels and channel_layout by ch_layout.u.mask I'll try to put ifdef guards around those changes and make some patches ...
сб, 6 апр. 2024 г., 01:16 Andrew Randrianasulu <[email protected]>:
so I was using this patch as guidance
https://github.com/HandBrake/HandBrake/pull/4451/commits/5e86b74d405f63ed020...
apparently channels was replaced by ch_layout.nb_channels
and channel_layout by ch_layout.u.mask
I'll try to put ifdef guards around those changes and make some patches ...
It compiles :) but not sure if it actually works .. note, it should compile even with our ffmpeg 6.1 , I hope? because api change was for 5.1, 7.0 just removed it as "long deprecated" .
This is going to be fun for me today! on different distros hopefully. Thanks and that was fast. On Sat, Apr 6, 2024 at 4:24 AM Andrew Randrianasulu <[email protected]> wrote:
сб, 6 апр. 2024 г., 01:16 Andrew Randrianasulu <[email protected]>:
so I was using this patch as guidance
https://github.com/HandBrake/HandBrake/pull/4451/commits/5e86b74d405f63ed020...
apparently channels was replaced by ch_layout.nb_channels
and channel_layout by ch_layout.u.mask
I'll try to put ifdef guards around those changes and make some patches ...
It compiles :)
but not sure if it actually works ..
note, it should compile even with our ffmpeg 6.1 , I hope? because api change was for 5.1, 7.0 just removed it as "long deprecated" .
How to compile CinGG with ffmpeg7? Should I remove ffmpeg5.1 and ffmpeg6.1 and all their patches and then add the tarball of ffmpeg7 plus your new patch?
вс, 7 апр. 2024 г., 14:09 Andrea paz <[email protected]>:
How to compile CinGG with ffmpeg7? Should I remove ffmpeg5.1 and ffmpeg6.1 and all their patches and then add the tarball of ffmpeg7 plus your new patch?
I just put ffmpeg 7.0 tar.xz into thirdparty/src then changed configure.ac so it refers to ffmpeg 7.0 instead of 6.1 then run ./autogen.sh configure make as usual. Nothing was deleted. (but then I haven't tried to port our patches yet ). Patch is git patch to apply to cinelerra sources, (git am/git apply) not patch to put in thirdparty/src
Compilation does not work. I attach the cin5.log In configure.ac I changed the entry: ffmpeg-6.1 to ffmpeg-7.0 However, I left two entries unchanged ffmpeg6 because in my system I still don't have ffmpeg7. Should I also change these two entries to ffmpeg7?
вс, 7 апр. 2024 г., 16:02 Andrea paz <[email protected]>:
Compilation does not work. I attach the cin5.log
In configure.ac I changed the entry: ffmpeg-6.1 to ffmpeg-7.0 However, I left two entries unchanged ffmpeg6 because in my system I still don't have ffmpeg7. Should I also change these two entries to ffmpeg7?
you mean echo "system_libs += -L/usr/pkg/lib/ffmpeg6" echo "CFLAGS += -I/usr/pkg/include/ffmpeg6" ? those are for NetBSD .... I am compiling on desktop machine right now, may be I forgot to make some changes so it only worked in termux ....
you mean echo "system_libs += -L/usr/pkg/lib/ffmpeg6" echo "CFLAGS += -I/usr/pkg/include/ffmpeg6" ? those are for NetBSD ....
Yes, I meant those. didn't know they were for BSD. In the log it talks about a cuda error; maybe it tries to activate even on my system that doesn't have cuda?
вс, 7 апр. 2024 г., 16:41 Andrea paz <[email protected]>:
you mean echo "system_libs += -L/usr/pkg/lib/ffmpeg6" echo "CFLAGS += -I/usr/pkg/include/ffmpeg6" ? those are for NetBSD ....
Yes, I meant those. didn't know they were for BSD. In the log it talks about a cuda error; maybe it tries to activate even on my system that doesn't have cuda?
I think this more related to our version of nv headers ... I tried to cp thirdparty/src/ffmpeg-6.1.patch10 as ffmpeg-7.0.patch10 and compilation currently progressed beyond this error.
вс, 7 апр. 2024 г., 16:45 Andrew Randrianasulu <[email protected]>:
вс, 7 апр. 2024 г., 16:41 Andrea paz <[email protected]>:
you mean echo "system_libs += -L/usr/pkg/lib/ffmpeg6" echo "CFLAGS += -I/usr/pkg/include/ffmpeg6" ? those are for NetBSD ....
Yes, I meant those. didn't know they were for BSD. In the log it talks about a cuda error; maybe it tries to activate even on my system that doesn't have cuda?
I think this more related to our version of nv headers ...
I tried to cp thirdparty/src/ffmpeg-6.1.patch10 as ffmpeg-7.0.patch10 and compilation currently progressed beyond this error.
Ah, even if most patches apart from 3, 4 and D still apply encoding is busted :/ so more work needed ....
I tried to cp thirdparty/src/ffmpeg-6.1.patch10 as ffmpeg-7.0.patch10 and compilation currently progressed beyond this error. Success! Thank you very much, Andrew.
I saw that in this edition there are few filters. In CinGG there is only "tiltandshift" filter; it does not give error but it does not work. In the terminal I have only the message: "resource temporarily unavaible" Of the other filters, there is no trace. These are: aap qrencode quirc fsync showinfo bitstream dnn
Ah, even if most patches apart from 3, 4 and D still apply encoding is busted :/ I have tried three encodings and they work normally (h265-Hi; DNxHR-HQX and AV1.svt).
On Sun, Apr 7, 2024 at 5:38 PM Andrea paz <[email protected]> wrote:
I tried to cp thirdparty/src/ffmpeg-6.1.patch10 as ffmpeg-7.0.patch10 and compilation currently progressed beyond this error. Success! Thank you very much, Andrew.
I saw that in this edition there are few filters. In CinGG there is only "tiltandshift" filter; it does not give error but it does not work. In the terminal I have only the message:
"resource temporarily unavaible"
Of the other filters, there is no trace. These are:
aap qrencode quirc fsync showinfo bitstream dnn
Ah, even if most patches apart from 3, 4 and D still apply encoding is busted :/ I have tried three encodings and they work normally (h265-Hi; DNxHR-HQX and AV1.svt).
I tried default ffmpeg mp4 profile and it was giving me errors ... But I think I fixed it, see last patch in attached git series (modelled after ffmpeg-7.0/doc/examples/transcode_aac.c) not sure about ac3 encoding and bdwrite yet ...
вс, 7 апр. 2024 г., 19:12 Phyllis Smith <[email protected]>:
I attached ffmpeg-7.0.patch0, but maybe we do not need anymore?? Andrew??
yes, patch0 was for termux, but I just added ffmpeg configure option into termux.bld so patch is not needed anymore ... bigger problem I can't make ac3 encoding to work, it does not crash but file is empty. And copying context by specialized av_ function just crashes it. So I am a bit stuck on this one.
Ah, even if most patches apart from 3, 4 and D still apply encoding is
busted :/ I have tried three encodings and they work normally (h265-Hi; DNxHR-HQX and AV1.svt).
OK, thanks Andrew. Creating blurays with what patches I had yesterday did not work, but am testing with the latest patches today so I am behind. On Sun, Apr 7, 2024 at 10:57 AM Andrew Randrianasulu < [email protected]> wrote:
вс, 7 апр. 2024 г., 19:12 Phyllis Smith <[email protected]>:
I attached ffmpeg-7.0.patch0, but maybe we do not need anymore?? Andrew??
yes, patch0 was for termux, but I just added ffmpeg configure option into termux.bld so patch is not needed anymore ...
bigger problem I can't make ac3 encoding to work, it does not crash but file is empty. And copying context by specialized av_ function just crashes it. So I am a bit stuck on this one.
Ah, even if most patches apart from 3, 4 and D still apply encoding is
busted :/ I have tried three encodings and they work normally (h265-Hi; DNxHR-HQX and AV1.svt).
Compilation with all the patches went well. I loaded a m2ts file with many audio channels and tried (from root) to do a BD render. I left all settings at default. At the end of the render I got a crash (no dump). In the terminal I have these lines: FFMPEG::open_decoder: some stream times estimated: /home/paz/video_editing/free_video/Amaze.m2ts Render::render_single: Session finished. ** rendered 1033 frames in 14.711 secs, 70.220 fps ++ dirname /home/paz/test/bd_20240407-202044/bd.sh + sdir=/home/paz/test/bd_20240407-202044 ++ cd /home/paz/test/bd_20240407-202044 ++ pwd + dir=/home/paz/test/bd_20240407-202044 + PATH=/usr/local/sbin:/usr/local/bin:/usr/bin:/usr/lib/jvm/default/bin:/usr/bin/site_perl:/usr/bin/vendor_perl:/usr/bin/core_perl:/opt/rocm/bin:/home/paz/cinelerra5/cinelerra-5.1/bin + mkdir -p /home/paz/test/bd_20240407-202044/udfs ++ du -cb /home/paz/test/bd_20240407-202044/bd.m2ts ++ tail -1 ++ sed -e 's/[ ].*//' + sz=53477376 + blks=30208 + rm -f /home/paz/test/bd_20240407-202044/bd.udfs + '[' -f /home/paz/test/bd_20240407-202044/bd.meta ']' + mkudffs -b 2048 /home/paz/test/bd_20240407-202044/bd.udfs 30208 filename=/home/paz/test/bd_20240407-202044/bd.udfs label=LinuxUDF uuid=6612e44ea433917e blocksize=2048 blocks=30208 udfrev=2.01 start=0, blocks=16, type=ERASE start=16, blocks=4, type=VRS start=20, blocks=76, type=ERASE start=96, blocks=16, type=MVDS start=112, blocks=16, type=ERASE start=128, blocks=4, type=LVID start=132, blocks=124, type=ERASE start=256, blocks=1, type=ANCHOR start=257, blocks=29688, type=PSPACE start=29945, blocks=6, type=ERASE start=29951, blocks=1, type=ANCHOR start=29952, blocks=96, type=ERASE start=30048, blocks=16, type=RVDS start=30064, blocks=143, type=ERASE start=30207, blocks=1, type=ANCHOR + mount -t udf -o loop /home/paz/test/bd_20240407-202044/bd.udfs /home/paz/test/bd_20240407-202044/udfs + bdwrite /home/paz/test/bd_20240407-202044/udfs /home/paz/test/bd_20240407-202044/bd.m2ts + umount /home/paz/test/bd_20240407-202044/udfs + echo To burn bluray, load writable media and run: To burn bluray, load writable media and run: + echo for WORM: growisofs -dvd-compat -Z /dev/bd=/home/paz/test/bd_20240407-202044/bd.udfs for WORM: growisofs -dvd-compat -Z /dev/bd=/home/paz/test/bd_20240407-202044/bd.udfs + echo for RW: dd if=/home/paz/test/bd_20240407-202044/bd.udfs of=/dev/bd bs=2048000 for RW: dd if=/home/paz/test/bd_20240407-202044/bd.udfs of=/dev/bd bs=2048000 + kill 197321 Terminato
Andrea, oops, I guess I had better try another video as BD Render did not crash for me, but I always use the same small file with only 2 channels. Your terminal output looks correct though! More testing !! Phyllis On Sun, Apr 7, 2024 at 12:28 PM Andrea paz <[email protected]> wrote:
Compilation with all the patches went well. I loaded a m2ts file with many audio channels and tried (from root) to do a BD render. I left all settings at default. At the end of the render I got a crash (no dump). In the terminal I have these lines:
On Sun, Apr 7, 2024 at 9:34 PM Phyllis Smith <[email protected]> wrote:
Andrea, oops, I guess I had better try another video as BD Render did not crash for me, but I always use the same small file with only 2 channels. Your terminal output looks correct though! More testing !! Phyllis
for fileac3.C I tried to add line av_channel_layout_copy(&codec_context->ch_layout, &ch_la yout); in FileAC3::open_file(int rd, int wr) function, so it reads av_channel_layout_copy(&codec_context->ch_layout, &ch_la yout); codec_context->sample_fmt = codec->sample_fmts[0]; SwrContext *resample_context = NULL; swr_alloc_set_opts2(&resample_context, but this does not lead to ac3 working. I'll try to ask on libav maillist
On Sun, Apr 7, 2024 at 12:28 PM Andrea paz <[email protected]> wrote:
Compilation with all the patches went well. I loaded a m2ts file with many audio channels and tried (from root) to do a BD render. I left all settings at default. At the end of the render I got a crash (no dump). In the terminal I have these lines:
Compiling and running just 1 test with the patches Andrew has supplied so far previously, on Ubuntu 16 and Debian 32-bit (9.1) is working. Hopefully, Andrea will continue to run with ffmpeg 7.0 so that he might notice more problems yet since he always has the most up to date Arch distro installed.
From Andrew's last email as partially shown below, it may be the Channel stuff that will be a problem so next I will do some TV record tests which uses Channels. Probably hardly anyone but me uses this, but I want it to keep working still.
for fileac3.C I tried to add line
av_channel_layout_copy(&codec_context->ch_layout, &ch_la yout);
in FileAC3::open_file(int rd, int wr) function, so it reads
av_channel_layout_copy(&codec_context->ch_layout, &ch_la yout); codec_context->sample_fmt = codec->sample_fmts[0]; SwrContext *resample_context = NULL; swr_alloc_set_opts2(&resample_context,
but this does not lead to ac3 working. I'll try to ask on libav maillist
I made a new compilation with Andrew's 5 patches and putting in /src the tarball of ffmpeg 7 plus patches3, patch 4 and patchD. All OK. The BD render still does not create the video, even with a media with only 2 audio tracks. I think it is my fault that I have never done BD/DVD and don't know how to do it....
More tests recording on the TV have been done and the TV channels scanned in just fine, but I need to go further in the testing. I am concerned that Andrea on his latest Arch install, is not able to BD render a video just taking all of the defaults. If he has time, could he check the "Output path" on the BD Render menu and then see if there is a bd.m2ts file with video content in it when Cinelerra quits/crashes? On Mon, Apr 8, 2024 at 2:09 AM Andrea paz <[email protected]> wrote:
I made a new compilation with Andrew's 5 patches and putting in /src the tarball of ffmpeg 7 plus patches3, patch 4 and patchD. All OK. The BD render still does not create the video, even with a media with only 2 audio tracks. I think it is my fault that I have never done BD/DVD and don't know how to do it....
Yes, "bd.m2ts" was created and it works. It is always my stupidity that I did not realize that CinGG always terminates automatically, at the end of bd-render, if there is no burner and db-disk. I apologize, as always.
In CinGG compiled with ffmpeg7 I find "strange" behavior that I do not encounter with appimage (which has ffmpeg6). Using a greenscreen image, as the top track and any media as the background track, we need to apply the ChromaKey HSV plugin. We can see that the "Alpha Offset" slider does not produce any change. It does not work. If we repeat the same test with appimage, the slider works normally. Can you verify if this is also the case for you or does it depend on me or my system? I have also tried other plugins that use the alpha channel, and also patchbay overlays, but everything works fine.
Andrea, I can verify that moving Alpha Slider in ChromakeyHSV seems to have no effect in build with ffmpeg 7.0 . And for me it has no effect with the Feb. Appimage (ffmpeg 6.1) or even June 2020 binary. Will attempt to go back further to check more. On Fri, Apr 12, 2024 at 1:07 AM Andrea paz <[email protected]> wrote:
In CinGG compiled with ffmpeg7 I find "strange" behavior that I do not encounter with appimage (which has ffmpeg6). Using a greenscreen image, as the top track and any media as the background track, we need to apply the ChromaKey HSV plugin. We can see that the "Alpha Offset" slider does not produce any change. It does not work. If we repeat the same test with appimage, the slider works normally.
Can you verify if this is also the case for you or does it depend on me or my system?
I have also tried other plugins that use the alpha channel, and also patchbay overlays, but everything works fine.
I also tried several appimages and always AlphaOffset did not work. After deleting ".bcast5" instead the slider works in both appimage and compiled CinGG. So I would say it's all OK, it is definitely not a ffmpeg 7 problem. I would say it is my problem that I often do the tests without renewing .bcast5 first. Sorry.
But why? there must be some setting conflict as the user should not have to start out with a fresh configuration to be able to use the Alpha Offset. I will play around to see if I can understand why. Also, later I will create an AppImage with ffmpeg 7.0 in it in case others want to test. However, AC3 not being fixed will prevent the upgrade though. On Sat, Apr 13, 2024 at 3:54 AM Andrea paz <[email protected]> wrote:
I also tried several appimages and always AlphaOffset did not work. After deleting ".bcast5" instead the slider works in both appimage and compiled CinGG. So I would say it's all OK, it is definitely not a ffmpeg 7 problem. I would say it is my problem that I often do the tests without renewing .bcast5 first. Sorry.
Sometimes I think it is my old projects or even not my own that cause some problems. For example to test ChromaKeyHSV I created my own project, but I also used two projects of IgorV. I could never see precise cause and effect though, so I'm not sure. Regarding AC3, there is a commit in Adam's repository about decoding AC3, but I don't think it is related. Anyway, the link is this one: https://github.com/heroineworshiper/hvirtual/commit/3124ad744154eae8e48bdeff...
сб, 13 апр. 2024 г., 21:04 Andrea paz <[email protected]>:
Sometimes I think it is my old projects or even not my own that cause some problems. For example to test ChromaKeyHSV I created my own project, but I also used two projects of IgorV. I could never see precise cause and effect though, so I'm not sure.
Regarding AC3, there is a commit in Adam's repository about decoding AC3, but I don't think it is related. Anyway, the link is this one:
https://github.com/heroineworshiper/hvirtual/commit/3124ad744154eae8e48bdeff...
yeah, looks like quicktime/ffmpeg interaction soecific to HV. Sorry, still stuck with this mysteriously non-working ac3 encoder ....
On Sat, Apr 13, 2024 at 9:13 PM Andrew Randrianasulu < [email protected]> wrote:
сб, 13 апр. 2024 г., 21:04 Andrea paz <[email protected]>:
Sometimes I think it is my old projects or even not my own that cause some problems. For example to test ChromaKeyHSV I created my own project, but I also used two projects of IgorV. I could never see precise cause and effect though, so I'm not sure.
Regarding AC3, there is a commit in Adam's repository about decoding AC3, but I don't think it is related. Anyway, the link is this one:
https://github.com/heroineworshiper/hvirtual/commit/3124ad744154eae8e48bdeff...
yeah, looks like quicktime/ffmpeg interaction soecific to HV.
Sorry, still stuck with this mysteriously non-working ac3 encoder ....
I think I fixed it, can you try attached patch on top of all previous?
First test looks good. Applied patch on top of other patches and did a full build. Created a DVD and played on TV. I am still trying to determine if it sounds a little different or my ears are just tired. Will do more tests. Thank you.
Sorry, still stuck with this mysteriously non-working ac3 encoder ....
I think I fixed it, can you try attached patch on top of all previous?
Tried a longer .ts file with 6 audio channels on bluray (default and no variations) - still no problem yet but will keep testing. Attaching ffmpeg-7.0.patch4 and ffmpeg-7.0.patchD here -- have no idea if patch4 is correct BUT patchD should be OK and I will test later. On Sun, Apr 7, 2024 at 12:34 PM Phyllis Smith <[email protected]> wrote:
Andrea, oops, I guess I had better try another video as BD Render did not crash for me, but I always use the same small file with only 2 channels. Your terminal output looks correct though! More testing !! Phyllis
On Sun, Apr 7, 2024 at 12:28 PM Andrea paz <[email protected]> wrote:
Compilation with all the patches went well. I loaded a m2ts file with many audio channels and tried (from root) to do a BD render. I left all settings at default. At the end of the render I got a crash (no dump). In the terminal I have these lines:
Default, with no variations having been tested, *Bluray creation works and plays* on Samsung and LG TV connected devices just fine. This is after I patched with 0005-Fix-audio-encoding-with-ffmpeg-7.0.patch and I had added the attached patch to thirdparty/src/ffmpeg-7.0.patch3 (which I re-created based on 6.1 and although it looks like it should be the same, I have no idea if it is even correct). However, I "think" Andrew already knows that DVD creation fails:
virtual int FileAC3::open_file(int, int): FileAC3::open_file failed to open codec. FileAC3::encode_flush: encode failed: Invalid argument
On Sun, Apr 7, 2024 at 10:57 AM Andrew Randrianasulu < [email protected]> wrote:
вс, 7 апр. 2024 г., 19:12 Phyllis Smith <[email protected]>:
I attached ffmpeg-7.0.patch0, but maybe we do not need anymore?? Andrew??
yes, patch0 was for termux, but I just added ffmpeg configure option into termux.bld so patch is not needed anymore ...
bigger problem I can't make ac3 encoding to work, it does not crash but file is empty. And copying context by specialized av_ function just crashes it. So I am a bit stuck on this one.
Ah, even if most patches apart from 3, 4 and D still apply encoding is
busted :/ I have tried three encodings and they work normally (h265-Hi; DNxHR-HQX and AV1.svt).
Andrea, thank you for this list. Results are a little strange. I have a local modified version of ffmpeg/plugin.opts to comment out aap and fsync which were giving errors on a fresh startup with ffmpeg 7.0. Also commented out tiltandshift which as you noted gives an error message -- but does something anyway. I tried varying parameter values to see if there was something that would not generate the Resource Temporarily Unavailable error message but there doesn't seem to be one. I saw that in this edition there are few filters. In CinGG there is
only "tiltandshift" filter; it does not give error but it does not work. In the terminal I have only the message:
"resource temporarily unavaible"
Of the other filters, there is no trace. These are:
aap qrencode quirc fsync showinfo bitstream dnn
participants (3)
-
Andrea paz -
Andrew Randrianasulu -
Phyllis Smith