due to giflib-5.2.2.patch2 I removed patch and build is ok. Not sure where this patch was needed, may be on older distros? I also tried to "set -e" before building cingg and get build breaking error somewhere in x265 dir, as reported already. but for me default (seen with "set -o" ) errexit=off, you can set it off for specific build by executing "set +e" before building cingg.
I will see if I can find any history of giflib-5.2.2.patch2. Does the multibit compile work for you on Termux? Tarantas added to our bug report of: https://www.cinelerra-gg.org/bugtracker/view.php?id=650#c5694giflib-5.2.2.pa... which I tried to track but failed. On Wed, Sep 4, 2024 at 11:38 AM Andrew Randrianasulu < [email protected]> wrote:
due to giflib-5.2.2.patch2
I removed patch and build is ok. Not sure where this patch was needed, may be on older distros?
I also tried to "set -e" before building cingg and get build breaking error somewhere in x265 dir, as reported already.
but for me default (seen with "set -o" ) errexit=off, you can set it off for specific build by executing "set +e" before building cingg.
ср, 4 сент. 2024 г., 20:41 Phyllis Smith <[email protected]>:
I will see if I can find any history of giflib-5.2.2.patch2. Does the multibit compile work for you on Termux?
seems to be yes (12 bit profile): x265 [info]: HEVC encoder version 3.5+1-f0c1022b6 x265 [info]: build info [Linux][clang 18.1.8][64 bit][noasm] 12bit x265 [info]: using cpu capabilities: NEON x265 [info]: Main 4:2:2 12 profile, Level-4 (Main tier) x265 [info]: Thread pool created using 8 threads x265 [info]: Slices : 1 x265 [info]: frame threads / pool features : 3 / wpp(17 rows) x265 [info]: Coding QT: max CU size, min CU size : 64 / 8 x265 [info]: Residual QT: max TU size, max depth : 32 / 1 inter / 1 intra x265 [info]: ME / range / subpel / merge : hex / 57 / 2 / 3 x265 [info]: Keyframe min / max / scenecut / bias : 30 / 30 / 40 / 5.00 x265 [info]: Lookahead / bframes / badapt : 20 / 4 / 2 x265 [info]: b-pyramid / weightp / weightb : 1 / 1 / 0 x265 [info]: References / ref-limit cu / depth : 3 / off / on x265 [info]: AQ: mode / str / qg-size / cu-tree : 2 / 1.0 / 32 / 1 x265 [info]: Rate Control / qCompress : CRF-28.0 / 0.60 x265 [info]: tools: rd=3 psy-rd=2.00 early-skip rskip mode=1 signhide tmvp x265 [info]: tools: b-intra strong-intra-smoothing lslices=6 deblock sao FFMPEG::open_decoder: some stream times estimated: /data/data/com.termux/files/home/20081103140154.m2t x265 [info]: frame I: 1, Avg QP:27.43 kb/s: 10667.00 x265 [info]: frame P: 6, Avg QP:28.99 kb/s: 1510.10 x265 [info]: frame B: 22, Avg QP:34.82 kb/s: 199.49 x265 [info]: Weighted P-Frames: Y:0.0% UV:0.0% encoded 29 frames in 18.36s (1.58 fps), 831.60 kb/s, Avg QP:33.36 Render::render_single: Session finished. ** rendered 29 frames in 18.774 secs, 1.545 fps Tarantas added to our bug report of:
https://www.cinelerra-gg.org/bugtracker/view.php?id=650#c5694giflib-5.2.2.pa... which I tried to track but failed.
On Wed, Sep 4, 2024 at 11:38 AM Andrew Randrianasulu < [email protected]> wrote:
due to giflib-5.2.2.patch2
I removed patch and build is ok. Not sure where this patch was needed, may be on older distros?
I also tried to "set -e" before building cingg and get build breaking error somewhere in x265 dir, as reported already.
but for me default (seen with "set -o" ) errexit=off, you can set it off for specific build by executing "set +e" before building cingg.
On Wed, Sep 4, 2024 at 11:38 AM Andrew Randrianasulu < [email protected]> wrote:
due to giflib-5.2.2.patch2
I removed patch and build is ok. Not sure where this patch was needed, may be on older distros?
Maybe I did not correctly carry over patch2 when I upgraded giflib from 5.2.1 to 5.2.2 on August 16th GIT checkin. Am I correct in assuming the 5.2.1 giflib with the previous patches built correctly on Termux? If so, then maybe I made a mistake in the 5.2.2 patch2.
ср, 4 сент. 2024 г., 21:26 Phyllis Smith <[email protected]>:
On Wed, Sep 4, 2024 at 11:38 AM Andrew Randrianasulu < [email protected]> wrote:
due to giflib-5.2.2.patch2
I removed patch and build is ok. Not sure where this patch was needed, may be on older distros?
Maybe I did not correctly carry over patch2 when I upgraded giflib from 5.2.1 to 5.2.2 on August 16th GIT checkin. Am I correct in assuming the 5.2.1 giflib with the previous patches built correctly on Termux? If so, then maybe I made a mistake in the 5.2.2 patch2.
may be os itself (stdlib, clang) changed? I looked at both patches and they look similar for me?
Patch 2 was added in February 2019 with the GIT commit "gif rework" 9afc3844e37c6db23435d5d0c33129dcc81061e4 and per the Release Notes: Gif native capability has been completely upgraded to allow for reading and
writing the gif format in singles, sequences or lists. As a side effect of this effort all of the other sequences have had the letter “s” added at the end of the extension filename automatically generated on a render.
It must be needed, but why did it work with giflib 5.2.1 but not 5.2.2 for termux? I don't know -- I still think I must have done something wrong with the patch and will check again anyway. On Wed, Sep 4, 2024 at 11:38 AM Andrew Randrianasulu < [email protected]> wrote:
due to giflib-5.2.2.patch2
I removed patch and build is ok. Not sure where this patch was needed, may be on older distros?
I also tried to "set -e" before building cingg and get build breaking error somewhere in x265 dir, as reported already.
but for me default (seen with "set -o" ) errexit=off, you can set it off for specific build by executing "set +e" before building cingg.
Andrew, Could you test the Termux build with the attached patch2? I found a mistake in what I had checked into GIT that I thought I had fixed. I do not get a failure on fedora or ubuntu 16 so can not test. Mistake was corrected in the following + line in patch2 (QSort was mistakenly typed as qsort). - qsort(SortArray, NewColorSubdiv[Index].NumEntries, - sizeof(QuantizedColorType *), SortCmpRtn); *+ QSort*(SortArray, -1, NewColorSubdiv[Index].NumEntries, SortRGBAxis); /* Relink the sorted list into one: */ for (j = 0; j < NewColorSubdiv[Index].NumEntries - 1; j++) { @@ -339,19 +359,4 @@ On Wed, Sep 4, 2024 at 11:38 AM Andrew Randrianasulu < [email protected]> wrote:
due to giflib-5.2.2.patch2
I removed patch and build is ok. Not sure where this patch was needed, may be on older distros?
I also tried to "set -e" before building cingg and get build breaking error somewhere in x265 dir, as reported already.
but for me default (seen with "set -o" ) errexit=off, you can set it off for specific build by executing "set +e" before building cingg.
пт, 6 сент. 2024 г., 23:07 Phyllis Smith <[email protected]>:
Andrew, Could you test the Termux build with the attached patch2? I found a mistake in what I had checked into GIT that I thought I had fixed. I do not get a failure on fedora or ubuntu 16 so can not test. Mistake was corrected in the following + line in patch2 (QSort was mistakenly typed as qsort).
yes, it builds here now, thanks!
- qsort(SortArray, NewColorSubdiv[Index].NumEntries, - sizeof(QuantizedColorType *), SortCmpRtn); *+ QSort*(SortArray, -1, NewColorSubdiv[Index].NumEntries, SortRGBAxis);
/* Relink the sorted list into one: */ for (j = 0; j < NewColorSubdiv[Index].NumEntries - 1; j++) { @@ -339,19 +359,4 @@
On Wed, Sep 4, 2024 at 11:38 AM Andrew Randrianasulu < [email protected]> wrote:
due to giflib-5.2.2.patch2
I removed patch and build is ok. Not sure where this patch was needed, may be on older distros?
I also tried to "set -e" before building cingg and get build breaking error somewhere in x265 dir, as reported already.
but for me default (seen with "set -o" ) errexit=off, you can set it off for specific build by executing "set +e" before building cingg.
participants (2)
-
Andrew Randrianasulu -
Phyllis Smith