BUG on Clear keyframes (CinGG-release by GIT 30Aug 2020)
Clear Keyframes (Shift+Del) do not delete the right keyframes. Maybe it's too late for the monthy release but a bug I found. I don't know if this bug is also in the last GIT release. 1. Create three (or more) Fade keyframes 2. Highlight an area to select one or more Fade keyframe 3. Hit Shift+Del shortcut or Keyframes-> Clear Keyframes 4. It delete the wrong keyframes and move others. (Note: Settings-> keyframes follow edits = checked) Take a look the screencast at https://streamable.com/q58t37 Thanks! (Sorry for the late) IgorBeg
В сообщении от Monday 31 August 2020 15:56:28 Igor BEGHETTO via Cin написал(а):
Clear Keyframes (Shift+Del) do not delete the right keyframes. Maybe it's too late for the monthy release but a bug I found. I don't know if this bug is also in the last GIT release.
I think bug still exist in latest (0678b17975f50a831fb8a1cda6baaa961e3b6de7) code, at least if I try to cover all existing keyframes by highlighting them - they all disappear. But if I only select 2-3 out of 4 - yes, remaining keyframes moved left, into higlighted region. Thing is, because those keyframes represent change ... deleting only SOME of them will create new curve (default value in highlighted region, abruptly starting to climb to remaining keyframes as we move outside of highlighted region). I mean, isn't this operation ought to *create* some keyframes in such case, too?
1. Create three (or more) Fade keyframes 2. Highlight an area to select one or more Fade keyframe 3. Hit Shift+Del shortcut or Keyframes-> Clear Keyframes 4. It delete the wrong keyframes and move others. (Note: Settings-> keyframes follow edits = checked)
Take a look the screencast at https://streamable.com/q58t37
Thanks! (Sorry for the late)
IgorBeg
Thanks Igor and Andrew for testing some more, GG was hoping to come up with a fast solution to get into the builds but unfortunately it is going to take a design change which needs a week to code and test. So he decided it is better to do the builds and leave in a "known bug" instead of create an unknown one. He says a workaround is to turn on/off "keyframes follow edits when this error could surface. Sorry about this. It is mostly my fault as I have been unable to test this major mod for bump autos. On Mon, Aug 31, 2020 at 6:57 AM Igor BEGHETTO via Cin < [email protected]> wrote:
Clear Keyframes (Shift+Del) do not delete the right keyframes. Maybe it's too late for the monthy release but a bug I found. I don't know if this bug is also in the last GIT release. 1. Create three (or more) Fade keyframes 2. Highlight an area to select one or more Fade keyframe 3. Hit Shift+Del shortcut or Keyframes-> Clear Keyframes 4. It delete the wrong keyframes and move others. (Note: Settings-> keyframes follow edits = checked)
Take a look the screencast at https://streamable.com/q58t37
Thanks! (Sorry for the late)
IgorBeg -- Cin mailing list [email protected] https://lists.cinelerra-gg.org/mailman/listinfo/cin
В сообщении от Monday 31 August 2020 19:34:20 Phyllis Smith via Cin написал(а):
Thanks Igor and Andrew for testing some more, GG was hoping to come up with a fast solution to get into the builds but unfortunately it is going to take a design change which needs a week to code and test. So he decided it is better to do the builds and leave in a "known bug" instead of create an unknown one. He says a workaround is to turn on/off "keyframes follow edits when this error could surface.
Yes ... this seems to work! Please add this to known issues for this release? Also, documentation (pdf) is not up-to-date for now (file modification from 9 aug 2020). May be wait few days or week before all this synced again? I'm not aware about any scripted automatic download/builders for CinGG outside your dev. machine ...
Sorry about this. It is mostly my fault as I have been unable to test this major mod for bump autos.
On Mon, Aug 31, 2020 at 6:57 AM Igor BEGHETTO via Cin < [email protected]> wrote:
Clear Keyframes (Shift+Del) do not delete the right keyframes. Maybe it's too late for the monthy release but a bug I found. I don't know if this bug is also in the last GIT release. 1. Create three (or more) Fade keyframes 2. Highlight an area to select one or more Fade keyframe 3. Hit Shift+Del shortcut or Keyframes-> Clear Keyframes 4. It delete the wrong keyframes and move others. (Note: Settings-> keyframes follow edits = checked)
Take a look the screencast at https://streamable.com/q58t37
Thanks! (Sorry for the late)
IgorBeg -- Cin mailing list [email protected] https://lists.cinelerra-gg.org/mailman/listinfo/cin
Andrew, thanks for the suggestions on the following. Please add this to known issues for this release?
I did add this to the releasenotes.pdf as it was too important to leave out.
Also, documentation (pdf) is not up-to-date for now (file modification from 9 aug 2020).
The manual is now updated on the website (includes Bump Autos and Selected Edits as added by Andrea). Somehow I missed email of Andrea's rework for the Advanced Editing chapter and MatN's review.
Clear Keyframes (Shift+Del) do not delete the right keyframes. Maybe it's too late for the monthy release but a bug I found. I don't know if this bug is also in the last GIT release. 1. Create three (or more) Fade keyframes 2. Highlight an area to select one or more Fade keyframe 3. Hit Shift+Del shortcut or Keyframes-> Clear Keyframes 4. It delete the wrong keyframes and move others. (Note: Settings-> keyframes follow edits = checked)
Take a look the screencast at https://streamable.com/q58t37
В сообщении от Thursday 03 September 2020 04:43:51 Phyllis Smith via Cin написал(а):
Andrew, thanks for the suggestions on the following.
Please add this to known issues for this release?
I did add this to the releasenotes.pdf as it was too important to leave out.
Also, documentation (pdf) is not up-to-date for now (file modification from 9 aug 2020).
The manual is now updated on the website (includes Bump Autos and Selected Edits as added by Andrea). Somehow I missed email of Andrea's rework for the Advanced Editing chapter and MatN's review.
Thanks A LOT for this - up-to-date documentatio definitely not easy task for fast-changing program! downloaded it already.
Clear Keyframes (Shift+Del) do not delete the right keyframes. Maybe it's too late for the monthy release but a bug I found. I don't know if this bug is also in the last GIT release. 1. Create three (or more) Fade keyframes 2. Highlight an area to select one or more Fade keyframe 3. Hit Shift+Del shortcut or Keyframes-> Clear Keyframes 4. It delete the wrong keyframes and move others. (Note: Settings-> keyframes follow edits = checked)
Take a look the screencast at https://streamable.com/q58t37
For my tests the "clear selected ketframes" problem is solved. There is the problem that subsequent edits are changed according to the range value, even if they are out of the range. Also it seems that the created interval remains the same length and does not adjust to the resizing of the edits. See the following movie (it is for download because it is too big to streamable): https://www.dropbox.com/s/z3na1r3vmwcnn6n/test.webm?dl=0
Andrew, For my tests the "clear selected ketframes" problem is solved.
There is the problem that subsequent edits are changed according to the range value, even if they are out of the range. Also it seems that the created interval remains the same length and does not adjust to the resizing of the edits. See the following movie (it is for download because it is too big to streamable):
https://www.dropbox.com/s/z3na1r3vmwcnn6n/test.webm?dl=0
Thanks for testing and the demo. A fix has been checked into GIT. It was a blunder -- missing "that"! void Auto::copy_from(Auto *that) {
*- this->orig_id = orig_id;+ this->orig_id = that->orig_id;* this->position = that->position;
Try the latest release. Sometimes it works well, other times it still gives the interval problems of yesterday. In case of errors, if you make an undo and repeat the interval changes, the second time it works fine! Instead, the problem of subsequent edits that varied even if not affected by the keyframes range is solved: now they remain intact.
Andrea, Thanks for the feedback. GG will test again and see if he can reproduce the problem. On Fri, Sep 4, 2020 at 3:32 PM Andrea paz via Cin < [email protected]> wrote:
Try the latest release. Sometimes it works well, other times it still gives the interval problems of yesterday. In case of errors, if you make an undo and repeat the interval changes, the second time it works fine! Instead, the problem of subsequent edits that varied even if not affected by the keyframes range is solved: now they remain intact. -- Cin mailing list [email protected] https://lists.cinelerra-gg.org/mailman/listinfo/cin
Andrea (I just noted that I spelled your name as Andrew the other day, sorry). Try it now with the latest changes. Not sure why we are having so many problems with this mod, but it is quite complicated. Thank you. On Fri, Sep 4, 2020 at 3:32 PM Andrea paz via Cin < [email protected]> wrote:
Try the latest release. Sometimes it works well, other times it still gives the interval problems of yesterday. In case of errors, if you make an undo and repeat the interval changes, the second time it works fine! Instead, the problem of subsequent edits that varied even if not affected by the keyframes range is solved: now they remain intact. -- Cin mailing list [email protected] https://lists.cinelerra-gg.org/mailman/listinfo/cin
The situation has improved, but I still noticed some problems: 1- If when creating an auto keyframes range, we have the "create curve type" already set to bump (because it remembers it from the previous time) and then we go directly to the "create keyframes" phase, the autos that are formed are not bump type. In this case we have to transform them manually via RMB and choose "bump". However, I noticed that this setting is not automatically transmitted to the corresponding autos in the other tracks. In short, "gang mode" does not work. This is very boring if we have a lot of tracks because we have to intervene manually on every single keyframe of the interval in the timeline. In any case, when we want to create a bump autos interval, just remember to click on "create curve type --> bump" even if it is already preset. This way, in my tests, it always works well. 2- If we create a bump autos interval and vary their value with the slider, everything works fine. However, if we change these values a second time (always with the slider), the problem returns that the created interval does not change according to the edits. Sometimes it works, sometimes it doesn't.
Andrea, 1- If when creating an auto keyframes range, we have the "create curve
type" already set to bump (because it remembers it from the previous time) and then we go directly to the "create keyframes" phase, the autos that are formed are not bump type. In this case we have to transform them manually via RMB and choose "bump". However, I noticed that this setting is not automatically transmitted to the corresponding autos in the other tracks. In short, "gang mode" does not work. This is very boring if we have a lot of tracks because we have to intervene manually on every single keyframe of the interval in the timeline. In any case, when we want to create a bump autos interval, just remember to click on "create curve type --> bump" even if it is already preset. This way, in my tests, it always works well.
So far we have been unable to reproduce the stated interval problem but I will continue to try tomorrow. Only the Speed auto needs a "gang mode" - the rest are irrelevant. GG is thinking about putting a checkbox on Speed to enable gang mode to avoid all of the extra work.
2- If we create a bump autos interval and vary their value with the slider, everything works fine. However, if we change these values a second time (always with the slider), the problem returns that the created interval does not change according to the edits. Sometimes it works, sometimes it doesn't.
I have not been able to create this either but will try again tomorrow.
Andrea_paz, I can confirm #1 POINT on Cin_20200831 release. Maybe in the last git it there isn't anymore. If it can help. Steps: a. open a project b. set type of curve: Menu-> keyframes-> CreateCurveType...-> Smooth c. close the project d. re-open the same projectwith File-> Load Recent...-> yourproject e. highligh an area with I-Beam on the timeline f. Menu-> keyframes-> Create keyframes...-> Speed You can see that Bump keyframes are screated instead of Smooth keyframes. #2 POINT, more complicated to explain but I can see that Speed has a bit of problems. Unfortunately I have little time to test in deep. Please, try to changing the Speed of a clip from 1.00 to 0.50 and then from 0.50 to 1.00 and reading the duration time at the bottom of the main window, before and after. (And see what happens to the keyframes when the speed changes from 1.00 to 0.50) Maybe this don't occur in the last git Cin release. I tested on Cin_20200831 release IgorBeg
No, don't waste your time. Only if others notice problems you can check; otherwise it is likely that it is my configuration or that I am wrong something. but I still noticed some problems:
1- If when creating an auto keyframes range, we have the "create curve type" already set to bump (because it remembers it from the previous time)... In any case, when we want to create a bump autos interval, just remember to click on "create curve type --> bump" even if it is already preset.
I made a Valgrind with the release "Sep 7 2020". I played a little with speed bump autos and Clear keyframes.
participants (4)
-
Andrea paz -
Andrew Randrianasulu -
Igor BEGHETTO -
Phyllis Smith