Chromakey improvements checked in to GIT
Chromakey plugin has had its menu improved by anonymous contribution and it has been checked into GIT. (Andrea, can you test it too? and check the manual to make sure still matches and make new image?) Improvements include: - added Default button - default values for Threshold and Slope changed from 60 to 10 and from 100 to 0 as much more practical - position of Threshold and Slope switched because Threshold is more relevant (Previous 2 items were suggested by Andrea) - textbox with arrows added for much easier access to current setting - individual "reset" icons added - location of "Use color picker" put into better position - other minor stuff
I compiled with ffmpeg 7 and patched for multi-bit. I also did a 12-bit rendering with x265. All OK.
I tried to start CinGG (ffmpeg7) in wayland. During startup I get this error: BC_DisplayInfo::gl_fb_config failed Error I don't have in Xorg. However, everything works normally. I've tried both X11 and X11-OpenGL driver, but I don't notice any difference. As a test I put in the chroma-key plugin and observed a strange behavior: now the threshold works from the value 40 instead of a value just above 0. Even going back into Xorg the same behavior remains. Why did it work correctly for me the first time and from the second test onwards the threshold seems to shift from 0 to 40? Anyway it is not important, I will do more tests but it is probably due to some mistake of mine. Instead, an important thing that I had noticed even before trying wayland, but forgot to report in the previous email is that the “Default” button returns the threshold to 10, as required. In contrast, the “Reset” button on the slider brings it back to 0. This difference can also be seen in chromakey.C : ChromaKeyConfig::ChromaKeyConfig() { reset(RESET_DEFAULT_SETTINGS); } void ChromaKeyConfig::reset(int clear) { switch(clear) { case RESET_ALL : red = 0.0; green = 0.0; blue = 0.0; threshold = 0.0; use_value = 0; slope = 0.0; break; case RESET_RGB : red = 0.0; green = 0.0; blue = 0.0; break; case RESET_SLOPE : slope = 0.0; break; case RESET_THRESHOLD : threshold = 0.0; break; case RESET_DEFAULT_SETTINGS : default: red = 0.0; green = 0.0; blue = 0.0; threshold = 10.0; use_value = 0; slope = 0.0; break; } } I think in each line that threshold appears the value should be raised to 10.0.
This is consistent behavior with other plugins. For example Sharpen, Linear Blur, Wave, Radial Blur.
Instead, an important thing that I had noticed even before trying wayland, but forgot to report in the previous email is that the “Default” button returns the threshold to 10, as required. In contrast, the “Reset” button on the slider brings it back to 0. This difference can also be seen in chromakey.C :
About CinGG in wayland as stated below. I think the error message is from the graphics library (gl_...) and is probably one of the startup screens that has gl commands that may be different now than before. Just a guess! On Tue, May 21, 2024 at 2:16 PM Andrea paz <[email protected]> wrote:
I tried to start CinGG (ffmpeg7) in wayland. During startup I get this error: BC_DisplayInfo::gl_fb_config failed Error I don't have in Xorg. However, everything works normally.
To add the explanation of the new keys and equalize the presentation to what was done for ChromaKey-HSV, I updated the manual for the ChromaKey plugin. You just need to replace the entry in Latex.
Thanks again to Andrea. I had to make a single change as my Latex got an error on: ($#ff000000$). I had to remove the 2 $ to solve it.
To add the explanation of the new keys and equalize the presentation to what was done for ChromaKey-HSV, I updated the manual for the ChromaKey plugin. You just need to replace the entry in Latex.
participants (2)
-
Andrea paz -
Phyllis Smith