Patches concerning the following have been checked into GIT: 1) libav version in About and on startup window 2) Copyright in About and on startup window for Cinelerra-CV and Cinelerra-GG (which includes Andrew-R by default in that group and I am not sure if the date of 2015 means that is when he started contributing mods for CinGG?? but anyway it is very much appreciated!) 3) selectable vaapi for multiple graphics hardware on single computer I have not tested other patches related to ffmpeg 5.1 and 6.0. On Sun, Aug 27, 2023 at 11:23 AM Andrew Randrianasulu < [email protected]> wrote:
f_acontrast seems to work on 5.1 with those patches too ...
пн, 28 авг. 2023 г., 20:52 Phyllis Smith <[email protected]>:
Patches concerning the following have been checked into GIT: 1) libav version in About and on startup window 2) Copyright in About and on startup window for Cinelerra-CV and Cinelerra-GG (which includes Andrew-R by default in that group and I am not sure if the date of 2015 means that is when he started contributing mods for CinGG?? but anyway it is very much appreciated!)
Well, I was thinking about date when cingg went public. I definitely started to compile-test later and contribute around 2019 or so .... https://lists.cinelerra-cv.org/pipermail/cinelerra/2016q1/003774.html Announce of 5.0 / call for joint effort 22 jan 2016 https://lists.cinelerra-cv.org/pipermail/cinelerra/2018q4/010522.html me appears ... may be 2016 will be more accurate start date. 3) selectable vaapi for multiple graphics hardware on single computer
I have not tested other patches related to ffmpeg 5.1 and 6.0.
To be honest I hope libtiff build patches, ffmpeg-5.1.patch999 and ffmpeg filters build fix for new ffmpeg will find their way in, because they fix build breakage on Andrea's updated Arch. My "early quit from filetiff/filetga/filepng" patches might wait for more testing (notably I hope they does not leak file descriptors or such, I only tested on short, less than minute video). On further plans ... May be if ffmpeg 6.1 fails to materialize in first half of september we will go with 6.0, preparing new plugin info and such? So far ffmpeg.git was not worse than 5.1 for me but seeking in mkv might be different (it was different in MPlayer). Other updates might include x265 git (aarch64 stuff, build warning with new nasm fixed), libjpeg-turbo 3.0.0/3.0.1, libtiff 4.5.1, removal of openjpeg (ffmpeg.git removed support for it, and we does not use it directly), adding lcms2 lib so ffmpeg can use it ... Also, I wonder if optipng run over our icons (or even pngquant, at least on those we have svg source for) might be useful? Standard set of icons weight nearly 8mb and stuffed directly into executable .... But this is just reminder about ideas I have, my vision and visual taste not good enough for saying definitively about icon quality before/after. Thanks!
On Sun, Aug 27, 2023 at 11:23 AM Andrew Randrianasulu < [email protected]> wrote:
f_acontrast seems to work on 5.1 with those patches too ...
To be honest I hope libtiff build patches, ffmpeg-5.1.patch999 and ffmpeg filters build fix for new ffmpeg will find their way in, because they fix build breakage on Andrea's updated Arch.
The compile for these patches works but I have not done any testing yet. Since Andrea has tested successfully, I still would feel more comfortable if I could also.
My "early quit from filetiff/filetga/filepng" patches might wait for more testing (notably I hope they does not leak file descriptors or such, I only tested on short, less than minute video).
On further plans ... May be if ffmpeg 6.1 fails to materialize in first half of september we will go with 6.0, preparing new plugin info and such? So far ffmpeg.git was not worse than 5.1 for me but seeking in mkv might be different (it was different in MPlayer).
Other updates might include x265 git (aarch64 stuff, build warning with new nasm fixed), libjpeg-turbo 3.0.0/3.0.1, libtiff 4.5.1, removal of openjpeg (ffmpeg.git removed support for it, and we does not use it directly), adding lcms2 lib so ffmpeg can use it ...
Also, I wonder if optipng run over our icons (or even pngquant, at least on those we have svg source for) might be useful? Standard set of icons weight nearly 8mb and stuffed directly into executable ....
But this is just reminder about ideas I have, my vision and visual taste not good enough for saying definitively about icon quality before/after.
Will comment on the rest of this later.
To be honest I hope libtiff build patches, ffmpeg-5.1.patch999 and ffmpeg filters build fix for new ffmpeg will find their way in, because they fix build breakage on Andrea's updated Arch.
Andrew, I need clarification. What do you mean by the above "ffmpeg filters build fix for new ffmpeg"? are you referring to 0002-Fix-build-in-pluginfclient.C-with-ffmpeg-6.0.patch ? I have done a basic look at it and applied it to current ffmpeg-5.1 already rather than 6.0. Is that OK? as it "looks" acceptable to me. Still checking libtiff build patches. My "early quit from filetiff/filetga/filepng" patches might wait for more
testing (notably I hope they does not leak file descriptors or such, I only tested on short, less than minute video).
On further plans ... May be if ffmpeg 6.1 fails to materialize in first half of september we will go with 6.0, preparing new plugin info and such? So far ffmpeg.git was not worse than 5.1 for me but seeking in mkv might be different (it was different in MPlayer).
Other updates might include x265 git (aarch64 stuff, build warning with new nasm fixed), libjpeg-turbo 3.0.0/3.0.1, libtiff 4.5.1, removal of openjpeg (ffmpeg.git removed support for it, and we does not use it directly), adding lcms2 lib so ffmpeg can use it ...
Also, I wonder if optipng run over our icons (or even pngquant, at least on those we have svg source for) might be useful? Standard set of icons weight nearly 8mb and stuffed directly into executable ....
But this is just reminder about ideas I have, my vision and visual taste not good enough for saying definitively about icon quality before/after.
Thanks!
On Sun, Aug 27, 2023 at 11:23 AM Andrew Randrianasulu < [email protected]> wrote:
f_acontrast seems to work on 5.1 with those patches too ...
вт, 29 авг. 2023 г., 06:23 Phyllis Smith <[email protected]>:
To be honest I hope libtiff build patches, ffmpeg-5.1.patch999 and ffmpeg filters build fix for new ffmpeg will find their way in, because they fix build breakage on Andrea's updated Arch.
Andrew, I need clarification. What do you mean by the above "ffmpeg filters build fix for new ffmpeg"? are you referring to 0002-Fix-build-in-pluginfclient.C-with-ffmpeg-6.0.patch ?
yes, I tried to make it work for both 5.1 and 6.0+ I have done a basic look at it and applied it to current ffmpeg-5.1
already rather than 6.0. Is that OK? as it "looks" acceptable to me.
As long as ffmpeg's audio filters work as before.... I only tested one!
Still checking libtiff build patches.
My "early quit from filetiff/filetga/filepng" patches might wait for more
testing (notably I hope they does not leak file descriptors or such, I only tested on short, less than minute video).
On further plans ... May be if ffmpeg 6.1 fails to materialize in first half of september we will go with 6.0, preparing new plugin info and such? So far ffmpeg.git was not worse than 5.1 for me but seeking in mkv might be different (it was different in MPlayer).
Other updates might include x265 git (aarch64 stuff, build warning with new nasm fixed), libjpeg-turbo 3.0.0/3.0.1, libtiff 4.5.1, removal of openjpeg (ffmpeg.git removed support for it, and we does not use it directly), adding lcms2 lib so ffmpeg can use it ...
Also, I wonder if optipng run over our icons (or even pngquant, at least on those we have svg source for) might be useful? Standard set of icons weight nearly 8mb and stuffed directly into executable ....
But this is just reminder about ideas I have, my vision and visual taste not good enough for saying definitively about icon quality before/after.
Thanks!
On Sun, Aug 27, 2023 at 11:23 AM Andrew Randrianasulu < [email protected]> wrote:
f_acontrast seems to work on 5.1 with those patches too ...
Andrew, I "believe" I have the whole heap checked into GIT. Please verify at your convenience (as long as it is before the morning of the 31st !! smiley face). I played a few different audio tracks. This last GIT checkin included: 0002-Fix-build-in-pluginfclient.C-with-ffmpeg-6.0.patch 0008-Possible-fix-internal-ffmpeg-5.1-build-with-binutils.patch My understanding is that ffmpeg-5.1.patch999 is already part of ffmpeg-6.0 so does not have to be carried -- I looked at the 6.0 mathops.h and it appears to be there. If I am wrong, please let me know. On Sun, Aug 27, 2023 at 11:23 AM Andrew Randrianasulu < [email protected]> wrote:
f_acontrast seems to work on 5.1 with those patches too ...
вт, 29 авг. 2023 г., 21:48 Phyllis Smith <[email protected]>:
Oh, and does this have to be backed out when we actually upgrade to ffmpeg 6.0/6.1 ?? I am confused by the patches name including 6.0 in it.
0002-Fix-build-in-pluginfclient.C-with-ffmpeg-6.0.patch
no, it fix build with 6.0+.
вт, 29 авг. 2023 г., 21:41 Phyllis Smith <[email protected]>:
Andrew, I "believe" I have the whole heap checked into GIT. Please verify at your convenience (as long as it is before the morning of the 31st !! smiley face). I played a few different audio tracks. This last GIT checkin included:
0002-Fix-build-in-pluginfclient.C-with-ffmpeg-6.0.patch 0008-Possible-fix-internal-ffmpeg-5.1-build-with-binutils.patch
My understanding is that ffmpeg-5.1.patch999 is already part of ffmpeg-6.0 so does not have to be carried -- I looked at the 6.0 mathops.h and it appears to be there. If I am wrong, please let me know.
But our 5.1 still not buildable on new binutils without it.. so I guess it better to be included, even if it will short-lived until we upgrade our internal ffmpeg copy ....
On Sun, Aug 27, 2023 at 11:23 AM Andrew Randrianasulu < [email protected]> wrote:
f_acontrast seems to work on 5.1 with those patches too ...
вт, 29 авг. 2023 г., 21:41 Phyllis Smith <[email protected]>:
Andrew, I "believe" I have the whole heap checked into GIT. Please verify at your convenience (as long as it is before the morning of the 31st !! smiley face). I played a few different audio tracks. This last GIT checkin included:
0002-Fix-build-in-pluginfclient.C-with-ffmpeg-6.0.patch 0008-Possible-fix-internal-ffmpeg-5.1-build-with-binutils.patch
so, patches are in, thanks, but then complete fix for Arch (and termux) also includes thirdparty/Makefile changes around libtiff and libjpeg-turbo support inside it .... can you run those on older distro just in case? "Disable libjpeg support in libtiff, fix build" "Fix libtiff to link with local libjpeg-turbo, reenable libjpeg there"
My understanding is that ffmpeg-5.1.patch999 is already part of ffmpeg-6.0 so does not have to be carried -- I looked at the 6.0 mathops.h and it appears to be there. If I am wrong, please let me know.
On Sun, Aug 27, 2023 at 11:23 AM Andrew Randrianasulu < [email protected]> wrote:
f_acontrast seems to work on 5.1 with those patches too ...
Will try to compile now in ubuntu 16 and then debian 32-bit. Not sure how much testing I will be able to actually do though because tomorrow is a "lost day".
so, patches are in, thanks, but then complete fix for Arch (and termux) also includes thirdparty/Makefile changes around libtiff and libjpeg-turbo support inside it .... can you run those on older distro just in case?
"Disable libjpeg support in libtiff, fix build"
"Fix libtiff to link with local libjpeg-turbo, reenable libjpeg there"
My understanding is that ffmpeg-5.1.patch999 is already part of ffmpeg-6.0 so does not have to be carried -- I looked at the 6.0 mathops.h and it appears to be there. If I am wrong, please let me know.
On Sun, Aug 27, 2023 at 11:23 AM Andrew Randrianasulu < [email protected]> wrote:
f_acontrast seems to work on 5.1 with those patches too ...
вт, 29 авг. 2023 г., 23:49 Phyllis Smith <[email protected]>:
Will try to compile now in ubuntu 16 and then debian 32-bit. Not sure how much testing I will be able to actually do though because tomorrow is a "lost day".
Its time to me to power up desktop, then :) sorry for late patches, I was not expecting breakage in this specific area!
so, patches are in, thanks, but then complete fix for Arch (and termux) also includes thirdparty/Makefile changes around libtiff and libjpeg-turbo support inside it .... can you run those on older distro just in case?
"Disable libjpeg support in libtiff, fix build"
"Fix libtiff to link with local libjpeg-turbo, reenable libjpeg there"
My understanding is that ffmpeg-5.1.patch999 is already part of ffmpeg-6.0 so does not have to be carried -- I looked at the 6.0 mathops.h and it appears to be there. If I am wrong, please let me know.
On Sun, Aug 27, 2023 at 11:23 AM Andrew Randrianasulu < [email protected]> wrote:
f_acontrast seems to work on 5.1 with those patches too ...
Built on ubuntu 16 just fine and the only testing I did, was to render the video each with TIFF sequence, TGA, and JPEG (I guess I forgot to do PNG). BUT Debian 9 32-bit fails and not sure which patches caused the failure. Below is end of log and I will send just to you the whole log and I am looking at it also, but you may be faster. cc1: warning: unrecognized command line option ‘-Wno-stringop-truncation’ cc1: warning: unrecognized command line option ‘-Wno-format-overflow’ cc1: warning: unrecognized command line option ‘-Wno-format-truncation’ cc1: warning: unrecognized command line option ‘-Wno-stringop-overflow’ make[2]: Leaving directory '/tmp/cinelerra-5.1_testing/cinelerra-5.1/mpeg2enc' Makefile:583: recipe for target 'all-recursive' failed make[1]: *** [all-recursive] Error 1 make[1]: Leaving directory '/tmp/cinelerra-5.1_testing/cinelerra-5.1' Makefile:530: recipe for target 'all' failed On Tue, Aug 29, 2023 at 2:52 PM Andrew Randrianasulu < [email protected]> wrote:
вт, 29 авг. 2023 г., 23:49 Phyllis Smith <[email protected]>:
Will try to compile now in ubuntu 16 and then debian 32-bit. Not sure how much testing I will be able to actually do though because tomorrow is a "lost day".
Its time to me to power up desktop, then :)
sorry for late patches, I was not expecting breakage in this specific area!
so, patches are in, thanks, but then complete fix for Arch (and termux) also includes thirdparty/Makefile changes around libtiff and libjpeg-turbo support inside it .... can you run those on older distro just in case?
"Disable libjpeg support in libtiff, fix build"
"Fix libtiff to link with local libjpeg-turbo, reenable libjpeg there"
My understanding is that ffmpeg-5.1.patch999 is already part of ffmpeg-6.0 so does not have to be carried -- I looked at the 6.0 mathops.h and it appears to be there. If I am wrong, please let me know.
On Sun, Aug 27, 2023 at 11:23 AM Andrew Randrianasulu < [email protected]> wrote:
f_acontrast seems to work on 5.1 with those patches too ...
Andrew, PLEASE check my GIT checkin carefully. I completed the rest of the Arch/termux requirements and successfully built on Ubuntu 16 and Debian 9 32-bit (after a lot of mistakes on me). Rendered PNG sequence on Debian for a test but not a very thorough checkout. Patches applied were: 0001-Disable-libjpeg-support-in-libtiff-fix-build.patch 0002-Fix-libtiff-to-link-with-local-libjpeg-turbo-reenabl.patch 0001-Try-to-return-early-if-libtiff-libpng-does-not-recog.patch 0002-Add-check-return-for-filetga-reading-check-bpp-retur.patch On Tue, Aug 29, 2023 at 2:09 PM Andrew Randrianasulu < [email protected]> wrote:
вт, 29 авг. 2023 г., 21:41 Phyllis Smith <[email protected]>:
Andrew, I "believe" I have the whole heap checked into GIT. Please verify at your convenience (as long as it is before the morning of the 31st !! smiley face). I played a few different audio tracks. This last GIT checkin included:
0002-Fix-build-in-pluginfclient.C-with-ffmpeg-6.0.patch 0008-Possible-fix-internal-ffmpeg-5.1-build-with-binutils.patch
so, patches are in, thanks, but then complete fix for Arch (and termux) also includes thirdparty/Makefile changes around libtiff and libjpeg-turbo support inside it .... can you run those on older distro just in case?
"Disable libjpeg support in libtiff, fix build"
"Fix libtiff to link with local libjpeg-turbo, reenable libjpeg there"
My understanding is that ffmpeg-5.1.patch999 is already part of ffmpeg-6.0 so does not have to be carried -- I looked at the 6.0 mathops.h and it appears to be there. If I am wrong, please let me know.
On Sun, Aug 27, 2023 at 11:23 AM Andrew Randrianasulu < [email protected]> wrote:
f_acontrast seems to work on 5.1 with those patches too ...
participants (2)
-
Andrew Randrianasulu -
Phyllis Smith