Fix for crash on non-existent cms profile, x265 i586 compile fix
Andrea, you were right In my chroot launching cin with cms enabled and pointing CIN_CM_PROFILE at non-existent profile created crash! I think I fixed this one by only applying transform if it was created successfully. Please retest and provide full terminal output I also tested my x265 4.2 patch for compiling on i586 on x86-64 where it seems to work? Attached whole series I have applied at the moment git format-patch -o /dev/shm/x265_upd_2 5d80a9c9723f618b135b5721d5b413198cb442e4 /dev/shm/x265_upd_2/0001-Add-two-patches-for-decoding-hevc-alpha.patch /dev/shm/x265_upd_2/0002-Add-combined-hevc-alpha-decoding-patch.patch /dev/shm/x265_upd_2/0003-Add-simple-hevc-alpha-encode-profile-with-hvc1-tag.patch /dev/shm/x265_upd_2/0004-Fix-h265_alpha-profile.patch /dev/shm/x265_upd_2/0005-Guard-against-failed-hTransform-in-newly-added-cms-c.patch /dev/shm/x265_upd_2/0006-Fix-x265-4.2-build-on-i586.patch
With your new patches, I'm not experiencing any crashes, and the terminal displays the “cms!” message, confirming that it's working. Thank you. It also works when I use my own monitor color profile instead of the generic “sRGB.icc” and “WideGamautRGB.icc” files. Here's an example of the terminal output using my profile (Dell_1886_LUT_4.icc): $ CIN_CM_PROFILE="/usr/share/color/icc/colord/Dell_1886_LUT_4.icc" /home/paz/cinelerra/cinelerra-5.1/bin/cin /home/paz/wide-gamut-tests/P3-sRGB-color-ring.jpg /home/paz/wide-gamut-tests/R2020-P3-color-bars.jpg Cinelerra Infinity - built: May 16 2026 10:19:56 git://git.cinelerra-gg.org/goodguy/cinelerra.git (c) 2006-2019 Heroine Virtual Ltd. by Adam Williams 2007-2020 mods for Cinelerra-GG by W.P.Morrow aka goodguy 2003-2017 mods for Cinelerra-CV by CinelerraCV team 2015-2026 mods for Cinelerra-GG by Cinelerra-GG team Libav version: Lavc62.28.100 Cinelerra is free software, covered by the GNU General Public License, and you are welcome to change it and/or distribute copies of it under certain conditions. There is absolutely no warranty for Cinelerra. BC_DisplayInfo::gl_fb_config failed Decoder mjpeg does not support device type vulkan. HW device init failed, using SW decode. file:/home/paz/wide-gamut-tests/R2020-P3-color-bars.jpg err: Operation not permitted Decoder mjpeg does not support device type vulkan. HW device init failed, using SW decode. file:/home/paz/wide-gamut-tests/P3-sRGB-color-ring.jpg err: Operation not permitted Decoder mjpeg does not support device type vulkan. HW device init failed, using SW decode. file:/home/paz/wide-gamut-tests/R2020-P3-color-bars.jpg err: Operation not permitted cms! Decoder mjpeg does not support device type vulkan. HW device init failed, using SW decode. file:/home/paz/wide-gamut-tests/P3-sRGB-color-ring.jpg err: Operation not permitted cms! Decoder mjpeg does not support device type vulkan. HW device init failed, using SW decode. file:/home/paz/wide-gamut-tests/R2020-P3-color-bars.jpg err: Operation not permitted cms! Decoder mjpeg does not support device type vulkan. HW device init failed, using SW decode. file:/home/paz/wide-gamut-tests/P3-sRGB-color-ring.jpg err: Operation not permitted cms! Decoder mjpeg does not support device type vulkan. HW device init failed, using SW decode. file:/home/paz/wide-gamut-tests/R2020-P3-color-bars.jpg err: Operation not permitted cms! Decoder mjpeg does not support device type vulkan. HW device init failed, using SW decode. file:/home/paz/wide-gamut-tests/P3-sRGB-color-ring.jpg err: Operation not permitted cms! If you need the terminal with “loglevel=debug,” let me know. CinGG also works when started from the KDE launcher—which was one of the things I suspected was causing the issue... To include these features in the manual, I’d like to ask a few questions to clear up some doubts, but I’ll post them in a separate thread.
participants (2)
-
Andrea paz -
Andrew Randrianasulu