вт, 4 апр. 2023 г., 19:15 Phyllis Smith <[email protected]>:
Thanks Andrew -- I fixed the GIT checkin just now. The 4 bandages on my fingers are causing a lot of typing errors and I need 1 more bandage too.
:( What happened?
according to this you just named files 264-something, not x264-something
so ffmpeg build fail .... because it can't find x264
but I have more problems wit mjpegtools due to clang-16 defaulting to c++17 and libuuid also complains about flock function
Are these new problems due to the March library upgrades or previous patches?
no, just termux is rolling distro, and it just managed to roll over such landmine as clang-16 ...
====
../utils/fastintfns.h:5:27: error: ISO C++17 does not allow 'register' storage class specifier [-Wregister] static inline int intmax( register int x, register int y ) ^~~~~~~~~ ../utils/fastintfns.h:5:43: error: ISO C++17 does not allow 'register' storage class specifier [-Wregister]
static inline int intmax( register int x, register int y )
^~~~~~~~~ ../utils/fastintfns.h:10:27: error: ISO C++17 does not allow 'register' storage class specifier [-Wregister] static inline int intmin( register int x, register int y ) ^~~~~~~~~ ../utils/fastintfns.h:10:43: error: ISO C++17 does not allow 'register' storage class specifier [-Wregister] static inline int intmin( register int x, register int y ) ^~~~~~~~~ In file included from ratectl.cc:57: ../utils/fastintfns.h:5:27: error: ISO C++17 does not allow 'register' storage class specifier [-Wregister] static inline int intmax( register int x, register int y ) ^~~~~~~~~ ../utils/fastintfns.h:5:43: error: ISO C++17 does not allow 'register' storage class specifier [-Wregister]
static inline int intmax( register int x, register int y )
^~~~~~~~~ ../utils/fastintfns.h:10:27: error: ISO C++17 does not allow 'register' storage class specifier [-Wregister] static inline int intmin( register int x, register int y ) ^~~~~~~~~ ../utils/fastintfns.h:10:43: error: ISO C++17 does not allow 'register' storage class specifier [-Wregister] static inline int intmin( register int x, register int y )
====
gen_uuid.c:297:10: error: call to undeclared function 'flock'; ISO C99 and later do not support implicit function declarations [-Wimplicit-function-declaration] while (flock(state_fd, LOCK_EX) < 0) { ^ gen_uuid.c:297:10: note: did you mean 'clock'? /data/data/com.termux/files/usr/include/time.h:96:9: note: 'clock' declared here clock_t clock(void); ^
gen_uuid.c:369:3: error: call to undeclared function 'flock'; ISO C99 and later do not support implicit function declarations [-Wimplicit-function-declaration] flock(state_fd, LOCK_UN); ^ 2 errors generated.
====
I am trying to apply netbsd patch to it, but no success so far
вт, 4 апр. 2023 г., 01:03 Phyllis Smith <[email protected]>:
Tested an upgraded x264 stable version (r3106) with CinGG and checked into GIT. Hopefully, Andrea has time to test a little too. ...Phyllis
[...] Andrea has time to test a little too. Performed various tests and renderings: all OK. Thank you.
PS: I propose a very small change to the "prores_ks.pro" preset. The addition of the "vendor=apl0" option is to make the various programs believe that it was rendered with the official Adobe engine. I don't see any difference, however I propose to leave it in this preset anyway in case some people might find it useful and solve some compatibility issues. I attach the preset.
Andrea, maybe a comment should be added instead to prores_ks.pro? Because when I tested 2 different rendered files although playing them looked the same, I used "vfy" to compare the output from existing prores_ks versus with the "vemdor=ap10" and internally something is different. And when I do a "mediainfo" on existing, I get "Writing library lavc" (which I believe means libavcodec and is open source) and on the changed one, I get "Writing library Apple". Sounds like a really good idea to put it in the preset so users are aware of its existence as a comment but not sure if that would be controversial to Apple. What do you think?
PS: I propose a very small change to the "prores_ks.pro" preset. The addition of the "vendor=apl0" option is to make the various programs believe that it was rendered with the official Adobe engine. I don't see any difference, however I propose to leave it in this preset anyway in case some people might find it useful and solve some compatibility issues. I attach the preset.
participants (3)
-
Andrea paz -
Andrew Randrianasulu -
Phyllis Smith