[Cin] Debate on batch render

[Phyllis Smith]

Thanks.  I hope to have time to look at this tomorrow.

On Fri, Jan 8, 2021 at 8:32 PM Andrew Randrianasulu via Cin <
cin at lists.cinelerra-gg.org> wrote:

> В сообщении от Wednesday 06 January 2021 02:02:27 Rafa Mar Multimedia en
> Gnu\Linux via Cin написал(а):
> > Thank you very much Andrew Randrianasulu and Phyllis, for your interest
> in
> > improving this tool. I think that with these changes we eliminate a very
> > dangerous option and another problematic that does not have much logic
> in a
> > batch render window. And we greatly improve this wizard.
> > I wouldn't know how to do this. I guess it's not going to be a problem
> for
> > a person who understands the C language.
>
>
> igor_ubuntu ( Igor Vladimirsky) actually explained this function to
> russian-speaking users in
>
>
> https://linuxvideoediting.blogspot.com/2021/01/save-edl-path-use-current-edl-in-cinelerra-gg.html
>
> So, it seems this quite dangerous option exist for reason.
>
> I added few tooltips based on suggestions from this article, see patch
>
> ---
> diff --git a/cinelerra-5.1/cinelerra/batchrender.C
> b/cinelerra-5.1/cinelerra/batchrender.C
> index 6dcdbc62..81d47f6e 100644
> --- a/cinelerra-5.1/cinelerra/batchrender.C
> +++ b/cinelerra-5.1/cinelerra/batchrender.C
> @@ -1044,6 +1044,8 @@ BatchRenderNew::BatchRenderNew(BatchRenderThread
> *thread,
>   : BC_GenericButton(x, y, _("New"))
>  {
>         this->thread = thread;
> +       set_tooltip(_("Create a new batch"));
> +
>  }
>
>  int BatchRenderNew::handle_event()
> @@ -1056,6 +1058,8 @@
> BatchRenderDelete::BatchRenderDelete(BatchRenderThread *thread, int x, int
> y)
>   : BC_GenericButton(x, y, _("Delete"))
>  {
>         this->thread = thread;
> +       set_tooltip(_("Delete loaded (highlighted) batch"));
> +
>  }
>
>  int BatchRenderDelete::handle_event()
> @@ -1242,6 +1246,8 @@
> BatchRenderUpdateEDL::BatchRenderUpdateEDL(BatchRenderThread *thread,
>   : BC_GenericButton(x, y, _("Save to EDL Path"))
>  {
>         this->thread = thread;
> +       set_tooltip(_("Save to loaded EDL (highlighted), will *overwrite*
> nighlighted proj!"));
> +
>  }
>
>  int BatchRenderUpdateEDL::handle_event()
>
> ---
>
> But apparently 'warn if proj/session mismatch' doesn't work as intended,
> I'll try to look into it but no promise of solution.
>
> I also slightly updated russian translation because long russian sentence
> about # of
> CPU used by plugins was stomping away text in Use HW acceleration dropdown
> list!
>
>
> ---
> diff --git a/cinelerra-5.1/po/ru.po b/cinelerra-5.1/po/ru.po
> index 82f76a24..60f34ccb 100644
> --- a/cinelerra-5.1/po/ru.po
> +++ b/cinelerra-5.1/po/ru.po
> @@ -8579,7 +8579,7 @@ msgstr "Секунд предрендеринга:"
>
>  #: cinelerra/performanceprefs.C:98
>  msgid "Project SMP cpus:"
> -msgstr "Количество CPU (SMP), используемых плагинами:"
> +msgstr "Кол-во CPU (SMP), исп. плагинами:"
>
>  #: cinelerra/performanceprefs.C:113
>  msgid "Background Rendering (Video only)"
>
> ===
>
> in this case be aware about enconding (po file must stay in utf8)
>
> Hm, still does not work?? Strange .. may be it was locale-sensitive,
> so saved value was not matching english strings ....
>
> You might apply it anyway, I think some more ru translation
> work will be needed due to all those added strings
> (a bit afraid to do it due to possibility of breackage - but there is no
> other way!)
>
>
> >
> > El mar, 5 ene 2021 a las 21:22, Phyllis Smith via Cin (<
> > cin at lists.cinelerra-gg.org>) escribió:
> >
> > > Andrew,
> > > Thanks for looking at this.  After I finish testing SGE's BT #538 html
> > > improvements, I will at least try your suggestions and I plan to
> update the
> > > manual to clarify simple usage of Batch Render.
> > >
> > > Right now I can only suggest you to look at
> > >>
> > >>
> > >>
> https://git.cinelerra-gg.org/git/?p=goodguy/cinelerra.git;a=blob;f=cinelerra-5.1/cinelerra/batchrender.C;h=6dcdbc62f69fd7bf8fcd0015f011de87b2e93786;hb=HEAD
> > >>
> > >> ...
> > >> basically try to comment out action:
> > >>
> > >> // thread->update_selected_edl();
> > >>
> > >> put two "/" before this line, and recompile.
> > >>
> > >> ...
> > >> May be it has something to do with internal use of batch render, for
> > >> DVD/BD creation ?
> > >>
> > >> YES !! I think I remember that it was implemented to facilitate DVD/BD
> > > creation because there was much debugging involved that was tedious.
> > > There are *about 250,000 lines of intertwined program code* in
> > > Cinelerra-GG proper and rewriting code is not like rewriting a book's
> > > paragraph - it is generally non-trivial and requires more than just
> > > knowledge of C++.
> > > --
> > > Cin mailing list
> > > Cin at lists.cinelerra-gg.org
> > > https://lists.cinelerra-gg.org/mailman/listinfo/cin
> > >
> >
>
>
> --
> Cin mailing list
> Cin at lists.cinelerra-gg.org
> https://lists.cinelerra-gg.org/mailman/listinfo/cin
>
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <https://lists.cinelerra-gg.org/pipermail/cin/attachments/20210108/427fb83f/attachment.htm>