[Cin] 'Warn on version mismatch' historical research ...

[Andrew Randrianasulu]

It seems  this flag was introduced in this  commit:

https://git.cinelerra-gg.org/git/?p=goodguy/history.git;a=commit;h=9e779f63289f91f132569a933ddc93f4c1487751
author  Good Guy <good1.2guy at gmail.com>
  Wed, 7 Sep 2016 01:18:17 +0300 (16:18 -0600)
  committer  Good Guy <good1.2guy at gmail.com>
  Wed, 7 Sep 2016 01:18:17 +0300 (16:18 -0600)

rework svg plugin, fast flash flush, init resize pixmaps, test edl version

so, it was testing version in mwindow.C 

https://git.cinelerra-gg.org/git/?p=goodguy/history.git;a=blobdiff;f=cinelerra-5.1/cinelerra/mwindow.C;h=15b29e5c4ce1d06b5b1bfbd89e34bf89f69e0df0;hp=27e0917ec7eabe59d3782ee1f8c5973d9e62fd2d;hb=9e779f63289f91f132569a933ddc93f4c1487751;hpb=5a7faba81bcd03755bfe651bacbc5980171fe9de

(sorry for ultralong line)

-
+                               const char *cin_version = 0;
+                               while( !xml_file.read_tag() ) {
+                                       if( xml_file.tag.title_is("EDL") ) {
+                                               cin_version = xml_file.tag.get_property("VERSION");
+                                               break;
+                                       }
+                               }
+                               xml_file.rewind();
+                               if( !cin_version ) {
+                                       eprintf(_("XML file %s\n not from cinelerra."),filenames->get(i));
+                                       char string[BCTEXTLEN];
+                                       sprintf(string,_("Unknown %s"), filenames->get(i));
+                                       gui->show_message(string);
+                                       result = 1;
+                                       break;
+                               }
+                               if( strcmp(cin_version, CINELERRA_VERSION) ) {
+                                       char string[BCTEXTLEN];
+                                       snprintf(string, sizeof(string),
+                                                _("Warning: XML from cinelerra version %s\n"
+                                               "Session data may be incompatible."), cin_version);
+                                       show_warning(&preferences->warn_version, string);
+                               }

hm ...

in current we have ....

https://git.cinelerra-gg.org/git/?p=goodguy/cinelerra.git;a=blob;f=cinelerra-5.1/cinelerra/mwindow.C;h=04549fdedc984278e8ac6a5dfc8176c1fe7ba69b;hb=HEAD

2196                         const char *cin_version = 0;
2197                         while( !xml_file.read_tag() ) {
2198                                 if( xml_file.tag.title_is("EDL") ) {
2199                                         cin_version = xml_file.tag.get_property("VERSION");
2200                                         break;
2201                                 }
2202                         }
2203                         xml_file.rewind();
2204                         if( !cin_version ) {
2205                                 eprintf(_("XML file %s\n not from cinelerra."),filename);
2206                                 char string[BCTEXTLEN];
2207                                 sprintf(string,_("Unknown %s"), filename);
2208                                 gui->show_message(string);
2209                                 break;
2210                         }
2211                         if( strcmp(cin_version, CINELERRA_VERSION) &&
2212                             strcmp(cin_version, "Unify") &&
2213                             strcmp(cin_version, "5.1") ) {
2214                                 eprintf(_("Warning: XML from cinelerra version %s\n"
2215                                         "Session data may be incompatible."), cin_version);
2216                         }

so, IT SEEMS this preference simply unused now?

Should we try to repair it, or just remove this warning checkbox altogether? 
(or possible replace it with 'unsafe_button_in_batchrender' preference?)

I think replacing eprintf with show_warning still will do work, but need to check!