[Cin] [PATCH] UnsafeGUI toggle, tooltips, file overwrite warning for batchrender.c

Mon Jan 18 15:20:26 CET 2021

Sorry Andrew, I did not test the warning, but I have tried these simple
changes indicated above, I have completely uninstalled Cinelerra again,
compiled with these changes, and now it works perfectly from the first
time. It is as simple as setting these 1s to 0 and the problem is solved
and we can end this matter.

I really liked the warning window not to overwrite and the tooltip with the
warning.

Congratulations Andrew, great job. When the Cinelerra update is carried
out, I will do a tutorial on batchrender and I will quote you in the thanks
because your good work deserves it. We now have an ideal window for new
users and much more secure for veterans.

El lun, 18 ene 2021 a las 15:06, Rafa Mar Multimedia en Gnu\Linux (<
rafamar.mm.ig at gmail.com>) escribió:

> Sorry, my friend has rechecked the file and recommends these two changes
> to avoid the well-known error.
> diff PATH / cinelerra / batchrender.C
> @@ 200
> -     warn = 1;
> +    warn = 0;
> @@ 272
> -     warn = file.tag.get_property ("WARN", 1);
> +    warn = file.tag.get_property ("WARN", 0);
>
> In this way, the wizard will always start for a new user with this option
> deactivated. If you activate the option from the preferences, when you open
> the wizard this option will remain deactivated, but if you activate it,
> Cinelerra will remember this at the next start.
>
> I have tried it and it works perfect.
>
> El lun, 18 ene 2021 a las 13:28, Rafa Mar Multimedia en Gnu\Linux (<
> rafamar.mm.ig at gmail.com>) escribió:
>
>> I sent the new batchrender.C file to my friend to tell me where to change
>> this number and he answered this, saying that you would understand.
>>
>> diff PATH/cinelerra/batchrender.C
>> @@ 200
>> -       warn = 1;
>> +      warn = 0;
>>
>> I have gone to line 200 of the file and I have changed it, recompiled and
>> now it no longer gives the aforementioned error.
>>
>> With this small change, the assistant is working perfectly from its first
>> use.
>>
>> El lun, 18 ene 2021 a las 13:03, Rafa Mar Multimedia en Gnu\Linux (<
>> rafamar.mm.ig at gmail.com>) escribió:
>>
>>> [image: imagen.png]
>>> This will be what new users will find, the error that some have already
>>> reported as a bug.
>>>
>>> I have completely deleted Cinelerra, I have done an installation from
>>> the last git, I have deleted the .bcast5 folder, I have started Cinelerra
>>> and tried to do a batch render.
>>>
>>> Precisely for this reason my friend stressed that it was important that
>>> this option was disabled by default, it was only to change a 1 to a 0. If I
>>> remember correctly ...
>>>
>>> What happens that now I do not remember where this change was and I am
>>> afraid to continue abusing my friendship with him because he is a very busy
>>> person with work and family.
>>>
>>> My honest opinion.
>>> I still think we're giving new users a bad impression of Cinelerra by
>>> keeping a few options in a batch rendering window that only very few users
>>> currently use. Some options that do not make any sense in a window of this
>>> type, something that has always been done with a save as, which is an
>>> option that does not require any Dangerous flag.
>>>
>>> Another option would be to leave the window as it was before all this
>>> matter, make the option "warn if it does not match ..." is disabled by
>>> default and the dangerous button what it does is a copy of the current file
>>> loaded in the EDL path adding a number to this new copy of the xml, and
>>> automatically reflect this change in the EDL path. In this way everything
>>> remains the same as before, the Dangerous flag is not necessary and the
>>> wizard stops being dangerous and automatically makes the "save as" and
>>> stops being a dangerous option for new users and this mode is satisfied.
>>> work for former users who made use of this feature. And most importantly,
>>> no one is going to lose their job due to a wrong click. I don't want to
>>> think about how the faces of these lovers of danger with their strange and
>>> dangerous way of working, if they press this option without having
>>> remembered to manually change the name in the EDL route.
>>>
>>> El lun, 18 ene 2021 a las 11:28, Rafa Mar Multimedia en Gnu\Linux (<
>>> rafamar.mm.ig at gmail.com>) escribió:
>>>
>>>> I'm going to download, compile and test to see how these changes work.
>>>> I really like the option of multiple backup copies that Reuss András
>>>> has made and his response of trying to make an option that creates some
>>>> backup copies together with the EDL
>>>>
>>>> El lun, 18 ene 2021 a las 7:15, Phyllis Smith via Cin (<
>>>> cin at lists.cinelerra-gg.org>) escribió:
>>>>
>>>>> Changes to Batch Render menu have been checked into GIT.  Lots of
>>>>> review/testing/decision making going on.  So basically this is the
>>>>> compromise solution (which can be changed if necessary, but I really think
>>>>> it is probably the best option).
>>>>>
>>>>> 1) new users or new .bcast5 will automatically never see the "warn on
>>>>> mismatch" and "save edl"
>>>>> 2) existing users, if they are seeing these 2 warnings, will have to
>>>>> go into Settings->Preferences, Appearance tab and uncheck DANGEROUS batch
>>>>> render gui, in order to stop seeing these 2 warnings.  Just one time and
>>>>> also be sure to use Settings pulldown to "save settings now".
>>>>> 3) anyone who wants to have these features available for use, has to
>>>>> get into Settings and check/enable Dangerous flag to see the 2 boxes.
>>>>>
>>>>> Tooltips added for several additional boxes helps to explain usage a
>>>>> little better in Batch Render menu and some Preferences flags.
>>>>>
>>>>> Code checked in mostly by Andrew with slight modifications for
>>>>> compromise and wording changes.
>>>>>
>>>>>
>>>>> On Sat, Jan 16, 2021 at 12:19 AM Andrew Randrianasulu via Cin <
>>>>> cin at lists.cinelerra-gg.org> wrote:
>>>>>
>>>>>> This time I tried to add user confirmation on project (EDL) file
>>>>>> overwrite,
>>>>>> _in addition_ to gui toggle hiding this button.
>>>>>>
>>>>>> Rafa Mar, I saw your letter, just tracking _where exactly_ this
>>>>>> function writes file() turned out
>>>>>> to be harder than just adding warning. For now.
>>>>>> --
>>>>>> Cin mailing list
>>>>>> Cin at lists.cinelerra-gg.org
>>>>>> https://lists.cinelerra-gg.org/mailman/listinfo/cin
>>>>>>
>>>>> --
>>>>> Cin mailing list
>>>>> Cin at lists.cinelerra-gg.org
>>>>> https://lists.cinelerra-gg.org/mailman/listinfo/cin
>>>>>
>>>>
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <https://lists.cinelerra-gg.org/pipermail/cin/attachments/20210118/8ea4f954/attachment-0001.htm>
-------------- next part --------------
A non-text attachment was scrubbed...
Name: imagen.png
Type: image/png
Size: 54499 bytes
Desc: not available
URL: <https://lists.cinelerra-gg.org/pipermail/cin/attachments/20210118/8ea4f954/attachment-0001.png>