[Cin] [PATCH] UnsafeGUI toggle, tooltips, file overwrite warning for batchrender.c

[Andrew Randrianasulu]

В сообщении от Monday 18 January 2021 23:41:53 Phyllis Smith via Cin написал(а):
> OK, I easily reproduced it and hope Andrew can help fix it.
> 
> On Mon, Jan 18, 2021 at 1:09 PM Andrea paz via Cin <
> cin at lists.cinelerra-gg.org> wrote:
> 
> > Also to me the rendering from the command line creates a dump (but the
> > file is empty!). From inside CinGG everything is OK.

What about adding "mwindow &&" to those unsafe_gui checks (sorry I haven't updated my working git copy yet)
in  BatchRenderThread::load_jobs and void BatchRenderThread::save_jobs ??

with those checks added it works with pre-setup 1.xml and 2.xml:

../bin/cin -r
Cinelerra Infinity - built: Jan 18 2021 18:09:51
git://git.cinelerra-gg.org/goodguy/cinelerra.git
(c) 2006-2019 Heroine Virtual Ltd. by Adam Williams
2007-2020 mods for Cinelerra-GG by W.P.Morrow aka goodguy
Cinelerra is free software, covered by the GNU General Public License,
and you are welcome to change it and/or distribute copies of it under
certain conditions. There is absolutely no warranty for Cinelerra.

Render::run: /dev/shm/1.xml
ff_aspect_ratio, 0.000000
ff_aspect_ratio, 0.000000
99% Расчётное время (ETA): 0:00:00      FFStream::encode_frame: encode failed.
file: /dev/shm/2.mp4
  err: Ресурс временно недоступен
FFStream::flush failed
:file:/dev/shm/2.mp4
  err: Операция не позволена
Render::render_single: Session finished.
Render::run: done in 0:00:56
Render::run: /dev/shm/2.xml
ff_aspect_ratio, 0.000000
ff_aspect_ratio, 0.000000
99% Расчётное время (ETA): 0:00:00      Render::render_single: Session finished.
Render::run: done in 0:00:54
** rendered 4036 frames in 111.637 secs, 36.153 fps
Session time: 0:01:52
Cpu time: user: 0:06:20.207 sys: 0:00:02.454


---

iff --git a/cinelerra-5.1/cinelerra/batchrender.C b/cinelerra-5.1/cinelerra/batchrender.C
index 6dcdbc62..996aa9da 100644
--- a/cinelerra-5.1/cinelerra/batchrender.C
+++ b/cinelerra-5.1/cinelerra/batchrender.C
@@ -60,6 +60,7 @@
 #include "dvdcreate.h"
 #include "bdcreate.h"

+
 int BatchRenderThread::column_widths[] = { 42, 42, 42, 222, 222, 150 };
 const char *BatchRenderThread::column_titles[] = {
        N_("Enabled"), N_("Labeled"), N_("Farmed"), N_("Output"), N_("EDL"), N_("Elapsed")
@@ -198,6 +199,7 @@ BatchRenderThread::BatchRenderThread(MWindow *mwindow)
        boot_defaults = 0;
        preferences = 0;
        warn = 1;
+
        render = 0;
        batch_path[0] = 0;
        do_farmed = 0;
@@ -268,7 +270,10 @@ void BatchRenderThread::load_jobs(char *path, Preferences *preferences)
        while( !result ) {
                if( !(result = file.read_tag()) ) {
                        if( file.tag.title_is("JOBS") ) {
+                               if (mwindow && mwindow->preferences->unsafe_gui)
                                warn = file.tag.get_property("WARN", 1);
+                               if (mwindow && !mwindow->preferences->unsafe_gui)
+                               warn = 0;
                        }
                        else if( file.tag.title_is("JOB") ) {
                                BatchRenderJob *job =  new BatchRenderJob(preferences, 0,0);
@@ -293,6 +298,7 @@ void BatchRenderThread::save_jobs(char *path)
 {
        FileXML file;
        file.tag.set_title("JOBS");
+       if (mwindow && mwindow->preferences->unsafe_gui)
        file.tag.set_property("WARN", warn);
        file.append_tag();
        file.append_newline();
@@ -382,11 +388,15 @@ void BatchRenderThread::use_current_edl()
        gui->edl_path_text->update(get_current_edl());
 }

+

====

> >
> > CinGG batch rendering also offers the possibility to render only an active
> > region of the project, so the position of the insertion point is important.
> > Generally it should be placed at the start.
> > --
> > Cin mailing list
> > Cin at lists.cinelerra-gg.org
> > https://lists.cinelerra-gg.org/mailman/listinfo/cin
> >
>