[Cin] [PATCH v3] Titler ..

[Andrew Randrianasulu]

В сообщении от Sunday 24 January 2021 21:19:22 Rafa Mar Multimedia en Gnu\Linux написал(а):
> Hi Andrew, I have tested these changes, I will give you an analysis below.
> 
> RESET: SUGGESTIONS
> 
> In file /cinelerra-5.1/plugins/titler/titler.C
> I would change
> outline_color = RED;
> It doesn't make much sense that both colors are white. Red is a good
> starting color for an outline.
> 
> In file /cinelerra-5.1/plugins/titler/titlerwindow.C
> The following parameters are missing
> 
> client->config.timecode = 0;
> // it is important in a reset to turn off this option if it has been
> activated
> 
> client->config.timecode_format = 1;
> // In audiovisual the default time code is HH:MM:SS:frames, that is hours,
> minutes, seconds and frames.
> 
> client->config.outline_color = RED;
> // It doesn't make much sense that the font color and outline are the same
> 
> client->config.line_pitch = 0;
> // VERY IMPORTANT THAT THIS VALUE MUST BE 0, ZERO INDICATES THAT IT IS
> DISABLED AND THE SPACING BETWEEN LINES WILL BE USED BY DEFAULT OF THE
> CHOSEN FONT, 24 IS A MISTAKE OVERLAPPING THE LINES.


SORRY!

I think I fixed this, but you need to close and open Titler window for applying this change

> 
> client->config.background = 0;
> // If the background has been activated, the reset must deactivate it.
> 
> client->config.background_path
> // It would be good if this tex box was left blank in a reset.
> 
> The content of the box where we add the texts should also be emptied

I think now it does after you close/open window ....

> 
> One problem that I observe is precisely that the parameter:
> line_pitch
> it does not update the number, for example, if I have entered 50 and do a
> reset, it should be set to 0 (24 is not correct) and it actually sets to 0
> internally, but this change is not reflected in the text box.
> 
> IMPORTANT:
> The position of the button can cause confusion, normally in cinelerra this
> button should be in the lower left part of the window. Where it is now
> looks like a reset only for colors.
> I can think of two solutions, or put it at the bottom left, or change the
> text "Reset" to "Reset All"

Changed to "reset all'

> 
> -------------------------------------------------------------------------------
> TAGS HTML SUGGESTIONS
> 
> It would be very helpful for a person who works in a language other than
> English to see the drop-down in this way, if the user does not know what a
> label does when he sees his name because he does not know English, with the
> right button he can consult quickly.
> Can this be done?

Sorry, I'm bad at string manipulation ...

I mean there is  one place for BOTH menu line and associated parameter
we insert as  those tags ...

So, exctracting actionable part from longer sentences is no fun for me, sadly ....
But I'll experiment with menu item's tooltips :}

> 
> Example in Russian:
> 
> [image: imagen.png]
> 
> Line pith = Расстояние между линиями
> or
> Line pith = Space between lines = Межстрочный интервал
> 
> I don't know Russian, but I have a good friend who is and has given me
> these translations of 'Line Pith', It is a long text, I do not know if
> there will be an abbreviation for this term in Russian.
> 
> Example in Spanish:
> 
> [image: imagen.png]
> 
> Thank you very much for your good work.
> 
> 
> El dom, 24 ene 2021 a las 16:50, Andrew Randrianasulu via Cin (<
> cin at lists.cinelerra-gg.org>) escribió:
> 
> > I moved default title color to WHITE, removed few empty lines and debug
> > printf ...
> > tested with two plugins active, "Reset" thankfully works on per-plugin
> > basis ...
> > --
> > Cin mailing list
> > Cin at lists.cinelerra-gg.org
> > https://lists.cinelerra-gg.org/mailman/listinfo/cin
> >
> 


-------------- next part --------------
A non-text attachment was scrubbed...
Name: TITLER_reset_plus_eng_tags-3.diff
Type: text/x-diff
Size: 9639 bytes
Desc: not available
URL: <https://lists.cinelerra-gg.org/pipermail/cin/attachments/20210124/f612914d/attachment.bin>