[Cin] exportEDL, timecode patches

[Andrew Randrianasulu]

On Saturday, July 10, 2021, Andrew Randrianasulu <randrianasulu at gmail.com>
wrote:

>
>
> On Saturday, July 10, 2021, Andrea paz <gamberucci.andrea at gmail.com>
> wrote:
>
>> Partial success!
>> I changed the frame rate of the project to 24 fps. I got the same
>> errors with all programs.
>> I manually edited the created EDL file by putting the path each time
>> the source (test2.mp4) appeared. See attached edl file. Now in
>> OpenShot it opens without problems!
>
>
>
> cool, but strange (I replaced full path with just filename aerly because
> other test edls I saw were written this way..)
>
> may be we can add '* FROM FILE /full_path/name.ext line' too?
>

test patch (on top of those already merged) attached...





>
> from
>
> OpenTimelineIO/src/py-opentimelineio/opentimelineio/adapters/cmx_3600.py
>
>
>
> # this should be a map of all known comments that we can read # 'FROM
> CLIP' or 'FROM FILE' is a required comment to link media # An exception is
> raised if both 'FROM CLIP' and 'FROM FILE' are fo
> und # needs to be ordered so that FROM CLIP NAME gets matched before FROM
> CLIP
>     comment_id_map = collections.OrderedDict([ ('FROM CLIP NAME',
> 'clip_name'), ('TO CLIP NAME', 'dest_clip_name'), ('FROM CLIP',
> 'media_reference'), ('FROM FILE', 'media_reference'), ('LOC', 'locators'),
> ('ASC_SOP', 'asc_sop'),
>         ('ASC_SAT', 'asc_sat'), ('M2', 'motion_effect'),
>         ('\\* FREEZE FRAME', 'freeze_frame'), ])
>
>
>> In Kdenlive there are the usual errors (maybe a little less? See
>> image);
>
>
>>
>  it looks like kdenlive can't load its own adapter? may be
> OTIO/Kdenlive/python mismatch?
>
>
>
>>
>> in Olive still the same error.
>>
>
> not sure about this one..
>
>
> P.S.:  thanks for your video tutirials, I was wondering what _secondary_
> color correction term mean and you answered that }
>
>
>
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <https://lists.cinelerra-gg.org/pipermail/cin/attachments/20210710/02ad0887/attachment.htm>
-------------- next part --------------
diff --git a/cinelerra-5.1/cinelerra/exportedl.C b/cinelerra-5.1/cinelerra/exportedl.C
index d4d670eb..5b1d0bd5 100644
--- a/cinelerra-5.1/cinelerra/exportedl.C
+++ b/cinelerra-5.1/cinelerra/exportedl.C
@@ -192,9 +192,11 @@ void ExportEDLAsset::export_it()
 			char destinpoint[12];
 			char destoutpoint[12];
 			
-			char filename[1024];
-			if (edit->asset)
+			char filename[1024], asset_pathname[1024];
+			if (edit->asset) {
 			strcpy(filename,basename(edit->asset->path));
+			strcpy(asset_pathname, edit->asset->path);
+			}
 			
 			if(!edit->asset)
 			strcpy(reel_name,"BL  ");
@@ -220,8 +222,9 @@ void ExportEDLAsset::export_it()
 					fprintf(fh, " %s %s", last_sourceout, last_sourceout);
 					fprintf(fh, " %s %s", destinpoint, destinpoint);
 					fprintf(fh,"\n");
-					if(edit->asset)
+					if(edit->asset){
 					fprintf(fh,"* FROM CLIP NAME: %s\n", filename);
+					fprintf(fh,"* FROM FILE: %s\n", asset_pathname);}
 				} else
 				{
 					colnum --;
@@ -231,8 +234,9 @@ void ExportEDLAsset::export_it()
 				fprintf(fh, " %s %s", sourceinpoint, sourceoutpoint);
 				fprintf(fh, " %s %s", destinpoint, destoutpoint);
 				fprintf(fh,"\n");
-				if(edit->asset)
+				if(edit->asset) {
 				fprintf(fh,"* FROM CLIP NAME: %s\n", filename);
+				fprintf(fh,"* FROM FILE: %s\n", asset_pathname);}
 				last_dissolve = 1;
 			} else
 			{
@@ -241,8 +245,9 @@ void ExportEDLAsset::export_it()
 				fprintf(fh, " %s %s", sourceinpoint, sourceoutpoint);
 				fprintf(fh, " %s %s", destinpoint, destoutpoint);
 				fprintf(fh,"\n");
-				if(edit->asset)
+				if(edit->asset) {
 				fprintf(fh,"* FROM CLIP NAME: %s\n", filename);
+				fprintf(fh,"* FROM FILE: %s\n", asset_pathname);}
 				last_dissolve = 0;
 			}