[Cin] bluray lpcm update!

[Andrew Randrianasulu]

On Tuesday, April 26, 2022, Phyllis Smith <phylsmith2017 at gmail.com> wrote:

> I am out of ideas to try.
>
> [root at keystone libavcodec]# diff pcm-bluenc.c /root/
>>> *Downloads/pcm-bluenc.c*
>>> [root at keystone libavcodec]#
>>>
>>> [root at keystone libavformat]# *diff mpegtsenc.c*
>>> /tmp/cinelerra-5.1/thirdparty/ffmpeg-4.4/libavformat/mpegtsenc.c
>>> 1959,1962d1958
>>> <     } else if (st->codecpar->codec_id == AV_CODEC_ID_PCM_BLURAY &&
>>> ts->m2ts_mode) {
>>> <         mpegts_write_pes(s, st, buf, size, pts, dts,
>>> <                          pkt->flags & AV_PKT_FLAG_KEY, stream_id);
>>> <         return 0;
>>>
>>
>>
>> 'diff - u' a bit more widespread form of diff, for now..
>>
> Exact same results when do "diff -u".
>

note, even if file named like c file it actually diff..

but both patches as send works for me as after full rebuild..
/

if you (re)move those last two patches from tirdparty/src error (can't find
codec..) disappears?


>> but strange. you rebuild cin executable too? (because we link statically
>> I typed  "touch cinelerra/new.C" and this forced rebuild of  this file and
>> re-linking of executable...)
>>
> I do full rebuilds by running "make clean" which deletes all of the
> thirdparty libraries and then do a full rebuild with "./bld.sh".  Goes
> pretty fast on this laptop and it is not worth the aggravation to only
> rebuild changed itemsl
>
>>
>> does ffmpeg from thirdparty lists pcm_bluray as supported encoder?
>>
> It must because what is checked into GIT, lets me choose the lpcm profile
> and on the bluray player, the info button clearly displays it as lpcm.
>

try thirdparty/ffmpeg-4.4/ffmpeg -codecs | grep bluray



>
>>
>>
>>
>>
>>> On Mon, Apr 25, 2022 at 2:00 PM Andrew Randrianasulu <
>>> randrianasulu at gmail.com> wrote:
>>>
>>>>
>>>>
>>>> On Monday, April 25, 2022, Phyllis Smith <phylsmith2017 at gmail.com>
>>>> wrote:
>>>>
>>>>> Andrew, applied ffmpeg-4.4.patch_12 and ffmpeg-4.4.patch99 and it
>>>>> compiles but fails with error message "open failed
>>>>> pcm_bluray:/tmp/bd_date_tme/bd.m2ts" as seen in the attached png file.
>>>>>
>>>>
>>>> strange.
>>>>
>>>> can you double-check patches applied correctly (by comparing
>>>> pcm-bluenc.c I attached earlier and actual file in
>>>> thirdparty/ffmpeg/libavcodec? )
>>>>
>>>>
>>>>
>>>>> On Sun, Apr 24, 2022 at 9:18 AM Andrew Randrianasulu <
>>>>> randrianasulu at gmail.com> wrote:
>>>>>
>>>>>> Paul fixed bug preventing tsmuxer from recognizing our lpcm audio
>>>>>> stream
>>>>>>
>>>>>> I backshoed fix into our ffmpeg 4.4..
>>>>>>
>>>>>> I think having it all worked in monthly release quite important, even
>>>>>> if names of patches kinda high...
>>>>>>
>>>>>> also attached raw pcm-bluenc file as I hacked it, and fix/patch as
>>>>>> downloaded from gitweb..
>>>>>>
>>>>>> https://github.com/justdan96/tsMuxer/issues/580
>>>>>>
>>>>>> https://git.ffmpeg.org/gitweb/ffmpeg.git/blobdiff/037fa0437d
>>>>>> 2aead40c1f786c6ad4d343afe0546d..058a1ff9b4cdbd2e1a93acc8bf03
>>>>>> 65e7d01cc9f4:/libavcodec/pcm-blurayenc.c
>>>>>>
>>>>>> https://git.ffmpeg.org/gitweb/ffmpeg.git/commit/93dfb6afddb2
>>>>>> 78218da7f8c696bf35ede2ba05aa
>>>>>>
>>>>>
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <https://lists.cinelerra-gg.org/pipermail/cin/attachments/20220426/212fa85b/attachment.htm>