[Cin] bluray lpcm update!

[Phyllis Smith]

Andrew, 10 million "mega" tests later, I finally figured it out.  Neither
the chosen "Profile" or "tsmuxer" setting is getting reset to "Bluray" for
profile and "no tsmuxer" for tsmuxer.

So what was happening is I loaded a file with 5:1 audio, chose LPCM and
TSMUXER and the error message of:
   * [pcm_bluray @ 0x7f002b5ff9c0] Specified channel layout '5.1' is not
supported*
which is fine as long as I document that.  But then I would load Big Buck
Bunny (also 5:1 audio) and since I saw that tsmuxer was not checked and
lpcm was not highlighted, I thought is should work and it did not because
both LPCM and TSMUXER will still "on".

Since I am not sure if I can get it right, could you provide the lines of
code to change so that the profile and tsmuxer are reset to default "not
on" values every time BD Render is chosen from the File pulldown?  Then I
can do a final test and check into GIT.  Thanks, Phyllis

On Tue, Apr 26, 2022 at 7:22 AM Andrew Randrianasulu <
randrianasulu at gmail.com> wrote:

>
>
> On Tuesday, April 26, 2022, Phyllis Smith <phylsmith2017 at gmail.com> wrote:
>
>> Andrew, if instead of choosing lpcm as the profile with the 2 patches in,
>> I choose the standard bluray, it works.
>>
>>>
>>> note, even if file named like c file it actually diff..
>>>
>>> but both patches as send works for me as after full rebuild..
>>> /
>>>
>>> if you (re)move those last two patches from tirdparty/src error (can't
>>> find codec..) disappears?
>>>
>> Yes.
>>
>
>
> do you have some other libavcodec headers installed?
>
> what ldd bin/cin (assuming you run from src root for single user) says?
>
>
>
>>>
>>>>> but strange. you rebuild cin executable too? (because we link
>>>>> statically I typed  "touch cinelerra/new.C" and this forced rebuild of
>>>>> this file and re-linking of executable...)
>>>>>
>>>> I do full rebuilds by running "make clean" which deletes all of the
>>>> thirdparty libraries and then do a full rebuild with "./bld.sh".  Goes
>>>> pretty fast on this laptop and it is not worth the aggravation to only
>>>> rebuild changed itemsl
>>>>
>>>>>
>>>>> does ffmpeg from thirdparty lists pcm_bluray as supported encoder?
>>>>>
>>>> It must because what is checked into GIT, lets me choose the lpcm
>>>> profile and on the bluray player, the info button clearly displays it as
>>>> lpcm.
>>>>
>>>
>>> try thirdparty/ffmpeg-4.4/ffmpeg -codecs | grep bluray
>>>
>>> [root at keystone cinelerra-5.1]# thirdparty/ffmpeg-4.4/ffmpeg -codecs |
>> grep bluray
>>  DEAI.S pcm_bluray           PCM signed 16|20|24-bit big-endian for
>> Blu-ray media
>>
>>
>>>
>>>
>>>>
>>>>>
>>>>>
>>>>>
>>>>>
>>>>>> On Mon, Apr 25, 2022 at 2:00 PM Andrew Randrianasulu <
>>>>>> randrianasulu at gmail.com> wrote:
>>>>>>
>>>>>>>
>>>>>>>
>>>>>>> On Monday, April 25, 2022, Phyllis Smith <phylsmith2017 at gmail.com>
>>>>>>> wrote:
>>>>>>>
>>>>>>>> Andrew, applied ffmpeg-4.4.patch_12 and ffmpeg-4.4.patch99 and it
>>>>>>>> compiles but fails with error message "open failed
>>>>>>>> pcm_bluray:/tmp/bd_date_tme/bd.m2ts" as seen in the attached png file.
>>>>>>>>
>>>>>>>
>>>>>>> strange.
>>>>>>>
>>>>>>> can you double-check patches applied correctly (by comparing
>>>>>>> pcm-bluenc.c I attached earlier and actual file in
>>>>>>> thirdparty/ffmpeg/libavcodec? )
>>>>>>>
>>>>>>>
>>>>>>>
>>>>>>>> On Sun, Apr 24, 2022 at 9:18 AM Andrew Randrianasulu <
>>>>>>>> randrianasulu at gmail.com> wrote:
>>>>>>>>
>>>>>>>>> Paul fixed bug preventing tsmuxer from recognizing our lpcm audio
>>>>>>>>> stream
>>>>>>>>>
>>>>>>>>> I backshoed fix into our ffmpeg 4.4..
>>>>>>>>>
>>>>>>>>> I think having it all worked in monthly release quite important,
>>>>>>>>> even if names of patches kinda high...
>>>>>>>>>
>>>>>>>>> also attached raw pcm-bluenc file as I hacked it, and fix/patch as
>>>>>>>>> downloaded from gitweb..
>>>>>>>>>
>>>>>>>>> https://github.com/justdan96/tsMuxer/issues/580
>>>>>>>>>
>>>>>>>>>
>>>>>>>>> https://git.ffmpeg.org/gitweb/ffmpeg.git/blobdiff/037fa0437d2aead40c1f786c6ad4d343afe0546d..058a1ff9b4cdbd2e1a93acc8bf0365e7d01cc9f4:/libavcodec/pcm-blurayenc.c
>>>>>>>>>
>>>>>>>>>
>>>>>>>>> https://git.ffmpeg.org/gitweb/ffmpeg.git/commit/93dfb6afddb278218da7f8c696bf35ede2ba05aa
>>>>>>>>>
>>>>>>>>
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <https://lists.cinelerra-gg.org/pipermail/cin/attachments/20220426/4c23dc7a/attachment-0001.htm>