[Cin] oh, my fix for nested edl undo crash regressed video!

[Andrew Randrianasulu]

On Tue, Dec 27, 2022 at 4:49 AM Phyllis Smith <phylsmith2017 at gmail.com>
wrote:

> Checked patch into GIT after testing before and after as recommended.  It
> must be Slackware specific because it did not crash before on Fedora 64-bit
> - or maybe 32-bit but anyway it is an improvement.  I still will be doing
> more testing tomorrow with additional un-do's to stress it a bit more.
>


for me it crash like this (from desktop)


 bash-5.1$ cin
Cinelerra Infinity - built: Dec 26 2022 21:22:08
git://git.cinelerra-gg.org/goodguy/cinelerra.git
(c) 2006-2019 Heroine Virtual Ltd. by Adam Williams
2007-2020 mods for Cinelerra-GG by W.P.Morrow aka goodguy
Cinelerra is free software, covered by the GNU General Public License,
and you are welcome to change it and/or distribute copies of it under
certain conditions. There is absolutely no warranty for Cinelerra.

int MWindow::load_filenames(ArrayList<char*>*, int, int, int):
/home/guest/Downloads/01background.jpg's resolution is 735x587.
Images with odd dimensions may not decode properly.
FileSystem::update /home/guest/MLP FIM 1 Karusel No such file or directory
FileSystem::update /home/guest/MLP FIM 3 Karusel No such file or directory
FileSystem::update /home/guest/MLP FIM 4 Gala No such file or directory
FileSystem::update /home/guest/MLP FIM 5 RUS ENG 720p No such file or
directory
FileSystem::update /home/guest/MLP_FIM_Season4 No such file or directory
FileSystem::update /home/guest/My Little Pony - Friendship is Magic S02
720p No such file or directory
FileSystem::update /home/guest/MLP FIM 1 Karusel No such file or directory
FileSystem::update /home/guest/MLP FIM 3 Karusel No such file or directory
FileSystem::update /home/guest/MLP FIM 4 Gala No such file or directory
FileSystem::update /home/guest/MLP FIM 5 RUS ENG 720p No such file or
directory
FileSystem::update /home/guest/MLP_FIM_Season4 No such file or directory
FileSystem::update /home/guest/My Little Pony - Friendship is Magic S02
720p No such file or directory
Mutex::lock: Success
Mutex::unlock: Invalid argument
Mutex::lock: Success
Mutex::lock: Success
Mutex::unlock: Invalid argument
Garbage::remove_user 66 users=-530705799
Mutex::unlock: Invalid argument
malloc(): unsorted double linked list corrupted
Аварийный останов
bash-5.1$ cd

>
> On Mon, Dec 26, 2022 at 12:59 PM Andrew Randrianasulu <
> randrianasulu at gmail.com> wrote:
>
>>
>>
>> пн, 26 дек. 2022 г., 22:54 Phyllis Smith <phylsmith2017 at gmail.com>:
>>
>>> I will test that but I am not very good at testing and was hoping from
>>> feedback from someone who is better at it.  Will start testing that in
>>> about 30 minutes.
>>>
>>
>>
>>
>> I tested ot like this.
>>
>> load some jpg image, it will expand itself as default 3 sec long timeline.
>>
>> "Save as" with xml extension.
>>
>> Load this xml as nested.
>>
>> hit 'undo' right away.
>>
>> for me  cingg crashes :(
>>
>>
>>
>>> On Mon, Dec 26, 2022 at 12:17 PM Andrew Randrianasulu <
>>> randrianasulu at gmail.com> wrote:
>>>
>>>>
>>>>
>>>> вс, 20 нояб. 2022 г., 01:23 Phyllis Smith <phylsmith2017 at gmail.com>:
>>>>
>>>>> *IgorBeghetto:*
>>>>> I created an AppImage that contains the BT #558 bug fix (0x00 vs.
>>>>> 0xff) AND with these 2 Experimental patches in to fix "nested edl undo
>>>>> crash" so you could test if you find the time.  The fix for 558 is the most
>>>>> important though and you already built that.  It is at:
>>>>>    https://cinelerra-gg.org/download/testing/test_ubuntu16.AppImage
>>>>>
>>>>> Locking and unlocking are extremely sensitive and can cause all kinds
>>>>> of weird crashes so I guess that is why the patch is called EXPERIMENTAL.
>>>>> But could definitely be the missing part and fix the problem.
>>>>>
>>>>
>>>> I recompiled cingg on my Slackware without those two patches and sadly
>>>> crash on nested edl load/undo still around :(
>>>>
>>>> Phyllis, can you just add part with checking existence of edl, and may
>>>> be leave locking changes out for now? ( I thought we should unlock in same
>>>> function if we exit from it but may be I am wrong ...)
>>>>
>>>>
>>>>
>>>>
>>>>>
>>>>> On Sun, Nov 13, 2022 at 6:50 PM Andrew Randrianasulu <
>>>>> randrianasulu at gmail.com> wrote:
>>>>>
>>>>>>
>>>>>> ---------- Forwarded message ---------
>>>>>> От: Андрей Рандрианасулу <randrik at mail.ru>
>>>>>> Date: пн, 14 нояб. 2022 г., 04:37
>>>>>> Subject: oh, my fix for nested edl undo crash regressed video!
>>>>>> To: randrianasulu <randrianasulu at gmail.com>
>>>>>>
>>>>>>
>>>>>> better (?) fix (tested with video this time)
>>>>>>
>>>>>> --
>>>>>> Андрей  Рандрианасулу
>>>>>>
>>>>>
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <https://lists.cinelerra-gg.org/pipermail/cin/attachments/20221227/59bcf6ce/attachment-0001.htm>