[Cin] libaom 3.2.0 patch1 fixed for arm/linux?

[Phyllis Smith]

>
> I need clarification please.
> 1) Thirdparty-Makefile-giflib.patch that Mat attached is definitely needed
> and should be checked into GIT? probably yes?
> 2) libaom-v3.2.0.patch1 that Andrew provided on Jan. 08; is this needed?
> probably not?
> 3) have I missed some other changes? probably not?
>
>
> <snip>
> I tested both again to make sure.
> === giflib ===
> Without the giflib change:
> Makefile:
> giflib.cfg_params=echo "exec true" > ./configure; chmod +x ./configure;
> log:
> CONFIGURING giflib
> cd giflib* && ./configure echo "exec true" > ./configure; chmod +x
> ./configure;
> and the configure file is 0 bytes.
>
> With the giflib change:
> Makefile:
> giflib.cfg_vars=echo "exec true" > ./configure; chmod +x ./configure;
> log:
> CONFIGURING giflib
> cd giflib* && echo "exec true" > ./configure; chmod +x ./configure;
> ./configure
> and the configure file is 10 bytes.
>
> So, it builds without the fix because the last cmd is a chmod which return
> OK.
> But it is by accident. So the fix should be in the git.
>
OK, checked into GIT as stated after building on my laptop system.

>
> There are two more with bad configure files, I will look at them. The
> Makefile always
> calls ./configure in the root of the unpacked source directory, so there
> should be
> a configure script, which in case of unused, should return true.
>
OK, will wait for your feedback if more needed.

>
> == libaom patch====
> The 20220108_Andrew patch for libaom, which changes __LINUX__ to __linux__
> is not
> needed for X86_64 builds, it builds fine with either.
> However, it fails building on Debian_11/aarch64 compiling
> libaom_v3.2.0/aom_ports/arm_cpudetect.c .
>
> With the patch, which lowercases __linux__, it builds fine.
>
> So this fix should be in the git too.
>
OK, checked into GIT as stated after building on my laptop system.
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <https://lists.cinelerra-gg.org/pipermail/cin/attachments/20220113/ff78bc82/attachment.htm>