[Cin] New patches
Andrew Randrianasulu
randrianasulu at gmail.com
Wed Oct 9 01:01:03 CEST 2024
ср, 9 окт. 2024 г., 01:42 Phyllis Smith <phylsmith2017 at gmail.com>:
> So glad Andrea asked this question as I was wondering if I missed anything.
> I will check in x265 version 4.0 along with the patch Andrew provided as
> ffmpeg-7.0.patch6 to fix it tomorrow.
>
> Also, a question for Andrew about F_scale: if there is a specific
> parameter setting that makes this not fail, it can be added to
> cinelerra-5.1/ffmpeg/plugin.opts. Currently there is a line "scale
> 200:100" in that file that sets width and height defaults. So if the
> parameter is in 7.0 as well as 7.1, we can set that now so it does not fail
> later.
>
unfortunately, ffmpeg's vf_scale was improved so now it takes dynamic
input, and by default cingg filters out such filters
https://git.ffmpeg.org/gitweb/ffmpeg.git/blob/HEAD:/libavfilter/vf_scale.c#l1337
.flags = AVFILTER_FLAG_DYNAMIC_INPUTS,
https://git.cinelerra-gg.org/git/?p=goodguy/cinelerra.git;a=blob;f=cinelerra-5.1/cinelerra/pluginfclient.C;h=b8694b120e29ca26a36adde2e701094d99b86070;hb=HEAD
1258 int flag_mask = AVFILTER_FLAG_DYNAMIC_INPUTS |
AVFILTER_FLAG_DYNAMIC_OUTPUTS;
1259 if( filter->flags & flag_mask ) return AVERROR(EPERM);
I commented out (//) .flags line in ffmpeg, but may be we can comment out
those two lines in our pluginfclient.C and see if it still works?
> And another question for Andrew, I thought in one of your emails you
> mentioned vf_filter or something like that that also might need to be
> patched. But I can not find that anymore.
>
> On Tue, Oct 8, 2024 at 3:10 AM Andrew Randrianasulu via Cin <
> cin at lists.cinelerra-gg.org> wrote:
>
>>
>>
>> вт, 8 окт. 2024 г., 12:01 Andrea paz via Cin <cin at lists.cinelerra-gg.org
>> >:
>>
>>> I have not been able to follow CinGG lately, but it seems OK now. I
>>> see many long threads and several patches from Andrew. Could you
>>> please point me to which patches to put in and what to test?
>>>
>>
>> I was mostly looking at qsv (intel-specific) encoding, and related
>> mediacodec (but mediacodec only relevant/usable in termux).
>>
>> So, not sure if this part applicable for you on AMD.
>>
>> Another part was about ffmpeg-7.1/x265 4.0 , there was one failing filter
>> (F_scale) that can be fixed by altering ffmpeg sources. I am not sure I
>> want 7.1 without some range conversion fixes, but I am not sure if they
>> ever find their way into 7.1 branch ...
>>
>> so, in short unless you want to see how ffmpeg 7.1 performs I do mot
>> think there is much else to test yet?
>>
>>
>> --
>>> Cin mailing list
>>> Cin at lists.cinelerra-gg.org
>>> https://lists.cinelerra-gg.org/mailman/listinfo/cin
>>>
>> --
>> Cin mailing list
>> Cin at lists.cinelerra-gg.org
>> https://lists.cinelerra-gg.org/mailman/listinfo/cin
>>
>
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <https://lists.cinelerra-gg.org/pipermail/cin/attachments/20241009/a5267d8f/attachment.htm>
More information about the Cin
mailing list