[Cin] Fwd: Mentioned in [Cinelerra-GG 0000672]: Crash when using the speed curve

[Andrew Randrianasulu]

so, I looked at this bug and it seems that only taking back change to
auto.C "fixes" it

But may be I just tested too little (in virtual Arch)

full backtrace is big, but I think it crashes here:

#6  MWindow::normalize_speed (this=this at entry=0x7ffe5099ab80,
old_edl=0x62bf3d52dd40, new_edl=0x7a75402bbd50,
edit_speed=edit_speed at entry=0) at mwindowedit.C:2705
        old_keyframes = <optimized out>
        new_keyframes = 0x7a7538311830
        old_auto = 0x0
        new_plugin = <optimized out>
        plugin_start = <optimized out>
        orig_start = <optimized out>
        plugin_end = <optimized out>
        orig_end = <optimized out>
        old_plugin_set = <optimized out>
        new_plugin_set = 0x7a75382080a0
        old_plugin = <optimized out>
        i = 0
        old_size = <optimized out>
        new_size = <optimized out>
        n = <optimized out>
        old_speeds = <optimized out>
        old_speed = <optimized out>
        old_edit = <optimized out>
        new_speeds = <optimized out>
        new_speed = <optimized out>
        edit_plugins = 1
        edit_autos = 1
        edit_labels = 1
        result = 1
        first_track = 0
        old_track = <optimized out>
        new_track = <optimized out>
#7  0x000062befc37112a in MWindow::speed_after (this=0x7ffe5099ab80,
done=done at entry=0, edit_speed=edit_speed at entry=0) at
mwindowedit.C:2753

so *may be* old_auto being 0x0 causes crash ?

Not sure where to put guard in this function yet ...

---------- Forwarded message ---------
From: Cinelerra GG Bug Tracker <noreply at cinelerra-gg.org>
Date: Tue, Apr 8, 2025 at 6:03 AM
Subject: Mentioned in [Cinelerra-GG 0000672]: Crash when using the speed curve
To: <randrianasulu at gmail.com>


On 2025-04-08 03:03, PhyllisSmith mentioned you on:

https://www.cinelerra-gg.org/bugtracker/view.php?id=672

@Lukas
I think I have isolated the crash and reverted 3 files to a previously working
version.  BUT it does not make any sense why that would solve the problem AND I
am not even sure that it solves all cases. However, I will create an older
version AppImage with the change in for you to test when I boot that O/S desktop
tomorrow.

@Andrew-R
Here is an exact set of minimum steps to create the problem.
  Start with a new bcast, i..e. CIN_CONFIG=/tmp/bcast5 bin/cin
  Just dismiss the note of the day window (x it gone)
  load media using replace current project
  turn on generate keyframes while tweaking
  drag chromakeyhsv to video
  bring up chromkeyhsv menu
  play a little and move the slider in the chromkeyhsv menu to get keyframes
  stop play, then move cursor and play a little to get another set of keyframes
  use View to turn on speed curve
  move cursor to between the 2 sets of keyframes
  in front of cursor, try to move speed curve
  it gets stuck and crashes

THIS COMMIT CRASHES:
commit 25e944875e181186eeb59a124c1822e5b55d2248
Author: Good Guy <good1.2guy at gmail.com>
Date:   Fri Sep 4 09:17:01 2020 -0600

    fix auto id 'that' blunder, tweak keyfrm popup speed undo

THIS COMMIT SEEMS TO WORK:
commit 22c6251d37911a11e322bf7518e6a992ea0bb6c7
Author: Good Guy <good1.2guy at gmail.com>
Date:   Wed Sep 2 19:16:24 2020 -0600

    add ids to auto/labels, fix awdw gui deadlock, fix fourier bfr bug, fix
cache critical section, rework normalize_speed, fix delete_track gang bug

So I reverted cinelerra keyframepopup.C, keyframepopup.h, and auto.C to the Sept
2, 2020 version since no further changes were made to those other than a
comment.