<div dir="ltr"><div>These changes look good. Thanks.</div><div>and now the inevitable "but"..., these are just suggestions,</div><div>but they are based on my past experiences.</div><div><br></div><div>1) don't leave dead code in the product unless you think it may be useful in the future.</div><div>examples: the configure script is already sort of trashy, since it is the driver for a set</div><div>of old products. The main reason the thirdparty design exists is that you can't trust the</div><div>maintainers to not break your build. PLEASE be aware that every month any mod you</div><div>make has to work on 18 platforms that cover a span of 10 years or so. Any break that</div><div>is historical can stop several builds. The build system is a xen host running an</div><div>embedded busybox system that only operates the build. No servers, no installed extras.</div><div>It operates 3 sets of build iterators. If any of them fail, more passes (4,5,...). Each pass</div><div>is risky, since it is almost always some kind of emergency patch, and usually</div><div>downgrades the results. Another example, /usr/X11R7/lib has not been around for a</div><div>while on most platforms. It also as permuted variants /usr/lib/X11 /usr/share/X11/ etc.</div><div>If the change is really needed for a particular platform, then it may need to be "specialized".</div><div><br></div><div>2) I am not sure, but it looks like there is a new version of OpenEXR (2.4.1). I tried it,</div><div>but it requires the a very recent version of cmake. Currently, there seems to be a struggle</div><div>to replace autotools with cmake,meson,waf ... Meson broke many builds. I rewrote the</div><div>dav1d meson build as a makefile, and tried to give it to the developers, but they declined to</div><div>carry it. Every time they tweak the build, I have to mod the makefile. Not nice. And now</div><div>the suggestion, If you are going to refactor the OpenEXR build, please see if it is possbile</div><div>to get it to work with the more recent version. It is not essential to make it work, since it</div><div>is already working with a usable version, but keeping up with 40 or so libraries is a major</div><div>task, and maintenance is continuous. Try to make sure that the work you do will be good</div><div>for as long as possible.</div><div><br></div><div>3) I personally wish to thank you (and all of you) who have helped to improve the result.</div><div>It has always been a curiosity that almost all of the technical help is not from any "techy"</div><div>component, (eg. google, apple, adobe, ...) but from real users that are just plain interested</div><div>in having something nice to use. It is highly appreciated for your work on a large section</div><div>of source code/libraries. Thank you.</div><div><br></div><div>gg</div><div>PS. The documentation rework is just outstanding.</div><div><br></div><div><br></div><div><br></div><div><br></div></div><br><div class="gmail_quote"><div dir="ltr" class="gmail_attr">On Wed, Mar 18, 2020 at 6:07 AM Andrew Randrianasulu <<a href="mailto:randrianasulu@gmail.com">randrianasulu@gmail.com</a>> wrote:<br></div><blockquote class="gmail_quote" style="margin:0px 0px 0px 0.8ex;border-left:1px solid rgb(204,204,204);padding-left:1ex">Only <a href="http://configure.ac" rel="noreferrer" target="_blank">configure.ac</a> patch this time ..<br>
<br>
diff --git a/cinelerra-5.1/<a href="http://configure.ac" rel="noreferrer" target="_blank">configure.ac</a> b/cinelerra-5.1/<a href="http://configure.ac" rel="noreferrer" target="_blank">configure.ac</a><br>
index f10af67..7375fa9 100644<br>
--- a/cinelerra-5.1/<a href="http://configure.ac" rel="noreferrer" target="_blank">configure.ac</a><br>
+++ b/cinelerra-5.1/<a href="http://configure.ac" rel="noreferrer" target="_blank">configure.ac</a><br>
@@ -8,7 +8,7 @@ AC_LANG_CPLUSPLUS<br>
AC_LANG_C<br>
AC_PROG_CXX<br>
<br>
-CFG_CFLAGS+=" -fno-omit-frame-pointer -fno-math-errno -fno-signed-zeros"<br>
+CFG_CFLAGS+=" -std=c++11 -fno-omit-frame-pointer -fno-math-errno -fno-signed-zeros"<br>
CFG_CFLAGS+=" -pthread -Wall"<br>
# misguided pedantic warnings<br>
# this is extra work, not a gain...<br>
@@ -239,14 +239,14 @@ PKG_3RD([giflib],[yes],<br>
libutil.a ],<br>
[ . ])<br>
<br>
-PKG_3RD([ilmbase],[auto],<br>
- [ilmbase-2.2.1],<br>
- [ Iex/.libs/libIex.a \<br>
- IexMath/.libs/libIexMath.a \<br>
- Half/.libs/libHalf.a \<br>
- Imath/.libs/libImath.a \<br>
- IlmThread/.libs/libIlmThread.a ],<br>
- [ Iex Half Imath config IlmThread ])<br>
+#PKG_3RD([ilmbase],[auto],<br>
+# [ilmbase-2.2.1],<br>
+# [ Iex/.libs/libIex.a \<br>
+# IexMath/.libs/libIexMath.a \<br>
+# Half/.libs/libHalf.a \<br>
+# Imath/.libs/libImath.a \<br>
+# IlmThread/.libs/libIlmThread.a ],<br>
+# [ Iex Half Imath config IlmThread ])<br>
<br>
PKG_DEF([ladspa], [ladspa-0.4.17], [], [])<br>
<br>
@@ -337,11 +337,16 @@ PKG_3RD([mjpegtools],[yes],<br>
mpeg2enc/.libs/libmpeg2encpp.a ],<br>
[ . lavtools utils ])<br>
<br>
-PKG_3RD([openexr],[auto],<br>
- [openexr-2.2.1],<br>
- [ IlmImf/.libs/libIlmImf.a \<br>
- IlmImfUtil/.libs/libIlmImfUtil.a ],<br>
- [ IlmImf config ])<br>
+PKG_3RD([openexr],[yes],<br>
+ [openexr-2.4.1],<br>
+ [ IlmBase/Iex/.libs/libIex.a \<br>
+ IlmBase/IexMath/.libs/libIexMath.a \<br>
+ IlmBase/Half/.libs/libHalf.a \<br>
+ IlmBase/Imath/.libs/libImath.a \<br>
+ IlmBase/IlmThread/.libs/libIlmThread.a <br>
+ OpenEXR/IlmImf/.libs/libIlmImf.a \<br>
+ OpenEXR/IlmImfUtil/.libs/libIlmImfUtil.a ],<br>
+ [ Iex Half Imath IlmThread IlmImf config usr/include/OpenEXR ])<br>
<br>
---<br>
<br>
I force-disabled openEXR probe so it will NOT pick up system headers/libs,<br>
discovered new includes demand -std=c++11 in CFLAGS :}<br>
<br>
seems to work ....<br>
-- <br>
Cin mailing list<br>
<a href="mailto:Cin@lists.cinelerra-gg.org" target="_blank">Cin@lists.cinelerra-gg.org</a><br>
<a href="https://lists.cinelerra-gg.org/mailman/listinfo/cin" rel="noreferrer" target="_blank">https://lists.cinelerra-gg.org/mailman/listinfo/cin</a><br>
</blockquote></div>