<div dir="ltr"><div dir="ltr"><div class="gmail_default" style="font-size:small">Andrew,<br></div></div><div class="gmail_quote"><blockquote class="gmail_quote" style="margin:0px 0px 0px 0.8ex;border-left:1px solid rgb(204,204,204);padding-left:1ex">try this patch? <br><br></blockquote><div><span class="gmail_default" style="font-size:small">Thanks for the patch - I should have known the fix went into ffmpeg.C instead of fileffmpeg.C. Sorry for getting it wrong.</span></div><div><span class="gmail_default" style="font-size:small"><br></span></div><div><span class="gmail_default" style="font-size:small">BUT, the bad news is that the patch + uncommenting the </span> ff->video_probe(1);<span class="gmail_default" style="font-size:small"> line in fileffmpeg.C does not solve the</span></div><div><span class="gmail_default" style="font-size:small">use of extra memory. It seemed like it might have though. I finally found a definitive test case and this time saved it</span></div><div><span class="gmail_default" style="font-size:small">so I could find it again. <span class="gmail_default" style="font-size:small"><br></span></span></div><div><span class="gmail_default" style="font-size:small"><br></span></div><div><span class="gmail_default" style="font-size:small">Bummer. Since I often make mistakes, I ran it several times and verified that I correctly had the lines right. The <br></span></div><div><span class="gmail_default" style="font-size:small">results were consistent -- as soon as I uncommented "ff->video_probe(1); in fileffmpeg.C" whether or not the patch</span></div><div><span class="gmail_default" style="font-size:small">to ffmpeg.C was in, the memory usage went up about 18%.<br></span></div><blockquote class="gmail_quote" style="margin:0px 0px 0px 0.8ex;border-left:1px solid rgb(204,204,204);padding-left:1ex"><br><blockquote class="gmail_quote" style="margin:0px 0px 0px 0.8ex;border-left:1px solid rgb(204,204,204);padding-left:1ex"><div class="gmail_quote"><div dir="ltr" class="gmail_attr">On Mon, May 3, 2021 at 10:09 PM Andrew Randrianasulu via Cin <<a href="mailto:cin@lists.cinelerra-gg.org" target="_blank">cin@lists.cinelerra-gg.org</a>> wrote:<br></div><blockquote class="gmail_quote" style="margin:0px 0px 0px 0.8ex;border-left:1px solid rgb(204,204,204);padding-left:1ex">I think I spotted my error, resulting in memory leak..<div><br></div><div>Try to add </div><div><br></div><div>av_frame_free(&frame);</div><div><br></div><div>Just before return ret; line.. { line 1246 currently?} </div><div><br></div><div>And after this re-enable line disabled in </div><div>commit eabda9cf447580a974fd3d67a3d0a26f09aeb523</div><div><br></div><div>ff->video_probe(1); in fileffmpeg.C </div><div><br></div><div>And of course re-test ( i probably loaded only very small project or number of files for noticing this.. :/) </div><br></blockquote></div></blockquote>
</blockquote></div></div>