rebased on top of this ) <div><br></div><div><br><br>On Tuesday, July 20, 2021, Phyllis Smith <<a href="mailto:phylsmith2017@gmail.com">phylsmith2017@gmail.com</a>> wrote:<br><blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex"><div dir="ltr"><div dir="ltr"><div class="gmail_default" style="font-size:small">These changes as provided by Andrew have been checked into GIT (finally! finished testing and checking):</div><div class="gmail_default" style="font-size:small"><br></div><div class="gmail_default" style="font-size:small">0003-Attempt-at-<wbr>differenciating-601-pal-and-<wbr>ntsc.patch</div><div class="gmail_default" style="font-size:small"></div><div class="gmail_default" style="font-size:small"></div><div class="gmail_default" style="font-size:small">0004-Fix-yuv_color_space-menu-<wbr>after-adding-bt601-variants.<wbr>patch</div><div class="gmail_default" style="font-size:small">0005-Add-comment-about-order-<wbr>of-array-entries-for-yuv_col.<wbr>patch</div><div class="gmail_default" style="font-size:small">0006-Forgot-to-alter-<wbr>colorspace-plugin-for-bt2020-<wbr>split.patch</div><div class="gmail_default" style="font-size:small">0006-Slightly-enlarge-<wbr>colirspace-menu-width.patch</div><div class="gmail_default" style="font-size:small">0007-Attempt-at-<wbr>differenciating-bt2020-ncl-vs-<wbr>bt2020-cl.patch<br></div><div class="gmail_default" style="font-size:small">0056-Add-simple-validation-<wbr>for-yuv_color_space-prevent-<wbr>cr.patch<br>0057-Add-two-more-checks-for-<wbr>Cinelerra_rc-loading.patch</div><div class="gmail_default" style="font-size:small"><br></div><div class="gmail_default" style="font-size:small">Or in randrik9 tar from Jul 17th:</div><div class="gmail_default" style="font-size:small"><br></div><div class="gmail_default" style="font-size:small">0041-Attempt-at-<wbr>differenciating-601-pal-and-<wbr>ntsc.patch<br>0042-Fix-yuv_color_space-menu-<wbr>after-adding-bt601-variants.<wbr>patch<br>0043-Add-comment-about-order-<wbr>of-array-entries-for-yuv_col.<wbr>patch<br>0044-Slightly-enlarge-<wbr>colirspace-menu-width.patch<br>0045-Attempt-at-<wbr>differenciating-bt2020-ncl-vs-<wbr>bt2020-cl.patch<br>0046-Forgot-to-alter-<wbr>colorspace-plugin-for-bt2020-<wbr>split.patch</div><div class="gmail_default" style="font-size:small">+</div><div class="gmail_default" style="font-size:small">+<br></div><br><div class="gmail_default" style="font-size:small"><br></div><div class="gmail_default" style="font-size:small"><br></div><div class="gmail_default" style="font-size:small"><br></div></div></div><br><div class="gmail_quote"><div dir="ltr" class="gmail_attr">On Sun, Jul 18, 2021 at 5:20 PM Andrew Randrianasulu <<a href="mailto:randrianasulu@gmail.com" target="_blank">randrianasulu@gmail.com</a>> wrote:<br></div><blockquote class="gmail_quote" style="margin:0px 0px 0px 0.8ex;border-left:1px solid rgb(204,204,204);padding-left:1ex"><br><br>On Monday, July 19, 2021, Andrew Randrianasulu <<a href="mailto:randrianasulu@gmail.com" target="_blank">randrianasulu@gmail.com</a>> wrote:<br><blockquote class="gmail_quote" style="margin:0px 0px 0px 0.8ex;border-left:1px solid rgb(204,204,204);padding-left:1ex">try this patch, it should preven crash in patched cin if you manually or programmatically set yuv_color_space to number cin does not recognize (but I am afraid iriginal cingg also can be crashed by just manually editing Cinelerra_rc and setting this (or even some similar) line to wrong value.. some generic validation pass nedded for preventing this..) </blockquote><div><br></div><div><br></div><div> two more checks for color range and vicon colors... apply on top of 0056 (I forgot to decrement index by 1 so it was not crashing on yuv_color_space 5, but this was illegal value) </div><div><br></div><div>if this specific vulnerability not mentioned yet in manul - I think it deserves line or two.. (randomly editing Cinelerra_rc easily result in crash at access...) </div><div><br></div><div><br></div><blockquote class="gmail_quote" style="margin:0px 0px 0px 0.8ex;border-left:1px solid rgb(204,204,204);padding-left:1ex"><br>On Monday, July 19, 2021, Andrew Randrianasulu <<a href="mailto:randrianasulu@gmail.com" target="_blank">randrianasulu@gmail.com</a>> wrote:<br><blockquote class="gmail_quote" style="margin:0px 0px 0px 0.8ex;border-left:1px solid rgb(204,204,204);padding-left:1ex"><br><br>On Monday, July 19, 2021, Phyllis Smith <<a href="mailto:phylsmith2017@gmail.com" target="_blank">phylsmith2017@gmail.com</a>> wrote:<br><blockquote class="gmail_quote" style="margin:0px 0px 0px 0.8ex;border-left:1px solid rgb(204,204,204);padding-left:1ex"><div dir="ltr"><div class="gmail_default" style="font-size:small">More testing of "color hell" has been completed here<br></div><div class="gmail_default" style="font-size:small">I "think" that I have tested enough to check this into GIT, as long as users can tolerate the following that have workarounds:<br></div><div class="gmail_default" style="font-size:small">There are 2 problems that occur when going back to a previous Cinelerra version:</div><div class="gmail_default" style="font-size:small"> 1) if you set YUV Color Space to 601_PAL and save settings and then load in a previous version, it crashes.</div></div></blockquote><div><br></div><div>ow, this is bad ( </div><div><br></div><div>probably this array I expanded in patch overflows... </div><div> </div><blockquote class="gmail_quote" style="margin:0px 0px 0px 0.8ex;border-left:1px solid rgb(204,204,204);padding-left:1ex"><div dir="ltr"><div class="gmail_default" style="font-size:small"> 2) if you set YUV Color Space to 2020_CL and save settings and then load in a previous version, the Color Space will report either "Low" or "JPEG"<br></div></div></blockquote><div><br></div><div><br></div><div>hm, something steps on someone's else toes.. </div><div><br></div><div>not sure if it really desirable to merge in such state, may be I'll find way to move few fields around first.. </div><blockquote class="gmail_quote" style="margin:0px 0px 0px 0.8ex;border-left:1px solid rgb(204,204,204);padding-left:1ex"><div dir="ltr"></div><br><div class="gmail_quote"><div dir="ltr" class="gmail_attr">On Sat, Jul 17, 2021 at 12:47 PM Andrew Randrianasulu <<a href="mailto:randrianasulu@gmail.com" target="_blank">randrianasulu@gmail.com</a>> wrote:<br></div><blockquote class="gmail_quote" style="margin:0px 0px 0px 0.8ex;border-left:1px solid rgb(204,204,204);padding-left:1ex"><br><br>On Saturday, July 17, 2021, Phyllis Smith <<a href="mailto:phylsmith2017@gmail.com" target="_blank">phylsmith2017@gmail.com</a>> wrote:<br><blockquote class="gmail_quote" style="margin:0px 0px 0px 0.8ex;border-left:1px solid rgb(204,204,204);padding-left:1ex"><div dir="ltr"><div class="gmail_default" style="font-size:small">Andrew,</div><div class="gmail_default" style="font-size:small">Sorry but I have not found any difference between 601 Pal and 601 NTSC other than what ffprobe reports. The video looks 100% identical. Perhaps I am doing something wrong. Here is what I did:</div><div class="gmail_default" style="font-size:small"><br></div><div class="gmail_default" style="font-size:small">1) downloaded Cows 4k.webm (do not remember exact name)</div><div class="gmail_default" style="font-size:small">2) deleted most of it so it does not take so long to render</div><div class="gmail_default" style="font-size:small">3) set Format to YUV-8</div><div class="gmail_default" style="font-size:small">4) set Preferences/Appearances/YUV color space to 601 NTSC</div><div class="gmail_default" style="font-size:small">5) render using h2674.mp4</div><div class="gmail_default" style="font-size:small">...6) Then reloaded shortened Cows, set Format to YUV-8 and color space to 601 PAL, rendered.</div><div class="gmail_default" style="font-size:small">7) ran ydiff on the 2 output videos and the result is that the video is 100% the same <br></div><div class="gmail_default" style="font-size:small">8) ffprobe does report smpte170m (for NTSC) ersus bt470bg (for PAL)</div><div class="gmail_default" style="font-size:small"><br></div><div class="gmail_default" style="font-size:small">So I am either doing something wrong, or splitting 601 and 2020 is just not relevant. I have to do another 2020 split test yet.</div></div></blockquote><div><br></div><div>may be player/nle supposed to alter video depending on those tags? so it will be visible not in encoded file but after full decoding + display IF player reacts correctly to those attribs (many do not care) </div><div> </div><blockquote class="gmail_quote" style="margin:0px 0px 0px 0.8ex;border-left:1px solid rgb(204,204,204);padding-left:1ex"><div dir="ltr"><div class="gmail_default" style="font-size:small">Also, when I load one of the output files in a previous version of Cinelerra without the mod, the Color Space comes up as "low" -- where that came from I have no idea.<br></div></div></blockquote><div><br></div><div><br></div><div>i altered not just encoding part but also decoding/internal colorspace conversion paths - because original code does so... so different reactions to same input kinda expected? </div><div><br></div><div>may be you can put my patches in separate branch, incl. other 'staging' patches (termux, h265-multilib, exr batchrender...)? so they will be available easily yet not interfere with main branch yet... </div><div><br></div><div><br></div><blockquote class="gmail_quote" style="margin:0px 0px 0px 0.8ex;border-left:1px solid rgb(204,204,204);padding-left:1ex"><div dir="ltr"></div><br><div class="gmail_quote"><div dir="ltr" class="gmail_attr">On Wed, Jul 14, 2021 at 12:47 PM Andrew Randrianasulu <<a href="mailto:randrianasulu@gmail.com" target="_blank">randrianasulu@gmail.com</a>> wrote:<br></div><blockquote class="gmail_quote" style="margin:0px 0px 0px 0.8ex;border-left:1px solid rgb(204,204,204);padding-left:1ex">I made those commits into new series, you probably want to rename this to 0009-*.patch... I do not think old 0008 patch will do any good - GReen-BLue-REd planar float format is not something Cin easily can convert for internal use (I saw similar comment in oiio sources... I am not good enough for adding even simple format to ffmpeg/swscale.. even with already written examples) <div><br></div><div>from</div><div><br></div><div><a href="https://github.com/OpenImageIO/oiio/blob/master/src/ffmpeg.imageio/ffmpeginput.cpp" target="_blank">https://github.com/<wbr>OpenImageIO/oiio/blob/master/<wbr>src/ffmpeg.imageio/<wbr>ffmpeginput.cpp</a><br><div><br></div><div>case AV_PIX_FMT_GBRPF32BE:</div><div> case AV_PIX_FMT_GBRPF32LE:</div><div> nchannels = 3;</div><div> datatype = TypeFloat;</div><div> m_dst_pix_format = AV_PIX_FMT_RGB48; // ? AV_PIX_FMT_GBRPF32</div><div> // FIXME: They don't have a type for RGB float, only GBR float.</div><div> // Yuck. Punt for now and save as uint16 RGB. If people care, we</div><div> // can return and ask for GBR float and swap order.</div><div> break;<br><div><br></div><div><br><br>On Wednesday, July 14, 2021, Andrea paz <<a href="mailto:gamberucci.andrea@gmail.com" target="_blank">gamberucci.andrea@gmail.com</a>> wrote:<br><blockquote class="gmail_quote" style="margin:0px 0px 0px 0.8ex;border-left:1px solid rgb(204,204,204);padding-left:1ex">I tried to compile with the two patches 0007 and 0008, but the<br>
compilation gives an error. I append the cin5.log, if it helps.<br>
</blockquote></div></div></div>
</blockquote></div>
</blockquote>
</blockquote></div>
</blockquote>
</blockquote>
</blockquote>
</blockquote></div>
</blockquote></div>