<div dir="ltr"><div class="gmail_default" style="font-size:small">For Truehd, in bdwrite.C getting error message as shown in second Bold below when 004 ffmpeg truehd new 4 patches added.</div><div class="gmail_default" style="font-size:small">In addition it shows "case 2" as STEREO although earlier in the code it is "3" as shown immediately below (and COMBO 12 not handled).</div><div class="gmail_default" style="font-size:small"><br></div><div class="gmail_default" style="font-size:small">  BLURAY_AUDIO_FORMAT_MONO = 1,<br>  <b>BLURAY_AUDIO_FORMAT_STEREO = 3,</b><br>  BLURAY_AUDIO_FORMAT_MULTI_CHAN = 6,<br>  BLURAY_AUDIO_FORMAT_COMBO = 12,   // Stereo ac3/dts,</div><div class="gmail_default" style="font-size:small">...<br></div><div class="gmail_default" style="font-size:small">static int bd_audio_format(int channels)<br>{<br>  int audio_format = 0;<br>  switch( channels ) {<br>  case 1:<br>    audio_format = BLURAY_AUDIO_FORMAT_MONO;<br>    break;<br>  case 2:<br>    audio_format = BLURAY_AUDIO_FORMAT_STEREO;<br>    break;<br>  case 6:<br>    audio_format = BLURAY_AUDIO_FORMAT_MULTI_CHAN;<br>    break;<br>  default:<br>    fprintf(stderr, <b>"unknown bluray audio format %d ch\n", channels</b>);<br>    exit(1);<br>  }<br>  return audio_format;<br>}<br></div></div><br><div class="gmail_quote"><div dir="ltr" class="gmail_attr">On Mon, Apr 18, 2022 at 10:33 PM Andrew Randrianasulu <<a href="mailto:randrianasulu@gmail.com">randrianasulu@gmail.com</a>> wrote:<br></div><blockquote class="gmail_quote" style="margin:0px 0px 0px 0.8ex;border-left:1px solid rgb(204,204,204);padding-left:1ex"><br><br>On Tuesday, April 19, 2022, Phyllis Smith <<a href="mailto:phylsmith2017@gmail.com" target="_blank">phylsmith2017@gmail.com</a>> wrote:<br><blockquote class="gmail_quote" style="margin:0px 0px 0px 0.8ex;border-left:1px solid rgb(204,204,204);padding-left:1ex"><div dir="ltr"><div class="gmail_default" style="font-size:small">Forgot to add that this patch also applied and result checked in even though not yet functional:<br></div><div class="gmail_default" style="font-size:small">   0012-truehd-experimental-bluray-profile.patch</div></div><br><div class="gmail_quote"><div dir="ltr" class="gmail_attr">On Mon, Apr 18, 2022 at 6:21 PM Phyllis Smith <<a href="mailto:phylsmith2017@gmail.com" target="_blank">phylsmith2017@gmail.com</a>> wrote:<br></div><blockquote class="gmail_quote" style="margin:0px 0px 0px 0.8ex;border-left:1px solid rgb(204,204,204);padding-left:1ex"><div dir="ltr"><div style="font-size:small" class="gmail_default">Checked into GIT from megapile_8 the patches related to creating Bluray media by Andrew:</div><div style="font-size:small" class="gmail_default"><br></div>0005-EXPERIMENT-update-bdwrite-for-lpcm-hevc.patch<br>0006-EXPERIMENTAL-add-variable-chapter-interval-to-bdwrit.patch<br>0007-EXPERIMENTAL-add-bd_profile-array-to-bdcreate.C-so-i.patch<br>0008-EXPERIMENTAL-bdcreate-add-m2ts-profiles-part-1.patch<br>0009-Fix-bdcreate.C-layout.patch<br><div>0010-EXPERIMENTAL-attempt-to-get-value-from-popuptextbox.patch0012-truehd-experimental-bluray-profile.patch<br>0013-EXPERIMENTAL-add-truehd-audio-profile-for-bdcreate.C.patch<br>0014-EXPERIMENTAL-add-tsmuxer-checkbox.patch<br>0015-EXPERIMENTAL-fix-layout-in-bdcreate-after-tsmuxer-ch.patch<br>0016-NOT-YET.patch<br>0017-EXPERIMENTAL-shell-script-run-tsmuxer-conditionally-.patch<br>0018-Attempt-at-fixing-bdwrite-stream_type-coding_type-co.patch<br>0019-EXPERIMENTAL-attempt-at-fixing-bdwrite-on-Android-af.patch<br>0020-EXPERIMENTAL-real-fix-for-bdwrite.patch<br>0021-EXPERIMENTAL-try-to-add-lpcm-to-tsmuxer-meta-file.patch<br>0022-EXPERIMENTAL-really-fix-audio-names-fir-tsmuxer-meta.patch<span class="gmail_default" style="font-size:small"> <br></span></div><div><span class="gmail_default" style="font-size:small">0037-freebsd-in-bdcreate-bdwrite.patch</span></div><div><span class="gmail_default" style="font-size:small">  and from megapile_10:<br></span></div><div><span class="gmail_default" style="font-size:small"></span>0077-Better-layout-in-bdcreate.C-after-my-changes.patch</div><div><br></div><div><div style="font-size:small" class="gmail_default">Already in from a previous checkin as related to Bluray from megapile_8 were:</div><div style="font-size:small" class="gmail_default"></div>0001-ffmpeg-4.4-bluray-lpcm-encoder.patch<br>0002-Fix-ffmpeg-4.4-bluray-lpcm-patch-for-5.1.patch<br>0003-Add-simple-m2ts-lpcm-profile.patch</div><div>0011-Rename-m2ts_pcm.m2ts-to-bluray_lpcm.m2ts.patch</div><div><div style="font-size:small" class="gmail_default"></div><div style="font-size:small" class="gmail_default">But because I forgot to test    0004-Improve-truehd-decoder-encoder-from-ffmpeg.git.patch   the choice in bdcreate.C for truehd (line 865) was commented out until I can test a smaller set tomorrow.  Although <b>I am confused why the following lines of code (around line 70) in bdcreate.C do not include truehd as an option???</b>  I looked in megapile_10 to see if I missed a related patch but did not see anything.<br></div><div style="font-size:small" class="gmail_default"><span style="font-family:monospace">   static struct bd_profile {<br>        const char *name;<br>} bd_profiles[] = {<br>        {"bluray.m2ts"},<br>        {"bluray_lpcm.m2ts"},<br>};</span><br></div><div style="font-size:small" class="gmail_default"></div></div></div></blockquote></div></blockquote><div><br></div><div><br></div><div>I think I just did things a little bit different,  so may be  this piece if code no longer needed -  need to look again (just wake up) </div><div><br></div><div><br></div><blockquote class="gmail_quote" style="margin:0px 0px 0px 0.8ex;border-left:1px solid rgb(204,204,204);padding-left:1ex"><div class="gmail_quote"><blockquote class="gmail_quote" style="margin:0px 0px 0px 0.8ex;border-left:1px solid rgb(204,204,204);padding-left:1ex"><div dir="ltr"><div><div style="font-size:small" class="gmail_default"></div><br></div><div><div style="font-size:small" class="gmail_default">and around line 350 (and maybe other places too?):</div><div style="font-size:small" class="gmail_default">        <span style="font-family:monospace">fprintf(fp,"MUXOPT --blu-ray --hdmv-descriptors\n");<br>        fprintf(fp,"V_MPEG4/ISO/AVC, bd.m2ts, track=4113\n");<br>        if(!strcmp(use_profile, "bluray.m2ts"))<br>        fprintf(fp,"A_AC3, bd.m2ts, track=4352\n");<br>        if(!strcmp(use_profile, "bluray_lpcm.m2ts"))<br>        fprintf(fp,"A_LPCM, bd.m2ts, track=4352\n");<br>        fprintf(fp,"\n");<br>        fclose(fp);</span><br></div><div style="font-size:small" class="gmail_default"></div></div></div></blockquote></div></blockquote><div><br></div><div><br></div><div><br></div><div>yes, not yet for tsmuxer - not quite sure how it works there (latery I read truehd must come with ac3 'core' embedded, not sure if ffmpeg can output this in one pass? - <a href="https://forum.doom9.org/showthread.php?t=176668&page=61" target="_blank">https://forum.doom9.org/showthread.php?t=176668&page=61</a> - comment 1202 and around...) </div><div><br></div><div>it will be very interesting to hear from your experiment! </div><div><br></div><div><br></div><blockquote class="gmail_quote" style="margin:0px 0px 0px 0.8ex;border-left:1px solid rgb(204,204,204);padding-left:1ex"><div class="gmail_quote"><blockquote class="gmail_quote" style="margin:0px 0px 0px 0.8ex;border-left:1px solid rgb(204,204,204);padding-left:1ex"><div dir="ltr"><div><div style="font-size:small" class="gmail_default"></div><div style="font-size:small" class="gmail_default"></div><br></div><div class="gmail_quote"><blockquote class="gmail_quote" style="margin:0px 0px 0px 0.8ex;border-left:1px solid rgb(204,204,204);padding-left:1ex">oh YES, you are right, I swapped those unintentionally! <div><br></div><div>probably explains your bug with chapters? <br></div></blockquote><div><span class="gmail_default" style="font-size:small">YOU ARE RIGHT ! now chapters work (hopefully you understand why it takes me so long to test and check in changes as I do not want to add problems -- the oxen is slow, but the earth is patient).</span></div><div></div></div></div></blockquote></div></blockquote><div><br></div><div><br></div><div>yes, very big thanks for  NOT rushing things out! </div><blockquote class="gmail_quote" style="margin:0px 0px 0px 0.8ex;border-left:1px solid rgb(204,204,204);padding-left:1ex"><div class="gmail_quote"><blockquote class="gmail_quote" style="margin:0px 0px 0px 0.8ex;border-left:1px solid rgb(204,204,204);padding-left:1ex"><div dir="ltr"><div class="gmail_quote"><div></div><div><span class="gmail_default" style="font-size:small"><br></span></div><div><span class="gmail_default" style="font-size:small">"lpcm" works too and when I press the "info" button on the remote control on the LG bluray player, it clearly shows it is lpcm -- this not working was my mistake due to not getting the current GIT head.<br></span></div><div></div></div></div></blockquote></div></blockquote><div><br></div><div>\0/ </div>
</blockquote></div>