<div dir="auto"><div><br><br><div class="gmail_quote"><div dir="ltr" class="gmail_attr">сб, 10 мая 2025 г., 11:14 Andrew Randrianasulu <<a href="mailto:randrianasulu@gmail.com" target="_blank" rel="noreferrer">randrianasulu@gmail.com</a>>:<br></div><blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex">On Sat, May 10, 2025 at 9:05 AM Paul B Mahol <<a href="mailto:onemda@gmail.com" rel="noreferrer noreferrer" target="_blank">onemda@gmail.com</a>> wrote:<br>
><br>
><br>
><br>
> On Fri, May 9, 2025 at 11:38 PM Andrew Randrianasulu <<a href="mailto:randrianasulu@gmail.com" rel="noreferrer noreferrer" target="_blank">randrianasulu@gmail.com</a>> wrote:<br>
>><br>
>> I was looking at why our application (cinelerra-gg) crashed at trying to use libplacebo<br>
>><br>
>> I found that libplacebo defines itself<br>
>><br>
>> <a href="https://ffmpeg.org/doxygen/7.0/vf__libplacebo_8c.html" rel="noreferrer noreferrer noreferrer" target="_blank">https://ffmpeg.org/doxygen/7.0/vf__libplacebo_8c.html</a><br>
>><br>
>> as<br>
>><br>
>> .flags = AVFILTER_FLAG_HWDEVICE | AVFILTER_FLAG_DYNAMIC_INPUTS,<br>
>><br>
>> so only output pad is defined, as far as I can see:<br>
>><br>
>> static const AVFilterPad libplacebo_outputs[] = {<br>
>> {<br>
>> .name = "default",<br>
>> .type = AVMEDIA_TYPE_VIDEO,<br>
>> .config_props = &libplacebo_config_output,<br>
>> },<br>
>> };<br>
>><br>
>><br>
>><br>
>> then when our code calls<br>
>><br>
>> avfilter_pad_get_type()<br>
><br>
><br>
> You need to call it only after filtergraph have been configured, not before because in such cases number of output pads may be 0 before configuration.<br>
> In any case you need to check current number of input pads and output pads for each filter before trying to access them.<br>
><br>
<br>
Thanks. Attached patch makes this crash go away, just 32-bit cingg<br>
can't cope with 4k frames filtering en-masse :)<br>
<br>
Andrea, can you test attached patch + this opts file put alongside<br>
test 4k HDR video decodable by hardware?<br></blockquote></div></div><div dir="auto"><br></div><div dir="auto">Aw, tried to reduce resolution to very barest minimum allowed by hevc encoder (228*128!) and while libplacebo works (sloowly!) with software decoder, it does not produce good frames with Vulkan hw decoder (even if I seen in nvtop hw decoder really runs sometimes at close to 100%).</div><div dir="auto"><br></div><div dir="auto">So, something confuses libplacebo greatly if used like this. </div><div dir="auto"><br></div><div dir="auto">I also tried *_vulkan filters on input, hoping they will also pick up hw vulkan decoding device but apparently no?</div><div dir="auto"><br></div><div dir="auto"><div class="gmail_quote"><blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex">
<br>
<br>
<br>
><br>
>><br>
>><br>
>> it promptly crashes.<br>
>><br>
>> BC_Signals::dump_stack<br>
>> cin() [0x8b2c9e2]<br>
>> linux-gate.so.1(__kernel_rt_sigreturn+0) [0xf7fb8590]<br>
>> cin(avfilter_pad_get_type+0x14) [0x99266a4]<br>
>> cin(_ZN13FFVideoStream13create_filterEPKc+0xbc) [0x865669c]<br>
>> cin(_ZN6FFMPEG12open_decoderEv+0x80f) [0x865732f]<br>
>> cin(_ZN10FileFFMPEG9check_sigEP5Asset+0x81) [0x8670071]<br>
>> cin(_ZN4File5probeEv+0x376) [0x867cd86]<br>
>> cin(_ZN4File9open_fileEP11PreferencesP5Assetii+0x378) [0x867d628]<br>
>> cin(_ZN7MWindow14load_filenamesEP9ArrayListIPcEiii+0x250) [0x87301f0]<br>
>> cin(_ZN17CommandLineThread3runEv+0x53) [0x86e2cd3]<br>
>> cin(_ZN6Thread10entrypointEPv+0x41) [0x8b70c11]<br>
>> /lib/libpthread.so.0(+0x7328) [0xf7df9328]<br>
>> /lib/libc.so.6(clone+0x66) [0xf0373f06]<br>
>><br>
>><br>
>><br>
>> We still hope to get libplacebo's tonemapping + vulkan hevc decoding going, so any pointers how to talk to those dynamic_input filters will be useful. Even swscale is dynamic_input in ffmpeg 7.1+, so I (we) really hope to keep it working, too.<br>
>><br>
>> Code:<br>
>><br>
>> <a href="https://git.cinelerra-gg.org/git/?p=goodguy/cinelerra.git;a=blob;f=cinelerra-5.1/cinelerra/ffmpeg.C;h=1d0979df59f932628246678a920aca002d8dd88b;hb=HEAD#l3893" rel="noreferrer noreferrer noreferrer" target="_blank">https://git.cinelerra-gg.org/git/?p=goodguy/cinelerra.git;a=blob;f=cinelerra-5.1/cinelerra/ffmpeg.C;h=1d0979df59f932628246678a920aca002d8dd88b;hb=HEAD#l3893</a><br>
>><br>
>><br>
>><br>
>> _______________________________________________<br>
>> Libav-user mailing list<br>
>> <a href="mailto:Libav-user@ffmpeg.org" rel="noreferrer noreferrer" target="_blank">Libav-user@ffmpeg.org</a><br>
>> <a href="https://ffmpeg.org/mailman/listinfo/libav-user" rel="noreferrer noreferrer noreferrer" target="_blank">https://ffmpeg.org/mailman/listinfo/libav-user</a><br>
>><br>
>> To unsubscribe, visit link above, or email<br>
>> <a href="mailto:libav-user-request@ffmpeg.org" rel="noreferrer noreferrer" target="_blank">libav-user-request@ffmpeg.org</a> with subject "unsubscribe".<br>
><br>
> _______________________________________________<br>
> Libav-user mailing list<br>
> <a href="mailto:Libav-user@ffmpeg.org" rel="noreferrer noreferrer" target="_blank">Libav-user@ffmpeg.org</a><br>
> <a href="https://ffmpeg.org/mailman/listinfo/libav-user" rel="noreferrer noreferrer noreferrer" target="_blank">https://ffmpeg.org/mailman/listinfo/libav-user</a><br>
><br>
> To unsubscribe, visit link above, or email<br>
> <a href="mailto:libav-user-request@ffmpeg.org" rel="noreferrer noreferrer" target="_blank">libav-user-request@ffmpeg.org</a> with subject "unsubscribe".<br>
</blockquote></div></div></div>