[Cin] Typo in git commit e23393f4ff9f772ac8f47926cf490dc87a630ed4 ?

[Andrew Randrianasulu]

Hello all!

Just watching development from aside for now ...
In commit log it says:

"add grouping, default proxy vcodec h264.mp4, default titlebar alpha=1, green 
bar bug"

yet in cinelerra-5.1/cinelerra/proxy.C

change reads as

https://git.cinelerra-gg.org/git/?p=goodguy/cinelerra.git;a=blobdiff;f=cinelerra-5.1/cinelerra/proxy.C;h=e368c17c0a860c3d2e56918c0855de2af39bb49c;hp=4394120d916f1f77006a6dfac7ff656dfc154674;hb=e23393f4ff9f772ac8f47926cf490dc87a630ed4;hpb=d5a0afb9bc8562f6c2698f88ff40790009a5e63c

diff --git a/cinelerra-5.1/cinelerra/proxy.C b/cinelerra-5.1/cinelerra/proxy.C

index 4394120..e368c17 100644 (file)


--- a/cinelerra-5.1/cinelerra/proxy.C
+++ b/cinelerra-5.1/cinelerra/proxy.C
@@ -50,6 +50,7 @@
 #define WIDTH 400
 #define HEIGHT 330
 #define MAX_SCALE 16
+#define PROXY_DEFAULT_VCODEC "h265.mp4"
 
 ProxyMenuItem::ProxyMenuItem(MWindow *mwindow)
  : BC_MenuItem(_("Proxy settings..."),  _("Alt-r"), 'r')
@@ -82,6 +83,7 @@ ProxyDialog::ProxyDialog(MWindow *mwindow)
        this->mwindow = mwindow;
        gui = 0;
        asset = new Asset;
+       strcpy(asset->vcodec, PROXY_DEFAULT_VCODEC);
        bzero(size_text, sizeof(char*) * MAX_SIZES);
        bzero(size_factors, sizeof(int) * MAX_SIZES);
        size_text[0] = cstrdup(_("Original size"));

---------------------

so, it is really h264 or h265? h265 used to be slower .... And why so 
heavily-compressed vcodec anyway, I was always thinking about mjpeg or friends 
as best choice for proxies?