[Cin] Re3: Blu-ray encoding again

[Andrew Randrianasulu]

В сообщении от Sunday 17 November 2019 04:12:52 Phyllis Smith написал(а):
> Andrew,
> 
> >  I can not get x264-params to work with tff or bff added at the end of the
> > statement.  I even tried tff=1 and still does not work.
> >
> I did finally get x264-params to work correctly so I withdraw that
> question.  Apparently, I just kept making mistakes.
> 
> have yet to have him look into the bdcreate.C changes
> >
> GG did look at your patch.  Previously he had changed "putting the bff and
> tff" on the end of the opts line to be smarter so that these could go into
> the options files instead.   So we can at least add the 3 missing
> 1920x1080p... possible types.  And I "think" that you are saying below that
> the "pulldown" option is not complete so we should not add it.

Yes, while I was thinking about just reusing  complied x264 binary 
much like mpeg2enc was used. But this will complicate muxing.

I'll try to patch libx264 inside ffmpeg, but those frame-time manipulations 
still not something I can easily check (may be in Avidemux2?)

> 
> On Sat, Nov 16, 2019 at 12:57 AM Andrew Randrianasulu <
> randrianasulu at gmail.com> wrote:
> 
> >
> > No, apparently pulldown option requres more handling:
> >
> > from x264.h
> >
> >    /* Pulldown:
> >      * The correct pic_struct must be passed with each input frame.
> >      * The input timebase should be the timebase corresponding to the
> > output framerate. This should be constant.
> >      * e.g. for 3:2 pulldown timebase should be 1001/30000
> >      * The PTS passed with each frame must be the PTS of the frame after
> > pulldown is applied.
> >      * Frame doubling and tripling require b_vfr_input set to zero (see
> > H.264 Table D-1)
> >      *
> >      * Pulldown changes are not clearly defined in H.264. Therefore, it is
> > the calling app's responsibility to manage this.
> >      */
> >
> > so, no for now.
> >
> 
> 
> > I tried to see if scaling checkbox in BD creation dialog worked,
> >
> I will look into scaling as it was working but I have not looked at it for
> a long time so need to refresh my memory.

I think they still work in English locale, so try few non-English ones too?
I tried to put setlocale call into bdcreate.C, but it was not enough ....

> 
> >
> > actually, I think for current time jsut commented  bluray.m2ts opts file
> > should work....
> > with just  struct bd_format expansion, because I don't know how to add
> > correctly
> > line or two inside already-read opts file (my x264-opts editing was not
> > accepted by ffmpeg)
> >
> >
>