[Cin] Use MAXCHANNELS define in mwindow.C
randrianasulu at gmail.com
Sat Nov 21 12:13:42 CET 2020
В сообщении от Saturday 21 November 2020 14:06:48 Igor BEGHETTO via Cin написал(а):
> Andrew and all,
> Here an example because I think it was right as before.
> In the screencast I am using a video file by Pierre (
> ) to show what I said.
> The source video "NTSC_SD_DV25_colorbar.avi" has 8 audio stereo
> channels. So, with your change, Cinelerra-GG will create 16 audio
> channels instead of 6, because MAXCHANNELS=32. IMHO, I think it would be
> too much.
well, today you can hide/fold them behind gang mode ...?
But yes, I did this change especially due to this file.
Most of those channels in this specific file are empty (only 4 are carrying sound), but for me this showed fact files with more than 6 ch. exist, and so loading them will raise '?' in user ....
I even saw talk about something like 20+ ch. surround audio at ffmpeg-devel (but I have no such file yet to test).
(I don't think Cin can do real 3d sound, it all confined to single horizontal plane, yet such strangeness [128 core + 64 loudspeakers max!] now exist .....)
You always can delete unneeded tracks, but from what I recall loading 4ch audio + 1 ch. video file to 1 vid ch/2 aud. ch project will result in some reposition of audio tracks, enlarging project's total timeline ....
But to be honest right now I'm unsure and much more concerned about who will land any of those mods .... this particular change can be dropped, but who will apply others ....
> You can confirm or less if that code is for that feature.
> Screencast to https://streamable.com/woem2b
> Il 19/11/2020 03:07, Andrew Randrianasulu via Cin ha scritto:
> > so I used it for max number of channels for auto-created project (was just 6):
> > diff --git a/cinelerra-5.1/cinelerra/mwindow.C b/cinelerra-5.1/cinelerra/mwindow.C
> > index f245018a..690c7ef8 100644
> > --- a/cinelerra-5.1/cinelerra/mwindow.C
> > +++ b/cinelerra-5.1/cinelerra/mwindow.C
> > @@ -5088,7 +5107,7 @@ int MWindow::select_asset(Asset *asset, int vstream, int astream, int delete_tra
> > int channels = 0;
> > for( uint64_t mask=channel_mask; mask!=0; mask>>=1 ) channels += mask& 1;
> > if( channels< 1 ) channels = 1;
> > - if( channels> 6 ) channels = 6;
> > + if( channels> MAXCHANNELS ) channels = MAXCHANNELS;
> > session->audio_tracks = session->audio_channels = channels;
> > int *achannel_positions = preferences->channel_positions[session->audio_channels-1];
> > =====
More information about the Cin