[Cin] in/out point selected plugin attach fix?

[Andrew Randrianasulu]

On Friday, August 6, 2021, Andrea paz <gamberucci.andrea at gmail.com> wrote:

> Also the second patch does not work on my CinGG: neither using RMB +
> attach effect nor using Video --> attach effect.



o. O

no idea why... can you visually inspect patched files
(cinelerra/plugindialog.C and cinelerra/mwindowedit.C) and confirm those
calls actually changed?

$ cat in_out_selection.diff
diff --git a/cinelerra-5.1/cinelerra/mwindowedit.C
b/cinelerra-5.1/cinelerra/mwindowedit.C
index 6744cee8..458ced96 100644
--- a/cinelerra-5.1/cinelerra/mwindowedit.C
+++ b/cinelerra-5.1/cinelerra/mwindowedit.C
@@ -841,8 +841,8 @@ void MWindow::insert_effect(char *title, SharedLocation
*shared_location,
        SharedLocation shared_location_local;
        shared_location_local.copy_from(shared_location);
        int first_track = 1;
- double start_pos = edl->local_session->get_selectionstart(1);
- double end_pos = edl->local_session->get_selectionend(1);
+ double start_pos = edl->local_session->get_selectionstart();
+ double end_pos = edl->local_session->get_selectionend();
        for( ; current; current=NEXT ) {
                if( current->data_type != data_type ) continue;
                if( !current->is_armed() ) continue;
$ cat in_out_selection-2.diff
diff --git a/cinelerra-5.1/cinelerra/plugindialog.C
b/cinelerra-5.1/cinelerra/plugindialog.C
index 48f470e6..fa24bb5b 100644
--- a/cinelerra-5.1/cinelerra/plugindialog.C
+++ b/cinelerra-5.1/cinelerra/plugindialog.C
@@ -463,8 +463,8 @@ void PluginDialogThread::apply()
                                        &shared_location, plugin_type);
                }
                else if( edl->tracks->track_exists(track) ) {
- double start = edl->local_session->get_selectionstart(1);
- double end = edl->local_session->get_selectionend(1);
+ double start = edl->local_session->get_selectionstart();
+ double end = edl->local_session->get_selectionend();
                        if( start >= end ) {
                                start = 0;
                                end = track->get_length();
$

No messages appear on the terminal.
>

this is normal, this time i did not added any  debug printfs)
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <https://lists.cinelerra-gg.org/pipermail/cin/attachments/20210806/a408de1a/attachment.htm>