[Cin] unaligned load in bctheme

[Phyllis Smith]

Andrew, thanks for the website reference.
Checked in patch to GIT this morning.  I do not think you need to go out of
your way to test and build on other systems.  Thanks, Phyllis

On Mon, Dec 5, 2022 at 4:14 AM Andrew Randrianasulu <randrianasulu at gmail.com>
wrote:

>
>
> вс, 4 дек. 2022 г., 17:51 Phyllis Smith <phylsmith2017 at gmail.com>:
>
>>
>> On 4 different systems I was only able to include in guicast/Makefile,
>>>> the CFLAGS += $(-fsanitize=alignment) and set the LDFLAGS environment
>>>> variable to -fsanitize=alignment in order to compile.  But when I ran
>>>> bin/cin I never got any errors of the type "bctheme.C:458:15: runtime
>>>> error: load of misaligned address".  This was Fedora 32, Ubuntu 16, Debian
>>>> 32-bit 9.1, and Debian 11.0.  I only loaded a file, played a little of it,
>>>> and added a plugin as a test (maybe there was something in particular I
>>>> should have tried?)
>>>>
>>>
>>>
>>> no, it was right on startup on Slackware 15.0 (mostly) 32-bit over
>>> 64-bit kernel....
>>>
>>> I'll try on ppc32 machine hopefully soon (ppc/sparc/alpha said to be
>>> much more sensitive to such errors)
>>>
>>> That was Debian 11.0 32-bit that I tested it on, not 64 bit.
>> If the patch fixes it for Slackware 15.0 and since it does not seem to
>> add any problems for other distros, we can check it into GIT.
>>
>
>
> may be it only fires when I run 32-bit cingg over 64 bit kernel? Sorry I
> still not performed any experimentation due to some coughing type of health
> problems
>
>   I just do not understand the patch at all because I don't know C code
>> and can not tell if the code is better with essentially the same outcome.
>>
>
>
> Explanation I found on the web says it fixes it because memcpy from libc
> and thus know how and where align things
>
>
> https://hackaday.com/2022/05/10/data-alignment-across-architectures-the-good-the-bad-and-the-ugly/
>
>
>
>>
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <https://lists.cinelerra-gg.org/pipermail/cin/attachments/20221206/345065d0/attachment.htm>