[Cin] possible alpha bug in processing

[Andrew Randrianasulu]

вс, 20 нояб. 2022 г., 03:56 Phyllis Smith via Cin <
cin at lists.cinelerra-gg.org>:

> As IgorBeghetto recommended, I checked into GIT the change of 0xff to 0x00
> in virtualvconsole.C as Andrew provided in his patch "
> 0001-background-clear-in-vconsole-must-be-set-to-0.patch". It will be easy
> to undo if Igor and his computer, Charlie, find a problem with it.
> (Actually I never figured out how to back something out of GIT, I just add
> back the original).
>


try 'git revert hash' as in

git revert 8dfg44f

just where hash is first 8 digits or more from commit id as seen in git log.

it should bring up your editor so you can write additional reason for
reverting. After saving text there commit with revert and your note will be
written to git. Just as with normal git commit you probably can escape at
last moment by pressing escape in editor, but this will leave your tree in
some need for
 'git reset --hard old_hash' where old_hash is good commit before you
strted aborted command.



> Good find by Goat and glad Andrea and IgorBeghetto were able to see that
> the correction fixes render using PNG, EXR, and TGA.  (I still wonder what
> "Goat" stands for?).
>

https://www.linux.org.ru/people/Goat/profile


> On Thu, Nov 17, 2022 at 1:50 AM Igor BEGHETTO via Cin <
> cin at lists.cinelerra-gg.org> wrote:
>
>> I think patch's Andrew would solve MantisBT_0000558 issue
>> (https://www.cinelerra-gg.org/bugtracker/view.php?id=558) but I didn't
>> try.
>> I will try next week end to make a build and doing some tests, I hope.
>> Meanwhile other users could test their old Project with to see if the
>> patch creates other problems.
>> Phyllis could create a commit in GIT only for that patch so, if
>> something goes wrong, we can go back easily, or at least, it is what I
>> think.
>>
>> IgorBeg
>>
>>
>> Phyllis wrote:
>> > Yes, seems to be a problem, but I have no idea what the repercussions
>> > of the patch would be based on the following in the  release notes for
>> > September 2020 which says in the Bugs/Issues fixed:
>> >   "Alpha is being set to 1 for background color always now – just a
>> > missing thing."
>>
>> Andrew wrote:
>> >
>> https://git.cinelerra-gg.org/git/?p=goodguy/cinelerra.git;a=blobdiff;f=cinelerra-5.1/cinelerra/virtualvconsole.C;h=3c3fb86f5710e15954c927f358210027cb819ed1;hp=193761b6763a61d11b0b85c8edbb4ec658df2b99;hb=abdff69b9309c7d5cd2ed6ce17dd2e0d85aef9a1;hpb=0b751b07a28e84a721b2bb76083db6629aa26d73
>> >
>> > i tried to set alpha to 0 (zero) in virtialvconsole and suddently pngs
>> > and exrs and tgas got their alpha back!
>>
>> --
>> Cin mailing list
>> Cin at lists.cinelerra-gg.org
>> https://lists.cinelerra-gg.org/mailman/listinfo/cin
>>
> --
> Cin mailing list
> Cin at lists.cinelerra-gg.org
> https://lists.cinelerra-gg.org/mailman/listinfo/cin
>
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <https://lists.cinelerra-gg.org/pipermail/cin/attachments/20221120/d5bee63e/attachment-0001.htm>