[Cin] in/out point selected plugin attach fix?

[Andrew Randrianasulu]

On Saturday, August 7, 2021, Phyllis Smith via Cin <
cin at lists.cinelerra-gg.org> wrote:

> Andrew, more testing of "many tracks (armed/disarmed), many plugins,
> shared plugins, gang modes, etc...?" and it seems like a really good fix.
> Will wait to hear back from Andrea too.
>
> But there must be one more place that needs the same type of fix yet for
> GANG audio mode.  This is currently working if you drag an audio plugin to
> a 2-channel audio track - that is, when you get back to regular mode you
> can see that the plugin is on both audio tracks.  But when you have In/Out
> pointers and use the "attach effect" method instead, it only shows on the
> initial track.
>

i tried to add two more lines into mwindowedit.C


and for me I can select in/out points for two gang modes where sound tracks
collapsed on timeline (with 6ch divx) and then use audio > attach effect
for inserting effect and it propagates correctly


>
> Andrea, you have to have both patches in: in_out_selection.diff AND
> in_out_selection-2.diff .
>
> On Fri, Aug 6, 2021 at 10:14 AM Andrew Randrianasulu via Cin <
> cin at lists.cinelerra-gg.org> wrote:
>
>> what about attached second patch?
>>
>> please also test main menu bar > video > atrach effect way..
>>
>>
>> On Friday, August 6, 2021, Andrea paz <gamberucci.andrea at gmail.com>
>> wrote:
>>
>>> I confirm that the patch does not work. The In/Out points do not
>>> create a valid region for "attach effect". It works instead, as
>>> before, for the Drag&Drop effect from the Resources window.
>>>
>> --
>> Cin mailing list
>> Cin at lists.cinelerra-gg.org
>> https://lists.cinelerra-gg.org/mailman/listinfo/cin
>>
>
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <https://lists.cinelerra-gg.org/pipermail/cin/attachments/20210807/defeebd3/attachment.htm>
-------------- next part --------------
diff --git a/cinelerra-5.1/cinelerra/mwindowedit.C b/cinelerra-5.1/cinelerra/mwindowedit.C
index 458ced96..729611d9 100644
--- a/cinelerra-5.1/cinelerra/mwindowedit.C
+++ b/cinelerra-5.1/cinelerra/mwindowedit.C
@@ -840,10 +840,12 @@ void MWindow::insert_effect(char *title, SharedLocation *shared_location,
 	Track *current = edl->tracks->first;
 	SharedLocation shared_location_local;
 	shared_location_local.copy_from(shared_location);
+	int gang = edl->local_session->gang_tracks != GANG_NONE ? 1 : 0;
 	int first_track = 1;
 	double start_pos = edl->local_session->get_selectionstart();
 	double end_pos = edl->local_session->get_selectionend();
 	for( ; current; current=NEXT ) {
+		if( gang && current->master && !first_track ) break;
 		if( current->data_type != data_type ) continue;
 		if( !current->is_armed() ) continue;
 		double start = start_pos, end = end_pos;