[Cin] UPD: Re: Debate on batch render

Andrew Randrianasulu randrianasulu at gmail.com
Tue Jan 12 11:35:30 CET 2021


OH, NO, this patch actually breaks batch render :/
some more thinking needed even just for hiding this element .....

SORRY!

PS; I see you can use batch render window _without_ any project loaded on timeline ....

----------  Пересланное сообщение  ----------

Тема: Re: [Cin] Debate on batch render
Дата: Вторник 12 января 2021
Отправитель: Andrew Randrianasulu <randrianasulu at gmail.com>
Получатель:  "Cinelerra.GG" <cin at lists.cinelerra-gg.org>

В сообщении от Tuesday 12 January 2021 11:13:56 Rafa Mar Multimedia en Gnu\Linux via Cin написал(а):
> Thanks again Andrew. I hardly know how to add a repository and if it
> doesn't work or doesn't work correctly I go back to the previous one.
> Regards.

Ok, I think I disabled them by just commenting out their initialization.
Button and checkbox disappeared, but probably some state still will be around, so this
is NOT for merging, just for testing by interested parties .....


diff --git a/cinelerra-5.1/cinelerra/batchrender.C b/cinelerra-5.1/cinelerra/batchrender.C
index 6dcdbc62..35822142 100644
--- a/cinelerra-5.1/cinelerra/batchrender.C
+++ b/cinelerra-5.1/cinelerra/batchrender.C
@@ -792,8 +792,8 @@ void BatchRenderGUI::create_objects()
        y2 = y + edl_path_browse->get_h() + mwindow->theme->widget_border;
 
        x = x2;  y = y2;
-       add_subwindow(update_selected_edl = new BatchRenderUpdateEDL(thread, x, y));
-       y += update_selected_edl->get_h() + mwindow->theme->widget_border;
+//     add_subwindow(update_selected_edl = new BatchRenderUpdateEDL(thread, x, y));
+//     y += update_selected_edl->get_h() + mwindow->theme->widget_border;
        add_subwindow(use_current_edl = new BatchRenderCurrentEDL(thread, x, y));
        y += use_current_edl->get_h() + mwindow->theme->widget_border;
        if( !mwindow->edl || !mwindow->edl->path[0] ) use_current_edl->disable();
@@ -805,8 +805,8 @@ void BatchRenderGUI::create_objects()
        x += savelist_batch->get_w() + mwindow->theme->widget_border;
        add_subwindow(loadlist_batch = new BatchRenderLoadList(thread, x, y));
        y += loadlist_batch->get_h() + mwindow->theme->widget_border;
-       add_subwindow(warning = new BatchRenderWarning(thread, x2, y));
-       y2 = y + warning->get_h() + mwindow->theme->widget_border;
+//     add_subwindow(warning = new BatchRenderWarning(thread, x2, y));
+//     y2 = y + warning->get_h() + mwindow->theme->widget_border;
        if( y2 > y1 ) y1 = y2;
        x = mwindow->theme->batchrender_x1, y = y1;
 
---

Does new window look safer? If you think so - patch sources and try your workflow
while I'm thinking/learning about how to add warnings or conditionally show/hide those :}

I think my tooltips patch still applicable ....because it touches different block of code

-------------------------------------------------------


More information about the Cin mailing list