- Cin - Cinelerra-GG Mailing Lists

I tried to restore "Warn on EDL version mismatch' preference setting
by Andrew Randrianasulu 13 Jan '21

13 Jan '21

I tested with with artificially modified project file (changed version to 5.0) it seems to work, and now this psecific warning show up depending on preferences setting/toggle. --- diff --git a/cinelerra-5.1/cinelerra/mwindow.C b/cinelerra-5.1/cinelerra/mwindow.C index 04549fde..8551c2e3 100644 --- a/cinelerra-5.1/cinelerra/mwindow.C +++ b/cinelerra-5.1/cinelerra/mwindow.C @@ -2211,8 +2211,11 @@ if(debug) printf("MWindow::load_filenames %d\n", __LINE__); if( strcmp(cin_version, CINELERRA_VERSION) && strcmp(cin_version, "Unify") && strcmp(cin_version, "5.1") ) { - eprintf(_("Warning: XML from cinelerra version %s\n" - "Session data may be incompatible."), cin_version); + char string[BCTEXTLEN]; + snprintf(string, sizeof(string), + _("Warning: XML from cinelerra version %s\n" + "Session data may be incompatible."), cin_version); + show_warning(&preferences->warn_version, string); } if( new_edl->load_xml(&xml_file, LOAD_ALL) ) { eprintf(_("Error: unable to load:\n %s"), filename); --- But I have another warning coming from plugin server (because in old CinGG plugin names were localized) Still, old Cin 5.1 project can be loaded if I insist (load it again after warning first show up) Not sure if we should consider this bug or feature .....

1 0

'Warn on version mismatch' historical research ...
by Andrew Randrianasulu 13 Jan '21

13 Jan '21

It seems this flag was introduced in this commit: https://git.cinelerra-gg.org/git/?p=goodguy/history.git;a=commit;h=9e779f63… author Good Guy <good1.2guy(a)gmail.com> Wed, 7 Sep 2016 01:18:17 +0300 (16:18 -0600) committer Good Guy <good1.2guy(a)gmail.com> Wed, 7 Sep 2016 01:18:17 +0300 (16:18 -0600) rework svg plugin, fast flash flush, init resize pixmaps, test edl version so, it was testing version in mwindow.C https://git.cinelerra-gg.org/git/?p=goodguy/history.git;a=blobdiff;f=cinele… (sorry for ultralong line) - + const char *cin_version = 0; + while( !xml_file.read_tag() ) { + if( xml_file.tag.title_is("EDL") ) { + cin_version = xml_file.tag.get_property("VERSION"); + break; + } + } + xml_file.rewind(); + if( !cin_version ) { + eprintf(_("XML file %s\n not from cinelerra."),filenames->get(i)); + char string[BCTEXTLEN]; + sprintf(string,_("Unknown %s"), filenames->get(i)); + gui->show_message(string); + result = 1; + break; + } + if( strcmp(cin_version, CINELERRA_VERSION) ) { + char string[BCTEXTLEN]; + snprintf(string, sizeof(string), + _("Warning: XML from cinelerra version %s\n" + "Session data may be incompatible."), cin_version); + show_warning(&preferences->warn_version, string); + } hm ... in current we have .... https://git.cinelerra-gg.org/git/?p=goodguy/cinelerra.git;a=blob;f=cinelerr… 2196 const char *cin_version = 0; 2197 while( !xml_file.read_tag() ) { 2198 if( xml_file.tag.title_is("EDL") ) { 2199 cin_version = xml_file.tag.get_property("VERSION"); 2200 break; 2201 } 2202 } 2203 xml_file.rewind(); 2204 if( !cin_version ) { 2205 eprintf(_("XML file %s\n not from cinelerra."),filename); 2206 char string[BCTEXTLEN]; 2207 sprintf(string,_("Unknown %s"), filename); 2208 gui->show_message(string); 2209 break; 2210 } 2211 if( strcmp(cin_version, CINELERRA_VERSION) && 2212 strcmp(cin_version, "Unify") && 2213 strcmp(cin_version, "5.1") ) { 2214 eprintf(_("Warning: XML from cinelerra version %s\n" 2215 "Session data may be incompatible."), cin_version); 2216 } so, IT SEEMS this preference simply unused now? Should we try to repair it, or just remove this warning checkbox altogether? (or possible replace it with 'unsafe_button_in_batchrender' preference?) I think replacing eprintf with show_warning still will do work, but need to check!

1 0

Second attempt at simplifying BatchRender window
by Andrew Randrianasulu 13 Jan '21

13 Jan '21

This time I hopefully found how to NOT initialize this variable, and not load it from file either .... Try this patch instead of any my previous attempts ... sorry! ---- diff --git a/cinelerra-5.1/cinelerra/batchrender.C b/cinelerra-5.1/cinelerra/batchrender.C index 6dcdbc62..f9a91fff 100644 --- a/cinelerra-5.1/cinelerra/batchrender.C +++ b/cinelerra-5.1/cinelerra/batchrender.C @@ -60,6 +60,8 @@ #include "dvdcreate.h" #include "bdcreate.h" +#define UNSAFE_BUTTON 0 + int BatchRenderThread::column_widths[] = { 42, 42, 42, 222, 222, 150 }; const char *BatchRenderThread::column_titles[] = { N_("Enabled"), N_("Labeled"), N_("Farmed"), N_("Output"), N_("EDL"), N_("Elapsed") @@ -197,7 +199,10 @@ BatchRenderThread::BatchRenderThread(MWindow *mwindow) default_job = 0; boot_defaults = 0; preferences = 0; + + if (UNSAFE_BUTTON) warn = 1; + render = 0; batch_path[0] = 0; do_farmed = 0; @@ -217,6 +222,7 @@ void BatchRenderThread::reset(const char *path) { if( path ) { strcpy(batch_path, path); + if (UNSAFE_BUTTON) warn = 1; } current_job = 0; @@ -268,6 +274,7 @@ void BatchRenderThread::load_jobs(char *path, Preferences *preferences) while( !result ) { if( !(result = file.read_tag()) ) { if( file.tag.title_is("JOBS") ) { + if (UNSAFE_BUTTON) warn = file.tag.get_property("WARN", 1); } else if( file.tag.title_is("JOB") ) { @@ -293,6 +300,7 @@ void BatchRenderThread::save_jobs(char *path) { FileXML file; file.tag.set_title("JOBS"); + if (UNSAFE_BUTTON) file.tag.set_property("WARN", warn); file.append_tag(); file.append_newline(); @@ -382,6 +390,7 @@ void BatchRenderThread::use_current_edl() gui->edl_path_text->update(get_current_edl()); } + void BatchRenderThread::update_selected_edl() { FileXML xml_file; @@ -792,8 +801,12 @@ void BatchRenderGUI::create_objects() y2 = y + edl_path_browse->get_h() + mwindow->theme->widget_border; x = x2; y = y2; + + if (UNSAFE_BUTTON) { add_subwindow(update_selected_edl = new BatchRenderUpdateEDL(thread, x, y)); y += update_selected_edl->get_h() + mwindow->theme->widget_border; + } + add_subwindow(use_current_edl = new BatchRenderCurrentEDL(thread, x, y)); y += use_current_edl->get_h() + mwindow->theme->widget_border; if( !mwindow->edl || !mwindow->edl->path[0] ) use_current_edl->disable(); @@ -805,8 +818,12 @@ void BatchRenderGUI::create_objects() x += savelist_batch->get_w() + mwindow->theme->widget_border; add_subwindow(loadlist_batch = new BatchRenderLoadList(thread, x, y)); y += loadlist_batch->get_h() + mwindow->theme->widget_border; + + if (UNSAFE_BUTTON) { add_subwindow(warning = new BatchRenderWarning(thread, x2, y)); y2 = y + warning->get_h() + mwindow->theme->widget_border; + } + if( y2 > y1 ) y1 = y2; x = mwindow->theme->batchrender_x1, y = y1; @@ -835,6 +852,7 @@ void BatchRenderGUI::button_disable() new_batch->disable(); delete_batch->disable(); use_current_edl->disable(); + if (UNSAFE_BUTTON) update_selected_edl->disable(); } @@ -844,6 +862,7 @@ void BatchRenderGUI::button_enable() delete_batch->enable(); if( mwindow->edl && mwindow->edl->path[0] ) use_current_edl->enable(); + if (UNSAFE_BUTTON) update_selected_edl->enable(); } @@ -876,8 +895,12 @@ int BatchRenderGUI::resize_event(int w, int h) y2 = y + edl_path_browse->get_h() + mwindow->theme->widget_border; x = x2; y = y2; + + if (UNSAFE_BUTTON) { update_selected_edl->reposition_window(x, y); y += update_selected_edl->get_h() + mwindow->theme->widget_border; + } + use_current_edl->reposition_window(x, y); y += use_current_edl->get_h() + mwindow->theme->widget_border; new_batch->reposition_window(x, y); @@ -889,9 +912,12 @@ int BatchRenderGUI::resize_event(int w, int h) x += savelist_batch->get_w() + mwindow->theme->widget_border; loadlist_batch->reposition_window(x, y); y += loadlist_batch->get_h() + mwindow->theme->widget_border; + if (UNSAFE_BUTTON) { warning->reposition_window(x2, y); y1 = ys15 + BC_GenericButton::calculate_h() + mwindow->theme->widget_border; + } + y2 = get_h() - y1 - batch_list->get_h(); y2 -= list_title->get_h() + mwindow->theme->widget_border; @@ -1236,6 +1262,7 @@ int BatchRenderCurrentEDL::handle_event() return 1; } + BatchRenderUpdateEDL::BatchRenderUpdateEDL(BatchRenderThread *thread, int x, int y) @@ -1244,8 +1271,10 @@ BatchRenderUpdateEDL::BatchRenderUpdateEDL(BatchRenderThread *thread, this->thread = thread; } + int BatchRenderUpdateEDL::handle_event() { + if (UNSAFE_BUTTON) thread->update_selected_edl(); return 1; } @@ -1374,6 +1403,7 @@ BatchRenderWarning::BatchRenderWarning(BatchRenderThread *thread, int x, int y) int BatchRenderWarning::handle_event() { + if (UNSAFE_BUTTON) thread->warn = get_value(); return 1; } ----

2 3

Attempt at disabling 'Save to EDL' in batchrender GUI at compile-time
by Andrew Randrianasulu 12 Jan '21

12 Jan '21

This one survived actual batch render - I forgot about enable/disable button calls .... so, if you set UNSAFE_BUTTON to 1 it will appear, if you leave it at 0 it will be hidden. Now, if THIS patch actually works we can think about hooking it up to pref window ..... --- diff --git a/cinelerra-5.1/cinelerra/batchrender.C b/cinelerra-5.1/cinelerra/batchrender.C index 6dcdbc62..d85d0e8c 100644 --- a/cinelerra-5.1/cinelerra/batchrender.C +++ b/cinelerra-5.1/cinelerra/batchrender.C @@ -60,6 +60,8 @@ #include "dvdcreate.h" #include "bdcreate.h" +#define UNSAFE_BUTTON 0 + int BatchRenderThread::column_widths[] = { 42, 42, 42, 222, 222, 150 }; const char *BatchRenderThread::column_titles[] = { N_("Enabled"), N_("Labeled"), N_("Farmed"), N_("Output"), N_("EDL"), N_("Elapsed") @@ -382,6 +384,7 @@ void BatchRenderThread::use_current_edl() gui->edl_path_text->update(get_current_edl()); } + void BatchRenderThread::update_selected_edl() { FileXML xml_file; @@ -396,6 +399,8 @@ void BatchRenderThread::update_selected_edl() } } + + BatchRenderJob* BatchRenderThread::get_current_job() { return current_job >= 0 && current_job < jobs.total ? @@ -792,8 +797,11 @@ void BatchRenderGUI::create_objects() y2 = y + edl_path_browse->get_h() + mwindow->theme->widget_border; x = x2; y = y2; + if (UNSAFE_BUTTON) { add_subwindow(update_selected_edl = new BatchRenderUpdateEDL(thread, x, y)); y += update_selected_edl->get_h() + mwindow->theme->widget_border; +} + add_subwindow(use_current_edl = new BatchRenderCurrentEDL(thread, x, y)); y += use_current_edl->get_h() + mwindow->theme->widget_border; if( !mwindow->edl || !mwindow->edl->path[0] ) use_current_edl->disable(); @@ -835,6 +843,7 @@ void BatchRenderGUI::button_disable() new_batch->disable(); delete_batch->disable(); use_current_edl->disable(); + if (UNSAFE_BUTTON) update_selected_edl->disable(); } @@ -844,6 +853,7 @@ void BatchRenderGUI::button_enable() delete_batch->enable(); if( mwindow->edl && mwindow->edl->path[0] ) use_current_edl->enable(); + if (UNSAFE_BUTTON) update_selected_edl->enable(); } @@ -876,8 +886,10 @@ int BatchRenderGUI::resize_event(int w, int h) y2 = y + edl_path_browse->get_h() + mwindow->theme->widget_border; x = x2; y = y2; + if (UNSAFE_BUTTON) { update_selected_edl->reposition_window(x, y); y += update_selected_edl->get_h() + mwindow->theme->widget_border; +} use_current_edl->reposition_window(x, y); y += use_current_edl->get_h() + mwindow->theme->widget_border; new_batch->reposition_window(x, y); @@ -1236,6 +1248,7 @@ int BatchRenderCurrentEDL::handle_event() return 1; } + BatchRenderUpdateEDL::BatchRenderUpdateEDL(BatchRenderThread *thread, int x, int y) @@ -1244,8 +1257,10 @@ BatchRenderUpdateEDL::BatchRenderUpdateEDL(BatchRenderThread *thread, this->thread = thread; } + int BatchRenderUpdateEDL::handle_event() { + if (UNSAFE_BUTTON) thread->update_selected_edl(); return 1; } ----

3 2

UPD: Re: Debate on batch render
by Andrew Randrianasulu 12 Jan '21

12 Jan '21

OH, NO, this patch actually breaks batch render :/ some more thinking needed even just for hiding this element ..... SORRY! PS; I see you can use batch render window _without_ any project loaded on timeline .... ---------- Пересланное сообщение ---------- Тема: Re: [Cin] Debate on batch render Дата: Вторник 12 января 2021 Отправитель: Andrew Randrianasulu <randrianasulu(a)gmail.com> Получатель: "Cinelerra.GG" <cin(a)lists.cinelerra-gg.org> В сообщении от Tuesday 12 January 2021 11:13:56 Rafa Mar Multimedia en Gnu\Linux via Cin написал(а): > Thanks again Andrew. I hardly know how to add a repository and if it > doesn't work or doesn't work correctly I go back to the previous one. > Regards. Ok, I think I disabled them by just commenting out their initialization. Button and checkbox disappeared, but probably some state still will be around, so this is NOT for merging, just for testing by interested parties ..... diff --git a/cinelerra-5.1/cinelerra/batchrender.C b/cinelerra-5.1/cinelerra/batchrender.C index 6dcdbc62..35822142 100644 --- a/cinelerra-5.1/cinelerra/batchrender.C +++ b/cinelerra-5.1/cinelerra/batchrender.C @@ -792,8 +792,8 @@ void BatchRenderGUI::create_objects() y2 = y + edl_path_browse->get_h() + mwindow->theme->widget_border; x = x2; y = y2; - add_subwindow(update_selected_edl = new BatchRenderUpdateEDL(thread, x, y)); - y += update_selected_edl->get_h() + mwindow->theme->widget_border; +// add_subwindow(update_selected_edl = new BatchRenderUpdateEDL(thread, x, y)); +// y += update_selected_edl->get_h() + mwindow->theme->widget_border; add_subwindow(use_current_edl = new BatchRenderCurrentEDL(thread, x, y)); y += use_current_edl->get_h() + mwindow->theme->widget_border; if( !mwindow->edl || !mwindow->edl->path[0] ) use_current_edl->disable(); @@ -805,8 +805,8 @@ void BatchRenderGUI::create_objects() x += savelist_batch->get_w() + mwindow->theme->widget_border; add_subwindow(loadlist_batch = new BatchRenderLoadList(thread, x, y)); y += loadlist_batch->get_h() + mwindow->theme->widget_border; - add_subwindow(warning = new BatchRenderWarning(thread, x2, y)); - y2 = y + warning->get_h() + mwindow->theme->widget_border; +// add_subwindow(warning = new BatchRenderWarning(thread, x2, y)); +// y2 = y + warning->get_h() + mwindow->theme->widget_border; if( y2 > y1 ) y1 = y2; x = mwindow->theme->batchrender_x1, y = y1; --- Does new window look safer? If you think so - patch sources and try your workflow while I'm thinking/learning about how to add warnings or conditionally show/hide those :} I think my tooltips patch still applicable ....because it touches different block of code -------------------------------------------------------

1 0

ffmpeg gl-transition
by preobraz＠gmail.com 11 Jan '21

11 Jan '21

Hi all! If you build ffmpeg with gl-transition support, you can get amazing new effects with it: https://gl-transitions.com/gallery Will this work in Cinelerra-GG if it is assembled with such an ffmpeg: https://github.com/transitive-bullshit/ffmpeg-gl-transition ? -- Ugin.

3 3

Release of CinGG
by Andrea paz 06 Jan '21

06 Jan '21

About the forum post: https://www.cinelerra-gg.org/forum/everything-else/single-user-builds/#post… You could try to create your own binary, each for your own distro, and then make it available. Is this feasible? I would need detailed instructions, because I don't know how to do it!

5 4

CinGG manual
by Andrea paz 02 Jan '21

02 Jan '21

Phyllis has put the new revision of the manual on the website in PDF and HTML. Some sections have been moved: Subtitles is now in Advanced Editing and various rendering examples scattered throughout various sections have been reunited in the Rendering chapter. Do these variations sound good to you? Going back is easy with LaTeX. The section on subtitles does not seem to be good to me. Do you have suggestions on how to improve it, extend it and make it more useful? If you have recommendations on certain parts of the manual, please share them. By now the basic structure is stable, but the content needs many improvements (for example Viewport and Camera/Projector, etc).

2 1

sequential rendering of multiple projects
by preobraz＠gmail.com 31 Dec '20

31 Dec '20

Hi all! I want to render several projects at once (the rendering options are the same). Is there such an opportunity in Cinelerra? -- Ugin

3 4

CinGG Youtube channel
by Andrea paz 26 Dec '20

26 Dec '20

Curiosity about CinGG's Youtube channel: Since its creation, we've made it past 200 subscribers (201); we've had 6974 views for a total of 205 hours of viewing. Sounds like a good result to me!

3 2